Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various -Werror build failures #13578

Conversation

mcatanzaro
Copy link
Contributor

@mcatanzaro mcatanzaro commented May 8, 2023

d76f2c4

Fix various -Werror build failures
https://bugs.webkit.org/show_bug.cgi?id=256466

Unreviewed build fixes.

Fix unused variable warnings, plus placate Clang's overaggressive
-Wmissing-field-initializers in MiniBrowser.

* Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:
* Tools/MiniBrowser/gtk/main.c:
(addSettingsGroupToContext):
* Tools/TestWebKitAPI/Tests/WebCore/FloatSizeTests.cpp:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/263801@main

007b8c0

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug   πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl   πŸ§ͺ ios-wk2   πŸ§ͺ api-mac βœ… πŸ›  gtk
  πŸ§ͺ ios-wk2-wpt   πŸ§ͺ mac-wk1   πŸ§ͺ gtk-wk2
  πŸ§ͺ api-ios   πŸ§ͺ mac-wk2   πŸ§ͺ api-gtk
βœ… πŸ›  tv   πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  tv-sim
❌ πŸ›  πŸ§ͺ merge βœ… πŸ›  watch
βœ… πŸ›  πŸ§ͺ unsafe-merge βœ… πŸ›  watch-sim

@mcatanzaro mcatanzaro requested review from a team and philn as code owners May 8, 2023 15:34
@mcatanzaro mcatanzaro self-assigned this May 8, 2023
@mcatanzaro mcatanzaro added the WebKitGTK Bugs related to the Gtk API layer. label May 8, 2023
@mcatanzaro mcatanzaro added merge-queue Applied to send a pull request to merge-queue unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merge-queue Applied to send a pull request to merge-queue labels May 8, 2023
https://bugs.webkit.org/show_bug.cgi?id=256466

Unreviewed build fixes.

Fix unused variable warnings, plus placate Clang's overaggressive
-Wmissing-field-initializers in MiniBrowser.

* Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:
* Tools/MiniBrowser/gtk/main.c:
(addSettingsGroupToContext):
* Tools/TestWebKitAPI/Tests/WebCore/FloatSizeTests.cpp:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/263801@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Fix-various--Werror-build-failures branch from 007b8c0 to d76f2c4 Compare May 8, 2023 15:38
@webkit-commit-queue
Copy link
Collaborator

Committed 263801@main (d76f2c4): https://commits.webkit.org/263801@main

Reviewed commits have been landed. Closing PR #13578 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit d76f2c4 into WebKit:main May 8, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 8, 2023
@mcatanzaro mcatanzaro deleted the eng/Fix-various--Werror-build-failures branch May 8, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebKitGTK Bugs related to the Gtk API layer.
Projects
None yet
4 participants