Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unreviewed build fix on macOS #13586

Merged
merged 1 commit into from
May 8, 2023
Merged

Unreviewed build fix on macOS #13586

merged 1 commit into from
May 8, 2023

Conversation

cdumez
Copy link
Contributor

@cdumez cdumez commented May 8, 2023 •
edited by webkit-early-warning-system

@cdumez cdumez self-assigned this May 8, 2023
@cdumez cdumez added the Media Bugs related to the HTML 5 Media elements. label May 8, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 6e86218)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
  🧪 ios-wk2-wpt   🧪 mac-wk1   🧪 gtk-wk2
  🧪 api-ios   🧪 mac-wk2   🧪 api-gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2
⏳ 🛠 tv-sim
✅ 🛠 watch
⏳ 🛠 watch-sim

@cdumez cdumez added the merging-blocked Applied to prevent a change from being merged label May 8, 2023
@cdumez
Copy link
Contributor Author

cdumez commented May 8, 2023

Eric suggested a better fix.

@cdumez cdumez removed the merging-blocked Applied to prevent a change from being merged label May 8, 2023
@cdumez cdumez force-pushed the eng/Unreviewed-build-fix-on-macOS branch from 6e86218 to cab7c96 Compare May 8, 2023 17:55
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash cab7c96)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
  🧪 ios-wk2-wpt   🧪 mac-wk1   🧪 gtk-wk2
  🧪 api-ios   🧪 mac-wk2   🧪 api-gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2
  🛠 tv-sim
  🛠 watch
✅ 🛠 🧪 unsafe-merge   🛠 watch-sim

@cdumez cdumez added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 8, 2023
@cdumez
Unreviewed build fix on macOS
6537be3 
https://bugs.webkit.org/show_bug.cgi?id=256476
rdar://109042873

* Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm:
(-[WebAVPlayerViewController enterFullScreenAnimated:completionHandler:]):

Canonical link: https://commits.webkit.org/263804@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Unreviewed-build-fix-on-macOS branch from cab7c96 to 6537be3 Compare May 8, 2023 17:59
@webkit-commit-queue
Copy link
Collaborator

Committed 263804@main (6537be3): https://commits.webkit.org/263804@main

Reviewed commits have been landed. Closing PR #13586 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 6537be3 into WebKit:main May 8, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-carlson eric-carlson eric-carlson approved these changes

Assignees

@cdumez cdumez

Labels
Media Bugs related to the HTML 5 Media elements.
Projects
None yet
Milestone
No milestone
4 participants
@cdumez @webkit-early-warning-system @webkit-commit-queue @eric-carlson