Regression(262025@main) WebProcesses on macOS 13.0 are still marked as managed by RunningBoard #13599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on previous version of this PR (hash a2ca13c) |
cdumez
force-pushed
the
256489_processes_managed_by_runningboard
branch
from
a2ca13c
to
6b542ce
Compare
|
EWS run on previous version of this PR (hash 6b542ce)
|
cdumez
force-pushed
the
256489_processes_managed_by_runningboard
branch
from
6b542ce
to
5baef03
Compare
|
EWS run on current version of this PR (hash 5baef03)
|
bnham
approved these changes
May 8, 2023
cdumez
added
unsafe-merge-queue
…s managed by RunningBoard https://bugs.webkit.org/show_bug.cgi?id=256489 rdar://108417115 Reviewed by Geoffrey Garen and Ben Nham. WebProcesses on macOS 13.0 are still marked as managed by RunningBoard even though 262025@main made it so that we only use RunningBoard assertions on macOS 13.3+. USE(RUNNINGBOARD) requires `__MAC_OS_X_VERSION_MIN_REQUIRED >= 130300` after 262025@main but update-info-plist-for-runningboard.sh was still checking for 130000. This meant RunningBoard was managing process priority on macOS 13.0+ even though we are only taking RunningBoard assertion on macOS 13.3+. This was causing our processes to have low priority. * Source/WebKit/Scripts/update-info-plist-for-runningboard.sh: Canonical link: https://commits.webkit.org/263830@main
webkit-commit-queue
force-pushed
the
256489_processes_managed_by_runningboard
branch
from
5baef03
to
99c9a20
Compare
|
Committed 263830@main (99c9a20): https://commits.webkit.org/263830@main Reviewed commits have been landed. Closing PR #13599 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
99c9a20
5baef03
🛠 wincairo🧪 wpe-wk2🧪 ios-wk2🧪 api-mac🧪 ios-wk2-wpt🧪 gtk-wk2🧪 api-ios🧪 mac-wk2🧪 api-gtk🧪 mac-AS-debug-wk2🛠 tv-sim🛠 🧪 merge🛠 watch-sim