New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WPE][GStreamer] support auto-pluging of different sinks #13612
[WPE][GStreamer] support auto-pluging of different sinks #13612
Conversation
EWS run on previous version of this PR (hash bf72c05) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Title of the PR has to be in the first line of the commit log. Bug URL has to be in the second line of the log. After these two lines you need to have Reviewed by NOBODY (OOPS!).
, then the bug explanation (remove the second OOPS line as you already have the explanation.
Please, check some other commits to have an idea of how to do it.
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
Outdated
Show resolved
Hide resolved
Ah, and PR title, first line of the commit log and title of the bugzilla bug have to be the same. |
bf72c05
to
b27450a
Compare
EWS run on previous version of this PR (hash b27450a) |
@calvaris I've updated the PR. hopefully I got it right this time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One you push the list last change, I'll already ask the merge queue to merge it. Thanks.
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
Outdated
Show resolved
Hide resolved
b27450a
to
b4bf638
Compare
EWS run on current version of this PR (hash b4bf638) |
b4bf638
to
1c9b3fa
Compare
https://bugs.webkit.org/show_bug.cgi?id=256482 Reviewed by Xabier Rodriguez-Calvar. This solves several cases: - secondary (video only/pip) playback: audio sink allocates resources in ready state (as part of auto audio sink detection), which interferes with the main playback. - "external" playback, or playback with other sink elements: in this case we want playbin2 to autoplug needed elements. * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::createAudioSink): (WebCore::MediaPlayerPrivateGStreamer::gstreamerPositionFromSinks const): (WebCore::MediaPlayerPrivateGStreamer::handleMessage): (WebCore::MediaPlayerPrivateGStreamer::createHolePunchVideoSink): Canonical link: https://commits.webkit.org/263972@main
1c9b3fa
to
bfa9538
Compare
Committed 263972@main (bfa9538): https://commits.webkit.org/263972@main Reviewed commits have been landed. Closing PR #13612 and removing active labels. |
bfa9538
b4bf638