Build fix: Return AirOpcode* headers to private membership #13625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emw-apple
added
the
JavaScriptCore
|
EWS run on current version of this PR (hash b800427) |
emw-apple
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=254784 rdar://108843961 Unreviewed build fix. In 263845@main, these generated headers stopped being installed by JavaScriptCore: > - Remove target membership from AirOpcodeGenerated.h and > AirOpcodeUtils.h. They are missing some includes when they are > processed by tapi, and they do not contain any API or SPI. It turns out they need to be installed for JSC's tools projects in production builds. Put them back, and instead make them processible by tapi in non-JIT configurations by adding ENABLE(B3_JIT) guards. * Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj: * Source/JavaScriptCore/b3/air/opcode_generator.rb: Canonical link: https://commits.webkit.org/263847@main
webkit-commit-queue
force-pushed
the
eng/jsc-installapi
branch
from
b800427
to
1bc021c
Compare
|
Committed 263847@main (1bc021c): https://commits.webkit.org/263847@main Reviewed commits have been landed. Closing PR #13625 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1bc021c
b800427
🛠 wincairo🧪 wpe-wk2🧪 api-mac🧪 mac-wk1🧪 gtk-wk2🛠 🧪 jsc🧪 mac-wk2🧪 api-gtk🧪 jsc-armv7-tests