Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-webkit prints "error: invalid key:" during prepare-commit-msg #13646

Conversation

emw-apple
Copy link
Contributor

@emw-apple emw-apple commented May 9, 2023

b614d27

git-webkit prints "error: invalid key:" during prepare-commit-msg
https://bugs.webkit.org/show_bug.cgi?id=256534
rdar://109107387

Reviewed by Jonathan Bedard.

git-config(1) exits "1" when a key is missing, which is an expected
case for the hook. AFAICT, there's not a good way to silence the error,
so capture stderr when making the call and only print it out if
git-config fails with a *different* exit code.

* Tools/Scripts/hooks/prepare-commit-msg:

Canonical link: https://commits.webkit.org/263965@main

273da5d

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ›  gtk
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1 βœ… πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 ❌ πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  tv-sim
βœ… πŸ›  watch
βœ… πŸ›  πŸ§ͺ unsafe-merge βœ… πŸ›  watch-sim

@emw-apple emw-apple requested a review from JonWBedard as a code owner May 9, 2023 18:26
@emw-apple emw-apple self-assigned this May 9, 2023
@emw-apple emw-apple added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label May 9, 2023
@JonWBedard JonWBedard added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 11, 2023
https://bugs.webkit.org/show_bug.cgi?id=256534
rdar://109107387

Reviewed by Jonathan Bedard.

git-config(1) exits "1" when a key is missing, which is an expected
case for the hook. AFAICT, there's not a good way to silence the error,
so capture stderr when making the call and only print it out if
git-config fails with a *different* exit code.

* Tools/Scripts/hooks/prepare-commit-msg:

Canonical link: https://commits.webkit.org/263965@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/git-webkit-prints-error-invalid-key-during-prepare-commit-msg branch from 273da5d to b614d27 Compare May 11, 2023 14:49
@webkit-commit-queue
Copy link
Collaborator

Committed 263965@main (b614d27): https://commits.webkit.org/263965@main

Reviewed commits have been landed. Closing PR #13646 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit b614d27 into WebKit:main May 11, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
4 participants