Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[webkit-patch] Only prefix reverts with r when revision used #13696

Merged
merged 1 commit into from
May 10, 2023
Merged

[webkit-patch] Only prefix reverts with r when revision used #13696

merged 1 commit into from
May 10, 2023

Conversation

JonWBedard
Copy link
Member

@JonWBedard JonWBedard commented May 10, 2023 •
edited by webkit-early-warning-system

076489a

[webkit-patch] Only prefix reverts with r when revision used
https://bugs.webkit.org/show_bug.cgi?id=256592
rdar://109157004

Reviewed by Ryan Haddad.

* Tools/Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
(PrepareChangeLogForRevert._message_for_revert): Only prefix r when the revision is an integer.

Canonical link: https://commits.webkit.org/263910@main

e12af10

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 webkitpy ✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2
  🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge   🛠 watch-sim

@JonWBedard JonWBedard self-assigned this May 10, 2023
@JonWBedard JonWBedard added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label May 10, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash e12af10)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 webkitpy ✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2
  🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge   🛠 watch-sim

@JonWBedard JonWBedard added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 10, 2023
@JonWBedard
[webkit-patch] Only prefix reverts with r when revision used
076489a 
https://bugs.webkit.org/show_bug.cgi?id=256592
rdar://109157004

Reviewed by Ryan Haddad.

* Tools/Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
(PrepareChangeLogForRevert._message_for_revert): Only prefix r when the revision is an integer.

Canonical link: https://commits.webkit.org/263910@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/webkit-patch-Only-prefix-reverts-with-r-when-revision-used branch from e12af10 to 076489a Compare May 10, 2023 16:55
@webkit-commit-queue
Copy link
Collaborator

Committed 263910@main (076489a): https://commits.webkit.org/263910@main

Reviewed commits have been landed. Closing PR #13696 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 076489a into WebKit:main May 10, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 10, 2023
@JonWBedard JonWBedard deleted the eng/webkit-patch-Only-prefix-reverts-with-r-when-revision-used branch May 10, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanhaddad ryanhaddad ryanhaddad approved these changes

Assignees

@JonWBedard JonWBedard

Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Milestone
No milestone
4 participants
@JonWBedard @webkit-early-warning-system @webkit-commit-queue @ryanhaddad