Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[web-animations] Remove or update -webkit-animation-trigger feature #13699

Merged
merged 1 commit into from May 10, 2023
Merged

[web-animations] Remove or update -webkit-animation-trigger feature #13699

merged 1 commit into from May 10, 2023

Conversation

graouts
Copy link
Contributor

@graouts graouts commented May 10, 2023 •
edited by webkit-early-warning-system

6c484c4

[web-animations] Remove or update -webkit-animation-trigger feature
https://bugs.webkit.org/show_bug.cgi?id=184563

Reviewed by Devin Rousso.

Remove the last mention of -webkit-animation-trigger which had not survived the move to Web Animations.

* Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js:

Canonical link: https://commits.webkit.org/263913@main

8e5e97c

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2
  🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@graouts graouts self-assigned this May 10, 2023
@graouts graouts added the Animations Bugs related to CSS + SVG animations and transitions label May 10, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 8e5e97c)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2
  🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@graouts graouts requested a review from grorg May 10, 2023 17:21
@graouts graouts added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 10, 2023
@graouts
[web-animations] Remove or update -webkit-animation-trigger feature
6c484c4 
https://bugs.webkit.org/show_bug.cgi?id=184563

Reviewed by Devin Rousso.

Remove the last mention of -webkit-animation-trigger which had not survived the move to Web Animations.

* Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js:

Canonical link: https://commits.webkit.org/263913@main
@webkit-commit-queue
Copy link
Collaborator

Committed 263913@main (6c484c4): https://commits.webkit.org/263913@main

Reviewed commits have been landed. Closing PR #13699 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 6c484c4 into WebKit:main May 10, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 10, 2023
@graouts graouts deleted the animation-trigger-removal branch May 10, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcrousso dcrousso dcrousso approved these changes

@patrickangle patrickangle Awaiting requested review from patrickangle patrickangle is a code owner

@grorg grorg Awaiting requested review from grorg

Assignees

@graouts graouts

Labels
Animations Bugs related to CSS + SVG animations and transitions
Projects
None yet
Milestone
No milestone
4 participants
@graouts @webkit-early-warning-system @webkit-commit-queue @dcrousso