Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression(260812@main): Hoyolab says phone is not in portrait even though it is #13719

Merged
merged 1 commit into from
May 10, 2023
Merged

Regression(260812@main): Hoyolab says phone is not in portrait even though it is #13719

merged 1 commit into from
May 10, 2023

Conversation

cdumez
Copy link
Contributor

@cdumez cdumez commented May 10, 2023 •
edited by webkit-early-warning-system

008fcfb

Regression(260812@main): Hoyolab says phone is not in portrait even though it is
https://bugs.webkit.org/show_bug.cgi?id=256612
rdar://106780607

Reviewed by Geoffrey Garen.

I added a linked-on-after flag for the Screen Orientation API in 260812@main,
requiring apps to get rebuilt with the latest SDK in order to be able to use
the new API.

However, this broke the HoyoLab app, which now complains about the device
orientation even though it is correct. To address the issue, I am re-enabling
the screen orientation API for this app.

* Source/WebCore/platform/RuntimeApplicationChecks.h:
* Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm:
(WebCore::IOSApplication::isHoYoLAB):
* Source/WebKit/Shared/WebPreferencesDefaultValues.cpp:
(WebKit::defaultShouldEnableScreenOrientationAPI):

Canonical link: https://commits.webkit.org/263932@main

7038b0e

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@cdumez cdumez self-assigned this May 10, 2023
@cdumez cdumez added the WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). label May 10, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash e4973d9)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style   🛠 ios   🛠 mac   🛠 wpe ⏳ 🛠 wincairo
  🧪 bindings   🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
  🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🛠 gtk
  🧪 ios-wk2-wpt   🧪 mac-wk1   🧪 gtk-wk2
⏳ 🛠 🧪 jsc   🧪 api-ios   🧪 mac-wk2   🧪 api-gtk
⏳ 🛠 tv ⏳ 🧪 mac-AS-debug-wk2
⏳ 🛠 tv-sim   🧪 mac-wk2-stress
⏳ 🛠 watch
⏳ 🛠 watch-sim

geoffreygaren
geoffreygaren approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@geoffreygaren geoffreygaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 7038b0e)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@cdumez cdumez added the merge-queue Applied to send a pull request to merge-queue label May 10, 2023
@cdumez
Regression(260812@main): Hoyolab says phone is not in portrait even t…
008fcfb 
…hough it is

https://bugs.webkit.org/show_bug.cgi?id=256612
rdar://106780607

Reviewed by Geoffrey Garen.

I added a linked-on-after flag for the Screen Orientation API in 260812@main,
requiring apps to get rebuilt with the latest SDK in order to be able to use
the new API.

However, this broke the HoyoLab app, which now complains about the device
orientation even though it is correct. To address the issue, I am re-enabling
the screen orientation API for this app.

* Source/WebCore/platform/RuntimeApplicationChecks.h:
* Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm:
(WebCore::IOSApplication::isHoYoLAB):
* Source/WebKit/Shared/WebPreferencesDefaultValues.cpp:
(WebKit::defaultShouldEnableScreenOrientationAPI):

Canonical link: https://commits.webkit.org/263932@main
@webkit-commit-queue
Copy link
Collaborator

Committed 263932@main (008fcfb): https://commits.webkit.org/263932@main

Reviewed commits have been landed. Closing PR #13719 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 008fcfb into WebKit:main May 10, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffreygaren geoffreygaren geoffreygaren approved these changes

Assignees

@cdumez cdumez

Labels
WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).
Projects
None yet
Milestone
No milestone
4 participants
@cdumez @webkit-early-warning-system @webkit-commit-queue @geoffreygaren