Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up after 263887@main #13738

Merged

Conversation

achristensen07
Copy link
Contributor

@achristensen07 achristensen07 commented May 11, 2023

f5fbd8d

Clean up after 263887@main
https://bugs.webkit.org/show_bug.cgi?id=256627
rdar://109187838

Reviewed by Wenson Hsieh.

A call to haveStrictDecodableNSTextTable was incorrectly added.
NSPresentationIntent doesn't serialize an NSTextTable like NSParagraphStyle does.
Also, the comment indicating that a test and crash referred to an assertion that
was hit without a change to shouldEnableStrictMode.

To help other developers know what to do when they hit that assertion, I add a
comment indicating how they should proceed instead of expanding the list of ObjC
classes that are serialized.

* Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm:
(IPC::shouldEnableStrictMode):

Canonical link: https://commits.webkit.org/263947@main

1f4502c

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug   πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ›  gtk
βœ… πŸ§ͺ ios-wk2-wpt   πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios   πŸ§ͺ mac-wk2 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  tv-sim
βœ… πŸ›  watch
βœ… πŸ›  πŸ§ͺ unsafe-merge βœ… πŸ›  watch-sim

@achristensen07 achristensen07 self-assigned this May 11, 2023
@achristensen07 achristensen07 added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label May 11, 2023
@achristensen07 achristensen07 added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 11, 2023
https://bugs.webkit.org/show_bug.cgi?id=256627
rdar://109187838

Reviewed by Wenson Hsieh.

A call to haveStrictDecodableNSTextTable was incorrectly added.
NSPresentationIntent doesn't serialize an NSTextTable like NSParagraphStyle does.
Also, the comment indicating that a test and crash referred to an assertion that
was hit without a change to shouldEnableStrictMode.

To help other developers know what to do when they hit that assertion, I add a
comment indicating how they should proceed instead of expanding the list of ObjC
classes that are serialized.

* Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm:
(IPC::shouldEnableStrictMode):

Canonical link: https://commits.webkit.org/263947@main
@webkit-commit-queue
Copy link
Collaborator

Committed 263947@main (f5fbd8d): https://commits.webkit.org/263947@main

Reviewed commits have been landed. Closing PR #13738 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit f5fbd8d into WebKit:main May 11, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
4 participants