Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PageshowEventPersistence and NodeListInvalidationType should be enum classes #13739

Merged
merged 1 commit into from May 11, 2023
Merged

PageshowEventPersistence and NodeListInvalidationType should be enum classes #13739

merged 1 commit into from May 11, 2023

Conversation

rniwa
Copy link
Member

@rniwa rniwa commented May 11, 2023 •
edited by webkit-early-warning-system

5929d88

PageshowEventPersistence and NodeListInvalidationType should be enum classes
https://bugs.webkit.org/show_bug.cgi?id=256628

Reviewed by Antti Koivisto.

* Source/WebCore/dom/Document.cpp:
(WebCore::Document::implicitClose):
(WebCore::Document::registerNodeListForInvalidation):
(WebCore::Document::unregisterNodeListForInvalidation):
(WebCore::Document::registerCollection):
(WebCore::Document::unregisterCollection):
(WebCore::Document::collectionCachedIdNameMap):
(WebCore::Document::collectionWillClearIdNameMap):
(WebCore::Document::dispatchPageshowEvent):
(WebCore::Document::dispatchPagehideEvent):
* Source/WebCore/dom/Document.h:
* Source/WebCore/dom/LiveNodeListInlines.h:
(WebCore::shouldInvalidateTypeOnAttributeChange):
* Source/WebCore/dom/NameNodeList.cpp:
(WebCore::NameNodeList::NameNodeList):
* Source/WebCore/dom/Node.cpp:
(WebCore::Document::shouldInvalidateNodeListAndCollectionCachesForAttribute const):
* Source/WebCore/history/CachedPage.cpp:
(WebCore::firePageShowEvent):
* Source/WebCore/html/HTMLCollection.cpp:
(WebCore::invalidationTypeExcludingIdAndNameAttributes):
(WebCore::HTMLCollection::HTMLCollection):
* Source/WebCore/html/LabelsNodeList.cpp:
(WebCore::LabelsNodeList::LabelsNodeList):
* Source/WebCore/html/RadioNodeList.cpp:
(WebCore::RadioNodeList::RadioNodeList):
* Source/WebCore/loader/FrameLoader.cpp:
(WebCore::FrameLoader::dispatchUnloadEvents):
* Source/WebCore/page/LocalDOMWindow.cpp:
(WebCore::LocalDOMWindow::dispatchAllPendingUnloadEvents):
* Source/WebCore/page/ios/FrameIOS.mm:
(WebCore::LocalFrame::dispatchPageHideEventBeforePause):
(WebCore::LocalFrame::dispatchPageShowEventBeforeResume):

Canonical link: https://commits.webkit.org/263952@main

6cb105a

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@rniwa rniwa requested a review from cdumez as a code owner May 11, 2023 05:07
@rniwa rniwa self-assigned this May 11, 2023
@rniwa rniwa added the DOM For bugs specific to XML/HTML DOM elements (including parsing). label May 11, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash daf65b0)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ❌ 🛠 ios ❌ 🛠 mac ❌ 🛠 wpe ❌ 🛠 wincairo
✅ 🧪 bindings ❌ 🛠 ios-sim ❌ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ❌ 🧪 api-mac ❌ 🛠 gtk
❌ 🧪 ios-wk2-wpt ❌ 🧪 mac-wk1 ❌ 🧪 gtk-wk2
❌ 🧪 api-ios ❌ 🧪 mac-wk2 ❌ 🧪 api-gtk
❌ 🛠 tv ❌ 🧪 mac-AS-debug-wk2
❌ 🛠 tv-sim ❌ 🧪 mac-wk2-stress
❌ 🛠 watch
❌ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 11, 2023
@rniwa rniwa removed the merging-blocked Applied to prevent a change from being merged label May 11, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 6cb105a)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@rniwa rniwa added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 11, 2023
@rniwa
PageshowEventPersistence and NodeListInvalidationType should be enum …
5929d88 
…classes

https://bugs.webkit.org/show_bug.cgi?id=256628

Reviewed by Antti Koivisto.

* Source/WebCore/dom/Document.cpp:
(WebCore::Document::implicitClose):
(WebCore::Document::registerNodeListForInvalidation):
(WebCore::Document::unregisterNodeListForInvalidation):
(WebCore::Document::registerCollection):
(WebCore::Document::unregisterCollection):
(WebCore::Document::collectionCachedIdNameMap):
(WebCore::Document::collectionWillClearIdNameMap):
(WebCore::Document::dispatchPageshowEvent):
(WebCore::Document::dispatchPagehideEvent):
* Source/WebCore/dom/Document.h:
* Source/WebCore/dom/LiveNodeListInlines.h:
(WebCore::shouldInvalidateTypeOnAttributeChange):
* Source/WebCore/dom/NameNodeList.cpp:
(WebCore::NameNodeList::NameNodeList):
* Source/WebCore/dom/Node.cpp:
(WebCore::Document::shouldInvalidateNodeListAndCollectionCachesForAttribute const):
* Source/WebCore/history/CachedPage.cpp:
(WebCore::firePageShowEvent):
* Source/WebCore/html/HTMLCollection.cpp:
(WebCore::invalidationTypeExcludingIdAndNameAttributes):
(WebCore::HTMLCollection::HTMLCollection):
* Source/WebCore/html/LabelsNodeList.cpp:
(WebCore::LabelsNodeList::LabelsNodeList):
* Source/WebCore/html/RadioNodeList.cpp:
(WebCore::RadioNodeList::RadioNodeList):
* Source/WebCore/loader/FrameLoader.cpp:
(WebCore::FrameLoader::dispatchUnloadEvents):
* Source/WebCore/page/LocalDOMWindow.cpp:
(WebCore::LocalDOMWindow::dispatchAllPendingUnloadEvents):
* Source/WebCore/page/ios/FrameIOS.mm:
(WebCore::LocalFrame::dispatchPageHideEventBeforePause):
(WebCore::LocalFrame::dispatchPageShowEventBeforeResume):

Canonical link: https://commits.webkit.org/263952@main
@webkit-commit-queue
Copy link
Collaborator

Committed 263952@main (5929d88): https://commits.webkit.org/263952@main

Reviewed commits have been landed. Closing PR #13739 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 5929d88 into WebKit:main May 11, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 11, 2023
@rniwa rniwa deleted the fix256628 branch May 11, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anttijk anttijk anttijk approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

Assignees

@rniwa rniwa

Labels
DOM For bugs specific to XML/HTML DOM elements (including parsing).
Projects
None yet
Milestone
No milestone
5 participants
@rniwa @webkit-early-warning-system @webkit-commit-queue @anttijk @webkit-ews-buildbot