Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WGSL] Add support for struct constructors #13807

Merged
merged 1 commit into from
May 15, 2023
Merged

[WGSL] Add support for struct constructors #13807

merged 1 commit into from
May 15, 2023

Conversation

tadeuzagallo
Copy link
Member

@tadeuzagallo tadeuzagallo commented May 12, 2023 •
edited by webkit-early-warning-system

65a2d2e

[WGSL] Add support for struct constructors
https://bugs.webkit.org/show_bug.cgi?id=256704
rdar://109265280

Reviewed by Myles C. Maxfield and Dan Glastonbury.

Add type checking and code generation for struct constructors.

* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::FunctionDefinitionWriter::visit):
* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::visit):
* Source/WebGPU/WGSL/tests/invalid/struct.wgsl: Added.
* Source/WebGPU/WGSL/tests/valid/struct.wgsl: Added.

Canonical link: https://commits.webkit.org/264066@main

02108de

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@tadeuzagallo tadeuzagallo self-assigned this May 12, 2023
@tadeuzagallo tadeuzagallo added the WebGPU For bugs in WebGPU label May 12, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 02108de)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

litherum
litherum approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@litherum litherum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right.

djg
djg approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@djg djg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Source/WebGPU/WGSL/tests/invalid/struct.wgsl
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tadeuzagallo tadeuzagallo added the merge-queue Applied to send a pull request to merge-queue label May 15, 2023
@tadeuzagallo
[WGSL] Add support for struct constructors
65a2d2e 
https://bugs.webkit.org/show_bug.cgi?id=256704
rdar://109265280

Reviewed by Myles C. Maxfield and Dan Glastonbury.

Add type checking and code generation for struct constructors.

* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::FunctionDefinitionWriter::visit):
* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::visit):
* Source/WebGPU/WGSL/tests/invalid/struct.wgsl: Added.
* Source/WebGPU/WGSL/tests/valid/struct.wgsl: Added.

Canonical link: https://commits.webkit.org/264066@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WGSL-Add-support-for-struct-constructors branch from 02108de to 65a2d2e Compare May 15, 2023 08:53
@webkit-commit-queue
Copy link
Collaborator

Committed 264066@main (65a2d2e): https://commits.webkit.org/264066@main

Reviewed commits have been landed. Closing PR #13807 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 65a2d2e into WebKit:main May 15, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djg djg djg approved these changes

@litherum litherum litherum approved these changes

@mwyrzykowski mwyrzykowski Awaiting requested review from mwyrzykowski mwyrzykowski is a code owner

Assignees

@tadeuzagallo tadeuzagallo

Labels
WebGPU For bugs in WebGPU
Projects
None yet
Milestone
No milestone
5 participants
@tadeuzagallo @webkit-early-warning-system @webkit-commit-queue @djg @litherum