Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GStreamer][WebRTC] Notify end of ICE gathering when end-of-candidates is signaled in SDP #13810

Merged
merged 1 commit into from May 15, 2023

Conversation

philn
Copy link
Member

@philn philn commented May 12, 2023

f24a5bb

[GStreamer][WebRTC] Notify end of ICE gathering when end-of-candidates is signaled in SDP
https://bugs.webkit.org/show_bug.cgi?id=256709

Reviewed by Xabier Rodriguez-Calvar.

Notify the backend in case all m-lines of the current local description have signaled all their ICE
candidates using the end-of-candidates SDP attribute.

* Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp:
(WebCore::GStreamerMediaEndpoint::doSetLocalDescription):
(WebCore::GStreamerMediaEndpoint::doSetRemoteDescription):
(WebCore::GStreamerMediaEndpoint::isIceGatheringComplete):
(WebCore::GStreamerMediaEndpoint::onIceCandidate):
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.h:
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerWebRTCUtils.cpp:
(WebCore::capsFromSDPMedia):

Canonical link: https://commits.webkit.org/264062@main

4f965fe

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ›  gtk
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1 βœ… πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  tv-sim
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch
βœ… πŸ›  watch-sim

@philn philn self-assigned this May 12, 2023
@philn philn added the Platform Portability improvements and other general platform improvements not driven directly by site bugs. label May 12, 2023
@philn philn requested a review from calvaris May 12, 2023 16:54
@philn philn added the merge-queue Applied to send a pull request to merge-queue label May 15, 2023
…s is signaled in SDP

https://bugs.webkit.org/show_bug.cgi?id=256709

Reviewed by Xabier Rodriguez-Calvar.

Notify the backend in case all m-lines of the current local description have signaled all their ICE
candidates using the end-of-candidates SDP attribute.

* Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp:
(WebCore::GStreamerMediaEndpoint::doSetLocalDescription):
(WebCore::GStreamerMediaEndpoint::doSetRemoteDescription):
(WebCore::GStreamerMediaEndpoint::isIceGatheringComplete):
(WebCore::GStreamerMediaEndpoint::onIceCandidate):
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.h:
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerWebRTCUtils.cpp:
(WebCore::capsFromSDPMedia):

Canonical link: https://commits.webkit.org/264062@main
@webkit-commit-queue
Copy link
Collaborator

Committed 264062@main (f24a5bb): https://commits.webkit.org/264062@main

Reviewed commits have been landed. Closing PR #13810 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit f24a5bb into WebKit:main May 15, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label May 15, 2023
@philn philn deleted the eng/256709 branch May 15, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform Portability improvements and other general platform improvements not driven directly by site bugs.
Projects
None yet
4 participants