Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Media Stats should show color information even for WebM files without the Color element #13812

Merged
merged 1 commit into from
May 15, 2023
Merged

Media Stats should show color information even for WebM files without the Color element #13812

merged 1 commit into from
May 15, 2023

Conversation

jernoble
Copy link
Contributor

@jernoble jernoble commented May 12, 2023 •
edited by webkit-early-warning-system

034442d

Media Stats should show color information even for WebM files without the Color element
https://bugs.webkit.org/show_bug.cgi?id=256715
rdar://109268570

Reviewed by Eric Carlson.

Read color information out of the VP9 header when creating a VideoInfo object.

* LayoutTests/media/media-source/content/test-vp9-profile0-stripped-manifest.json: Added.
* LayoutTests/media/media-source/content/test-vp9-profile0-stripped.webm: Added.
* LayoutTests/media/media-source/content/test-vp9-profile2-stripped-manifest.json: Added.
* LayoutTests/media/media-source/content/test-vp9-profile2-stripped.webm: Added.
* LayoutTests/media/media-source/media-source-webm-configuration-vp9-header-color-expected.txt: Added.
* LayoutTests/media/media-source/media-source-webm-configuration-vp9-header-color.html: Added.
* Source/WebCore/platform/graphics/cocoa/VP9UtilitiesCocoa.mm:
(WebCore::createVideoInfoFromVP9HeaderParser):

Canonical link: https://commits.webkit.org/264084@main

b887093

Misc iOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@jernoble jernoble self-assigned this May 12, 2023
@jernoble jernoble added the Media Bugs related to the HTML 5 Media elements. label May 12, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash af6d3ee)

Misc iOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ❌ 🧪 mac-wk1 ❌ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 watch
✅ 🛠 watch-sim

eric-carlson
eric-carlson approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@eric-carlson eric-carlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 12, 2023
@jernoble jernoble removed the merging-blocked Applied to prevent a change from being merged label May 12, 2023
@jernoble jernoble force-pushed the eng/Media-Stats-should-show-color-information-even-for-WebM-files-without-the-Color-element branch from af6d3ee to 399b179 Compare May 12, 2023 23:14
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 399b179)

Misc iOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 13, 2023
@jernoble jernoble removed the merging-blocked Applied to prevent a change from being merged label May 13, 2023
@jernoble jernoble force-pushed the eng/Media-Stats-should-show-color-information-even-for-WebM-files-without-the-Color-element branch from 399b179 to b887093 Compare May 13, 2023 16:40
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash b887093)

Misc iOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@jernoble jernoble added the merge-queue Applied to send a pull request to merge-queue label May 15, 2023
@jernoble
Media Stats should show color information even for WebM files without…
034442d 
… the Color element

https://bugs.webkit.org/show_bug.cgi?id=256715
rdar://109268570

Reviewed by Eric Carlson.

Read color information out of the VP9 header when creating a VideoInfo object.

* LayoutTests/media/media-source/content/test-vp9-profile0-stripped-manifest.json: Added.
* LayoutTests/media/media-source/content/test-vp9-profile0-stripped.webm: Added.
* LayoutTests/media/media-source/content/test-vp9-profile2-stripped-manifest.json: Added.
* LayoutTests/media/media-source/content/test-vp9-profile2-stripped.webm: Added.
* LayoutTests/media/media-source/media-source-webm-configuration-vp9-header-color-expected.txt: Added.
* LayoutTests/media/media-source/media-source-webm-configuration-vp9-header-color.html: Added.
* Source/WebCore/platform/graphics/cocoa/VP9UtilitiesCocoa.mm:
(WebCore::createVideoInfoFromVP9HeaderParser):

Canonical link: https://commits.webkit.org/264084@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Media-Stats-should-show-color-information-even-for-WebM-files-without-the-Color-element branch from b887093 to 034442d Compare May 15, 2023 22:15
@webkit-commit-queue
Copy link
Collaborator

Committed 264084@main (034442d): https://commits.webkit.org/264084@main

Reviewed commits have been landed. Closing PR #13812 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 034442d into WebKit:main May 15, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label May 15, 2023
@jernoble jernoble deleted the eng/Media-Stats-should-show-color-information-even-for-WebM-files-without-the-Color-element branch October 26, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-carlson eric-carlson eric-carlson approved these changes

Assignees

@jernoble jernoble

Labels
Media Bugs related to the HTML 5 Media elements.
Projects
None yet
Milestone
No milestone
5 participants
@jernoble @webkit-early-warning-system @webkit-commit-queue @eric-carlson @webkit-ews-buildbot