Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebGPU] Delete Tools/WebGPUAPIStructure #13827

Conversation

litherum
Copy link
Contributor

@litherum litherum commented May 12, 2023

90d9f01

[WebGPU] Delete Tools/WebGPUAPIStructure
https://bugs.webkit.org/show_bug.cgi?id=256732
rdar://109283183

Reviewed by Mike Wyrzykowski.

It was a proof-of-concept of how the WebGPU API could be designed. It is no longer necessary.

* Tools/WebGPUAPIStructure/Example/Example.cpp: Removed.
* Tools/WebGPUAPIStructure/Example/Example.h: Removed.
* Tools/WebGPUAPIStructure/Example/Example.ico: Removed.
* Tools/WebGPUAPIStructure/Example/Example.rc: Removed.
* Tools/WebGPUAPIStructure/Example/Example.vcxproj: Removed.
* Tools/WebGPUAPIStructure/Example/Example.vcxproj.filters: Removed.
* Tools/WebGPUAPIStructure/Example/Example.vcxproj.user: Removed.
* Tools/WebGPUAPIStructure/Example/resource.h: Removed.
* Tools/WebGPUAPIStructure/Example/small.ico: Removed.
* Tools/WebGPUAPIStructure/Example/stdafx.cpp: Removed.
* Tools/WebGPUAPIStructure/Example/stdafx.h: Removed.
* Tools/WebGPUAPIStructure/Example/targetver.h: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Common/WebGPU-Common.vcxproj: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Common/WebGPU-Common.vcxproj.filters: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Common/WebGPU.cpp: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Common/WebGPU.h: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Vulkan/BlitPassImpl.cpp: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Vulkan/BlitPassImpl.h: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Vulkan/BufferImpl.cpp: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Vulkan/BufferImpl.h: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Vulkan/ComputePassImpl.cpp: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Vulkan/ComputePassImpl.h: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Vulkan/ComputeStateImpl.cpp: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Vulkan/ComputeStateImpl.h: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Vulkan/DeviceImpl.cpp: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Vulkan/DeviceImpl.h: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Vulkan/HostAccessPassImpl.cpp: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Vulkan/HostAccessPassImpl.h: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Vulkan/PassImpl.cpp: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Vulkan/PassImpl.h: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Vulkan/QueueImpl.cpp: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Vulkan/QueueImpl.h: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Vulkan/RenderPassImpl.cpp: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Vulkan/RenderPassImpl.h: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Vulkan/RenderStateImpl.cpp: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Vulkan/RenderStateImpl.h: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Vulkan/SamplerImpl.cpp: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Vulkan/SamplerImpl.h: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Vulkan/TextureImpl.cpp: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Vulkan/TextureImpl.h: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Vulkan/WebGPU-Vulkan.vcxproj: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Vulkan/WebGPU-Vulkan.vcxproj.filters: Removed.
* Tools/WebGPUAPIStructure/WebGPU.sln: Removed.

Canonical link: https://commits.webkit.org/264035@main

48d3e77

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug   πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ›  gtk
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1   πŸ§ͺ gtk-wk2
  πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  tv-sim
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch
βœ… πŸ›  watch-sim

@litherum litherum requested a review from JonWBedard as a code owner May 12, 2023 22:30
@litherum litherum self-assigned this May 12, 2023
@litherum litherum added the WebGPU For bugs in WebGPU label May 12, 2023
@litherum litherum added the merge-queue Applied to send a pull request to merge-queue label May 12, 2023
https://bugs.webkit.org/show_bug.cgi?id=256732
rdar://109283183

Reviewed by Mike Wyrzykowski.

It was a proof-of-concept of how the WebGPU API could be designed. It is no longer necessary.

* Tools/WebGPUAPIStructure/Example/Example.cpp: Removed.
* Tools/WebGPUAPIStructure/Example/Example.h: Removed.
* Tools/WebGPUAPIStructure/Example/Example.ico: Removed.
* Tools/WebGPUAPIStructure/Example/Example.rc: Removed.
* Tools/WebGPUAPIStructure/Example/Example.vcxproj: Removed.
* Tools/WebGPUAPIStructure/Example/Example.vcxproj.filters: Removed.
* Tools/WebGPUAPIStructure/Example/Example.vcxproj.user: Removed.
* Tools/WebGPUAPIStructure/Example/resource.h: Removed.
* Tools/WebGPUAPIStructure/Example/small.ico: Removed.
* Tools/WebGPUAPIStructure/Example/stdafx.cpp: Removed.
* Tools/WebGPUAPIStructure/Example/stdafx.h: Removed.
* Tools/WebGPUAPIStructure/Example/targetver.h: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Common/WebGPU-Common.vcxproj: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Common/WebGPU-Common.vcxproj.filters: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Common/WebGPU.cpp: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Common/WebGPU.h: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Vulkan/BlitPassImpl.cpp: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Vulkan/BlitPassImpl.h: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Vulkan/BufferImpl.cpp: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Vulkan/BufferImpl.h: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Vulkan/ComputePassImpl.cpp: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Vulkan/ComputePassImpl.h: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Vulkan/ComputeStateImpl.cpp: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Vulkan/ComputeStateImpl.h: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Vulkan/DeviceImpl.cpp: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Vulkan/DeviceImpl.h: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Vulkan/HostAccessPassImpl.cpp: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Vulkan/HostAccessPassImpl.h: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Vulkan/PassImpl.cpp: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Vulkan/PassImpl.h: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Vulkan/QueueImpl.cpp: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Vulkan/QueueImpl.h: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Vulkan/RenderPassImpl.cpp: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Vulkan/RenderPassImpl.h: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Vulkan/RenderStateImpl.cpp: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Vulkan/RenderStateImpl.h: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Vulkan/SamplerImpl.cpp: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Vulkan/SamplerImpl.h: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Vulkan/TextureImpl.cpp: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Vulkan/TextureImpl.h: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Vulkan/WebGPU-Vulkan.vcxproj: Removed.
* Tools/WebGPUAPIStructure/WebGPU-Vulkan/WebGPU-Vulkan.vcxproj.filters: Removed.
* Tools/WebGPUAPIStructure/WebGPU.sln: Removed.

Canonical link: https://commits.webkit.org/264035@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WebGPU-Delete-ToolsWebGPUAPIStructure branch from 48d3e77 to 90d9f01 Compare May 12, 2023 23:36
@webkit-commit-queue
Copy link
Collaborator

Committed 264035@main (90d9f01): https://commits.webkit.org/264035@main

Reviewed commits have been landed. Closing PR #13827 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 90d9f01 into WebKit:main May 12, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label May 12, 2023
@litherum litherum deleted the eng/WebGPU-Delete-ToolsWebGPUAPIStructure branch May 13, 2023 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebGPU For bugs in WebGPU
Projects
None yet
4 participants