Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebGPU] Add WebGPU directories to CODEOWNERS #13830

Merged
merged 1 commit into from
May 13, 2023
Merged

[WebGPU] Add WebGPU directories to CODEOWNERS #13830

merged 1 commit into from
May 13, 2023

Conversation

litherum
Copy link
Contributor

@litherum litherum commented May 12, 2023 •
edited by webkit-early-warning-system

@litherum litherum self-assigned this May 12, 2023
@litherum litherum added the WebGPU For bugs in WebGPU label May 12, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 4d3e616)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ❌ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@mwyrzykowski
Copy link
Contributor

Yes you can add me too please

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 13, 2023
@litherum litherum requested review from tadeuzagallo and djg May 13, 2023 02:45
@litherum litherum removed the merging-blocked Applied to prevent a change from being merged label May 13, 2023
@litherum litherum force-pushed the eng/WebGPU-Add-WebGPU-directories-to-CODEOWNERS branch from 4d3e616 to 7812830 Compare May 13, 2023 02:46
@litherum litherum marked this pull request as ready for review May 13, 2023 02:46
@litherum litherum requested a review from JonWBedard as a code owner May 13, 2023 02:46
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 7812830)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ❌ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 13, 2023
@litherum litherum added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels May 13, 2023
@litherum
[WebGPU] Add WebGPU directories to CODEOWNERS
00512b6 
https://bugs.webkit.org/show_bug.cgi?id=256737
rdar://109284751

Reviewed by Mike Wyrzykowski.

A few of us would like to be notified about WebGPU or WGSL PRs.

* .github/CODEOWNERS:

Canonical link: https://commits.webkit.org/264047@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WebGPU-Add-WebGPU-directories-to-CODEOWNERS branch from 7812830 to 00512b6 Compare May 13, 2023 09:51
@webkit-commit-queue
Copy link
Collaborator

Committed 264047@main (00512b6): https://commits.webkit.org/264047@main

Reviewed commits have been landed. Closing PR #13830 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 00512b6 into WebKit:main May 13, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadeuzagallo tadeuzagallo Awaiting requested review from tadeuzagallo

@djg djg Awaiting requested review from djg

@mwyrzykowski mwyrzykowski Awaiting requested review from mwyrzykowski

@JonWBedard JonWBedard Awaiting requested review from JonWBedard JonWBedard is a code owner

Assignees

@litherum litherum

Labels
WebGPU For bugs in WebGPU
Projects
None yet
Milestone
No milestone
6 participants
@litherum @webkit-early-warning-system @mwyrzykowski @webkit-commit-queue @Nirvana332536 @webkit-ews-buildbot