REGRESSION(r258464): SVG use element doesn't render if it references a subsequent element after a style resolution #13857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on previous version of this PR (hash 5c9b14f)
|
|
EWS run on previous version of this PR (hash 89a4eb9)
|
shallawa
approved these changes
May 15, 2023
Comment on lines
252
to
254
| if (insertionType.connectedToDocument || result == InsertedIntoAncestorResult::NeedsPostInsertionCallback) | ||
| return InsertedIntoAncestorResult::NeedsPostInsertionCallback; | ||
| return InsertedIntoAncestorResult::Done; |
There was a problem hiding this comment.
Or this can be something like this:
if (insertionType.connectedToDocument)
return InsertedIntoAncestorResult::NeedsPostInsertionCallback;
return result;
Comment on lines
1
to
3
| <?xml version="1.0" encoding="UTF-8" standalone="no"?> | ||
| <!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" | ||
| "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd"> |
There was a problem hiding this comment.
I think these lines can be removed.
| <?xml version="1.0" encoding="UTF-8" standalone="no"?> | ||
| <!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" | ||
| "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd"> | ||
| <svg viewBox="0 0 100 100" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"> |
There was a problem hiding this comment.
The name space xmlns:xlink is not needed anymore. So it can be removed. And the version attribute has been deprecated.
| <!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" | ||
| "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd"> | ||
| <svg viewBox="0 0 100 100" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"> | ||
| <use xlink:href="#x1" x="0" y="0" /> |
|
EWS run on current version of this PR (hash 424289b)
|
rniwa
added
the
unsafe-merge-queue
…a subsequent element after a style resolution https://bugs.webkit.org/show_bug.cgi?id=216363 Reviewed by Said Abou-Hallawa. The bug was caused by SVGPathElement::insertedIntoAncestor and a few other insertedIntoAncestor functions ignoring the value returned by SVGElement::insertedIntoAncestor requesting a post insertion callback, and SVGMPathElement::didFinishInsertingNode not calling SVGMPathElement::didFinishInsertingNode, which updates SVG elements referencing the element. This PR fixes all insertedIntoAncestor functions in SVG to respect the value returned by super class' insertedIntoAncestor but many of them don't have any consequences at the moment. * LayoutTests/svg/dom/use-element-refers-subsequent-image-element-after-style-update-expected.svg: Added. * LayoutTests/svg/dom/use-element-refers-subsequent-image-element-after-style-update.svg: Added. * LayoutTests/svg/dom/use-element-refers-subsequent-path-element-after-style-update-expected.svg: Added. * LayoutTests/svg/dom/use-element-refers-subsequent-path-element-after-style-update.svg: Added. * Source/WebCore/svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::didFinishInsertingNode): * Source/WebCore/svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::insertedIntoAncestor): * Source/WebCore/svg/SVGImageElement.cpp: (WebCore::SVGImageElement::insertedIntoAncestor): * Source/WebCore/svg/SVGMPathElement.cpp: (WebCore::SVGMPathElement::insertedIntoAncestor): (WebCore::SVGMPathElement::didFinishInsertingNode): * Source/WebCore/svg/SVGPathElement.cpp: (WebCore::SVGPathElement::insertedIntoAncestor): * Source/WebCore/svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::insertedIntoAncestor): * Source/WebCore/svg/SVGTRefElement.cpp: (WebCore::SVGTRefElement::insertedIntoAncestor): (WebCore::SVGTRefElement::didFinishInsertingNode): * Source/WebCore/svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::didFinishInsertingNode): * Source/WebCore/svg/SVGTitleElement.cpp: (WebCore::SVGTitleElement::insertedIntoAncestor): * Source/WebCore/svg/SVGUseElement.cpp: (WebCore::SVGUseElement::insertedIntoAncestor): (WebCore::SVGUseElement::didFinishInsertingNode): * Source/WebCore/svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::didFinishInsertingNode): Canonical link: https://commits.webkit.org/264085@main
webkit-commit-queue
force-pushed
the
fix216363
branch
from
424289b
to
a6a7aa5
Compare
|
Committed 264085@main (a6a7aa5): https://commits.webkit.org/264085@main Reviewed commits have been landed. Closing PR #13857 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a6a7aa5
424289b
🛠 ios-sim🧪 gtk-wk2🧪 api-ios