Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WGSL] Fix type declaration for vector type conversion #13877

Conversation

tadeuzagallo
Copy link
Member

@tadeuzagallo tadeuzagallo commented May 15, 2023

ccb4ec3

[WGSL] Fix type declaration for vector type conversion
https://bugs.webkit.org/show_bug.cgi?id=256783
rdar://109351633

Reviewed by Myles C. Maxfield and Dan Glastonbury.

The type variable that is only used in the return type, and therefore can't be
inferred, has to be the first type argument so it can explicitly provided when
calling the function while still inferring the second type variable.

* Source/WebGPU/WGSL/TypeDeclarations.rb:
* Source/WebGPU/WGSL/tests/valid/overload.wgsl:

Canonical link: https://commits.webkit.org/264092@main

a8523cf

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ›  gtk
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  tv-sim
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch
βœ… πŸ›  watch-sim

@tadeuzagallo tadeuzagallo self-assigned this May 15, 2023
@tadeuzagallo tadeuzagallo added the WebGPU For bugs in WebGPU label May 15, 2023
@mwyrzykowski mwyrzykowski self-requested a review May 15, 2023 17:26
@djg djg added the merge-queue Applied to send a pull request to merge-queue label May 15, 2023
https://bugs.webkit.org/show_bug.cgi?id=256783
rdar://109351633

Reviewed by Myles C. Maxfield and Dan Glastonbury.

The type variable that is only used in the return type, and therefore can't be
inferred, has to be the first type argument so it can explicitly provided when
calling the function while still inferring the second type variable.

* Source/WebGPU/WGSL/TypeDeclarations.rb:
* Source/WebGPU/WGSL/tests/valid/overload.wgsl:

Canonical link: https://commits.webkit.org/264092@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WGSL-Fix-type-declaration-for-vector-type-conversion branch from a8523cf to ccb4ec3 Compare May 16, 2023 00:21
@webkit-commit-queue
Copy link
Collaborator

Committed 264092@main (ccb4ec3): https://commits.webkit.org/264092@main

Reviewed commits have been landed. Closing PR #13877 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit ccb4ec3 into WebKit:main May 16, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label May 16, 2023
@tadeuzagallo tadeuzagallo deleted the eng/WGSL-Fix-type-declaration-for-vector-type-conversion branch May 17, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebGPU For bugs in WebGPU
Projects
None yet
5 participants