Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the <search> element #13887

Merged

Commits on May 16, 2023

  1. Implement the <search> element

    https://bugs.webkit.org/show_bug.cgi?id=254327
    rdar://107175819
    
    Reviewed by Tim Nguyen.
    
    Adds the new HTML search element as specified in
    whatwg/html#7320. Given the code changes are
    minimal there is no preferences guard.
    
    It doesn't address the unicode-bidi rendering requirements as they are
    not addressed for many elements in WebKit:
    https://bugs.webkit.org/show_bug.cgi?id=256829
    
    This change also syncs most of WPT html/syntax/parsing and adds
    accessibility test coverage for the main element.
    
    * LayoutTests/accessibility/roles-exposed.html:
    * LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/search-styles-expected.txt: Added.
    * LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/search-styles-iso-8859-8-expected.txt: Added.
    * LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/search-styles-iso-8859-8.html: Added.
    * LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/search-styles.html: Added.
    * LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/w3c-import.log:
    * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/Element.getElementsByTagName-foreign-02.html:
    * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/README:
    * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html-integration-point.html:
    * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_innerHTML_template-expected.txt: Added.
    * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_innerHTML_template.html: Added.
    * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_innerHTML_webkit02-expected.txt:
    * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_innerHTML_webkit02.html:
    * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_search-element.html: Added.
    * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_search-element_run_type=uri-expected.txt: Added.
    * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_search-element_run_type=write-expected.txt: Added.
    * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_search-element_run_type=write_single-expected.txt: Added.
    * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tables01.html:
    * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tables01_run_type=uri-expected.txt:
    * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tables01_run_type=write-expected.txt:
    * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tables01_run_type=write_single-expected.txt:
    * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_template.html:
    * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_template_run_type=uri-expected.txt:
    * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_template_run_type=write-expected.txt:
    * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_template_run_type=write_single-expected.txt:
    * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tests20.html:
    * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tests20_run_type=uri-expected.txt:
    * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tests20_run_type=write-expected.txt:
    * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tests20_run_type=write_single-expected.txt:
    * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_webkit01.html:
    * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_webkit01_run_type=uri-expected.txt:
    * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_webkit01_run_type=write-expected.txt:
    * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_webkit01_run_type=write_single-expected.txt:
    * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_webkit02.html:
    * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_webkit02_run_type=uri-expected.txt:
    * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_webkit02_run_type=write-expected.txt:
    * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_webkit02_run_type=write_single-expected.txt:
    * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/math-parse03.html:
    * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/test.js:
    (test_fragment):
    (convert_innerHTML):
    * LayoutTests/imported/w3c/web-platform-tests/html/syntax/parsing/w3c-import.log:
    * LayoutTests/inspector/css/shadow-scoped-style-expected.txt:
    * LayoutTests/platform/mac-wk1/accessibility/roles-exposed-expected.txt:
    * LayoutTests/platform/mac-wk2/accessibility/roles-exposed-expected.txt:
    * LayoutTests/tests-options.json:
    * Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
    (WebCore::AccessibilityNodeObject::determineAccessibilityRoleFromNode const):
    * Source/WebCore/css/html.css:
    (address, article, aside, div, footer, header, hgroup, main, nav, search, section):
    (address, article, aside, div, footer, header, hgroup, main, nav, section): Deleted.
    * Source/WebCore/html/HTMLTagNames.in:
    * Source/WebCore/html/parser/HTMLTreeBuilder.cpp:
    (WebCore::HTMLTreeBuilder::processStartTagForInBody):
    (WebCore::HTMLTreeBuilder::processEndTagForInBody):
    
    Canonical link: https://commits.webkit.org/264110@main
    annevk committed May 16, 2023
    Configuration menu
    Copy the full SHA
    de16e2b View commit details
    Browse the repository at this point in the history