Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import css-scrollbars WPT tests #13889

Merged
merged 1 commit into from May 17, 2023

Conversation

lukewarlow
Copy link
Member

@lukewarlow lukewarlow commented May 15, 2023

9a31af7

Import css-scrollbars WPT tests
https://bugs.webkit.org/show_bug.cgi?id=256792

Reviewed by Tim Nguyen.

WPT at cb1e54222a206b4cbb5211f7e24878a267b820f1

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/resources/import-expectations.json:
* LayoutTests/imported/w3c/resources/resource-files.json:
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/META.yml: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/auto-scrollbar-inline-children-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/auto-scrollbar-inline-children.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/inheritance-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/inheritance.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/multicol-in-orthogonal-writing-mode-crash.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-001-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-001.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-002-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-002.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-003-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-003.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-004-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-004.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-005-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-005.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-006-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-006.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-007-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-007.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-008-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-008.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-keywords-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-keywords.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-paint-001-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-paint-001-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-paint-001.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-paint-002-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-paint-002-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-paint-002.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-paint-003-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-paint-003-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-paint-003.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-parsing-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-parsing.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbars-chrome-bug-001-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbars-chrome-bug-001-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbars-chrome-bug-001.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/support/viewport-scrollbar-body-frame.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/support/viewport-scrollbar-frame.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/support/w3c-import.log: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/textarea-scrollbar-width-none-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/textarea-scrollbar-width-none-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/textarea-scrollbar-width-none.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/transparent-on-root-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/transparent-on-root-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/transparent-on-root.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/viewport-scrollbar-body-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/viewport-scrollbar-body-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/viewport-scrollbar-body.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/viewport-scrollbar-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/viewport-scrollbar-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/viewport-scrollbar.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/w3c-import.log: Added.
* LayoutTests/platform/ios-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/264178@main

186626e

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ›  gtk
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1 βœ… πŸ§ͺ gtk-wk2
  πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  tv-sim βœ… πŸ§ͺ mac-wk2-stress
βœ… πŸ›  watch
βœ… πŸ›  πŸ§ͺ unsafe-merge βœ… πŸ›  watch-sim

Copy link
Member

@nt1m nt1m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you add the commit hash of the upstream commit you imported from in the commit message?

@lukewarlow lukewarlow requested a review from nt1m May 15, 2023 19:45
@Ahmad-S792 Ahmad-S792 added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label May 17, 2023
@lukewarlow lukewarlow requested a review from nt1m May 17, 2023 21:35
@nt1m nt1m added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 17, 2023
https://bugs.webkit.org/show_bug.cgi?id=256792

Reviewed by Tim Nguyen.

WPT at cb1e542

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/resources/import-expectations.json:
* LayoutTests/imported/w3c/resources/resource-files.json:
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/META.yml: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/auto-scrollbar-inline-children-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/auto-scrollbar-inline-children.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/inheritance-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/inheritance.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/multicol-in-orthogonal-writing-mode-crash.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-001-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-001.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-002-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-002.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-003-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-003.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-004-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-004.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-005-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-005.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-006-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-006.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-007-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-007.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-008-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-008.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-keywords-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-keywords.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-paint-001-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-paint-001-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-paint-001.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-paint-002-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-paint-002-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-paint-002.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-paint-003-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-paint-003-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-paint-003.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-parsing-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-parsing.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbars-chrome-bug-001-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbars-chrome-bug-001-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbars-chrome-bug-001.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/support/viewport-scrollbar-body-frame.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/support/viewport-scrollbar-frame.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/support/w3c-import.log: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/textarea-scrollbar-width-none-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/textarea-scrollbar-width-none-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/textarea-scrollbar-width-none.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/transparent-on-root-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/transparent-on-root-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/transparent-on-root.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/viewport-scrollbar-body-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/viewport-scrollbar-body-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/viewport-scrollbar-body.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/viewport-scrollbar-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/viewport-scrollbar-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/viewport-scrollbar.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/w3c-import.log: Added.
* LayoutTests/platform/ios-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/264178@main
@webkit-commit-queue
Copy link
Collaborator

Committed 264178@main (9a31af7): https://commits.webkit.org/264178@main

Reviewed commits have been landed. Closing PR #13889 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 9a31af7 into WebKit:main May 17, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
5 participants