Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose WKBackForwardListItem._wasCreatedByJSWithoutUserInteraction as SPI #13890

Merged
merged 1 commit into from
May 15, 2023
Merged

Expose WKBackForwardListItem._wasCreatedByJSWithoutUserInteraction as SPI #13890

merged 1 commit into from
May 15, 2023

Conversation

cdumez
Copy link
Contributor

@cdumez cdumez commented May 15, 2023 •
edited by webkit-early-warning-system

168fc8d

Expose WKBackForwardListItem._wasCreatedByJSWithoutUserInteraction as SPI
https://bugs.webkit.org/show_bug.cgi?id=256798
rdar://109366865

Reviewed by Brent Fulgham.

Expose WKBackForwardListItem._wasCreatedByJSWithoutUserInteraction as SPI. We
use this flag internally to determine whether or not we should skip a
particular back/forward list item when navigating back / forward.

* Source/WebKit/UIProcess/API/Cocoa/WKBackForwardListItem.mm:
(-[WKBackForwardListItem _scrollPosition]):
(-[WKBackForwardListItem _wasCreatedByJSWithoutUserInteraction]):
* Source/WebKit/UIProcess/API/Cocoa/WKBackForwardListItemPrivate.h:
* Tools/TestWebKitAPI/Tests/WebKit/WKBackForwardListTests.mm:
(runBackForwardNavigationSkipsItemsWithoutUserGestureTest):
(runBackForwardNavigationDoesNotSkipItemsWithUserGestureTest):
(TEST):

Canonical link: https://commits.webkit.org/264082@main

9a20a61

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
  🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
  🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@cdumez cdumez self-assigned this May 15, 2023
@cdumez cdumez added the WebKit2 Bugs relating to the WebKit2 API layer label May 15, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 9a20a61)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
  🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
  🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

brentfulgham
brentfulgham approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@brentfulgham brentfulgham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, and includes a test!

@cdumez cdumez added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 15, 2023
@cdumez
Expose WKBackForwardListItem._wasCreatedByJSWithoutUserInteraction as…
168fc8d 
… SPI

https://bugs.webkit.org/show_bug.cgi?id=256798
rdar://109366865

Reviewed by Brent Fulgham.

Expose WKBackForwardListItem._wasCreatedByJSWithoutUserInteraction as SPI. We
use this flag internally to determine whether or not we should skip a
particular back/forward list item when navigating back / forward.

* Source/WebKit/UIProcess/API/Cocoa/WKBackForwardListItem.mm:
(-[WKBackForwardListItem _scrollPosition]):
(-[WKBackForwardListItem _wasCreatedByJSWithoutUserInteraction]):
* Source/WebKit/UIProcess/API/Cocoa/WKBackForwardListItemPrivate.h:
* Tools/TestWebKitAPI/Tests/WebKit/WKBackForwardListTests.mm:
(runBackForwardNavigationSkipsItemsWithoutUserGestureTest):
(runBackForwardNavigationDoesNotSkipItemsWithUserGestureTest):
(TEST):

Canonical link: https://commits.webkit.org/264082@main
@webkit-commit-queue webkit-commit-queue force-pushed the 256798_WKBackForwardItem_wasCreatedByJSWithoutUserInteraction branch from 9a20a61 to 168fc8d Compare May 15, 2023 21:13
@webkit-commit-queue
Copy link
Collaborator

Committed 264082@main (168fc8d): https://commits.webkit.org/264082@main

Reviewed commits have been landed. Closing PR #13890 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 168fc8d into WebKit:main May 15, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentfulgham brentfulgham brentfulgham approved these changes

@achristensen07 achristensen07 Awaiting requested review from achristensen07

@geoffreygaren geoffreygaren Awaiting requested review from geoffreygaren

Assignees

@cdumez cdumez

Labels
WebKit2 Bugs relating to the WebKit2 API layer
Projects
None yet
Milestone
No milestone
4 participants
@cdumez @webkit-early-warning-system @webkit-commit-queue @brentfulgham