Prepare to remove Span.h #13923

achristensen07 · 2023-05-16T16:05:43Z

`9d25322`

Prepare to remove Span.h
https://bugs.webkit.org/show_bug.cgi?id=256843

Reviewed by Ryosuke Niwa.

It has been replaced by <span>

* Source/JavaScriptCore/jsc.cpp:
(JSC_DEFINE_HOST_FUNCTION):
* Source/WTF/wtf/ArgumentCoder.h:
* Source/WTF/wtf/SHA1.h:
(WTF::SHA1::addBytes):
* Source/WTF/wtf/Span.h:
(WTF::makeSpan): Deleted.
(WTF::asBytes): Deleted.
(WTF::asWritableBytes): Deleted.
* Source/WTF/wtf/StackTrace.h:
* Source/WTF/wtf/Vector.h:
* Source/WTF/wtf/cf/SpanCF.h:
* Source/WTF/wtf/cocoa/SpanCocoa.h:
* Source/WTF/wtf/darwin/LibraryPathDiagnostics.mm:
* Source/WTF/wtf/persistence/PersistentDecoder.h:
* Source/WTF/wtf/persistence/PersistentEncoder.h:
* Source/WTF/wtf/text/ASCIILiteral.h:
* Source/WTF/wtf/text/Base64.cpp:
(WTF::base64EncodeInternal):
(WTF::base64Decode):
* Source/WTF/wtf/text/Base64.h:
(WTF::base64EncodeToVector):
(WTF::base64EncodeToString):
(WTF::base64EncodeToStringReturnNullIfOverflow):
(WTF::base64Decode):
(WTF::base64Encoded):
(WTF::StringTypeAdapter<Base64Specification>::writeTo const):
* Source/WTF/wtf/text/CString.h:
* Source/WTF/wtf/text/StringBuilder.h:
(WTF::StringBuilder::span const):
* Source/WTF/wtf/text/StringImpl.h:
(WTF::StringImpl::tryGetUTF8ForCharacters):
* Source/WTF/wtf/text/StringSearch.h:
(WTF::BoyerMooreHorspoolTable::BoyerMooreHorspoolTable):
* Source/WTF/wtf/text/WTFString.h:
(WTF::String::tryGetUTF8 const):
* Source/WebCore/Modules/fetch/FetchResponse.h:
* Source/WebCore/Modules/fetch/FormDataConsumer.h:
* Source/WebCore/Modules/mediastream/RTCRtpTransformableFrame.h:
* Source/WebCore/Modules/push-api/PushCrypto.h:
* Source/WebCore/Modules/push-api/PushDatabase.cpp:
(WebCore::uuidToSpan):
* Source/WebCore/Modules/push-api/PushDatabase.h:
* Source/WebCore/Modules/push-api/PushMessageCrypto.cpp:
(WebCore::PushCrypto::decryptAES128GCMPayload):
(WebCore::PushCrypto::decryptAESGCMPayload):
* Source/WebCore/Modules/push-api/PushMessageCrypto.h:
* Source/WebCore/Modules/streams/ReadableStreamSink.h:
* Source/WebCore/Modules/webauthn/AuthenticatorResponseData.h:
(WebCore::encodeArrayBuffer):
* Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp:
(WebCore::WebXROpaqueFramebuffer::startFrame):
(WebCore::WebXROpaqueFramebuffer::endFrame):
(WebCore::WebXROpaqueFramebuffer::setupFramebuffer):
* Source/WebCore/bindings/js/BufferSource.h:
* Source/WebCore/bindings/js/SerializedScriptValue.h:
(WebCore::SerializedScriptValue::encode const):
* Source/WebCore/contentextensions/CompiledContentExtension.h:
* Source/WebCore/css/ComputedStyleExtractor.h:
* Source/WebCore/dom/make_names.pl:
(printTagNameCppFile):
(printNodeNameCppFile):
* Source/WebCore/fileapi/NetworkSendQueue.cpp:
(WebCore::NetworkSendQueue::enqueue):
(WebCore::NetworkSendQueue::processMessages):
* Source/WebCore/fileapi/NetworkSendQueue.h:
* Source/WebCore/html/CanvasNoiseInjection.cpp:
(WebCore::CanvasNoiseInjection::postProcessPixelBufferResults const):
* Source/WebCore/html/canvas/CanvasPath.cpp:
(WebCore::CanvasPath::roundRect):
* Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:
(WebCore::WebGL2RenderingContext::getBufferSubData):
(WebCore::WebGL2RenderingContext::compressedTexImage2D):
(WebCore::WebGL2RenderingContext::compressedTexImage3D):
(WebCore::WebGL2RenderingContext::compressedTexSubImage2D):
(WebCore::WebGL2RenderingContext::compressedTexSubImage3D):
* Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::bufferData):
(WebCore::WebGLRenderingContextBase::bufferSubData):
(WebCore::WebGLRenderingContextBase::compressedTexImage2D):
(WebCore::WebGLRenderingContextBase::compressedTexSubImage2D):
(WebCore::WebGLRenderingContextBase::readPixels):
(WebCore::WebGLRenderingContextBase::validateTexFuncData):
* Source/WebCore/html/parser/HTMLDocumentParserFastPath.cpp:
* Source/WebCore/html/shadow/TextControlInnerElements.cpp:
(WebCore::TextControlInnerTextElement::updateInnerTextElementEditabilityImpl):
* Source/WebCore/loader/icon/IconLoader.cpp:
(WebCore::IconLoader::notifyFinished):
* Source/WebCore/page/PageColorSampler.cpp:
(WebCore::PageColorSampler::sampleTop):
* Source/WebCore/platform/SharedBuffer.h:
(WebCore::SharedBuffer::dataAsSpanForContiguousData const):
* Source/WebCore/platform/VideoDecoder.h:
* Source/WebCore/platform/VideoEncoder.h:
* Source/WebCore/platform/cocoa/SharedVideoFrameInfo.h:
* Source/WebCore/platform/graphics/ByteArrayPixelBuffer.h:
(WebCore::ByteArrayPixelBuffer::encode const):
* Source/WebCore/platform/graphics/GraphicsContextGL.h:
* Source/WebCore/platform/network/ResourceResponseBase.h:
* Source/WebCore/platform/sql/SQLiteStatement.cpp:
(WebCore::SQLiteStatement::bindBlob):
* Source/WebCore/platform/sql/SQLiteStatement.h:
* Source/WebCore/workers/service/background-fetch/BackgroundFetchEngine.h:
* Source/WebCore/workers/service/background-fetch/BackgroundFetchRecordLoader.h:
* Source/WebCore/workers/service/server/SWRegistrationDatabase.cpp:
(WebCore::SWRegistrationDatabase::updateRegistrations):
* Source/WebCore/xml/XMLErrors.cpp:
(WebCore::createXHTMLParserErrorHeader):
(WebCore::XMLErrors::insertErrorMessageBlock):
* Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp:
(WebKit::RemoteGraphicsContextGL::readnPixels2):
* Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGLFunctionsGenerated.h:
(uniform1fv):
(uniform1iv):
(uniform2fv):
(uniform2iv):
(uniform3fv):
(uniform3iv):
(uniform4fv):
(uniform4iv):
(uniformMatrix2fv):
(uniformMatrix3fv):
(uniformMatrix4fv):
(bufferData1):
(bufferSubData):
(texImage2D0):
(texSubImage2D0):
(compressedTexImage2D0):
(compressedTexSubImage2D0):
(invalidateFramebuffer):
(invalidateSubFramebuffer):
(texImage3D0):
(texSubImage3D0):
(compressedTexImage3D0):
(compressedTexSubImage3D0):
(uniform1uiv):
(uniform2uiv):
(uniform3uiv):
(uniform4uiv):
(uniformMatrix2x3fv):
(uniformMatrix3x2fv):
(uniformMatrix2x4fv):
(uniformMatrix4x2fv):
(uniformMatrix3x4fv):
(uniformMatrix4x3fv):
(drawBuffers):
(clearBufferiv):
(clearBufferuiv):
(clearBufferfv):
(drawBuffersEXT):
* Source/WebKit/NetworkProcess/NetworkLoad.cpp:
(WebKit::NetworkLoad::notifyDidReceiveResponse):
* Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp:
(WebKit::CacheStorage::Engine::writeSizeFile):
* Source/WebKit/NetworkProcess/cache/NetworkCacheData.h:
* Source/WebKit/NetworkProcess/storage/CacheStorageDiskStore.cpp:
(WebKit::readRecordInfoFromFileData):
(WebKit::CacheStorageDiskStore::readRecordFromFileData):
(WebKit::CacheStorageDiskStore::writeRecords):
* Source/WebKit/NetworkProcess/storage/CacheStorageManager.cpp:
(WebKit::writeCachesList):
(WebKit::writeSizeFile):
* Source/WebKit/Platform/IPC/ArgumentCoders.cpp:
(IPC::ArgumentCoder<String>::encode):
* Source/WebKit/Platform/IPC/ArgumentCoders.h:
(IPC::ArgumentCoder<SHA1::Digest>::encode):
* Source/WebKit/Platform/IPC/ArrayReference.h:
* Source/WebKit/Platform/IPC/DataReference.h:
* Source/WebKit/Platform/IPC/Encoder.h:
(IPC::Encoder::encodeObject):
* Source/WebKit/Platform/IPC/StreamConnectionBuffer.h:
* Source/WebKit/Platform/IPC/StreamConnectionEncoder.h:
* Source/WebKit/Shared/Cocoa/SandboxExtensionCocoa.mm:
(WebKit::SandboxExtension::createHandlesForMachLookup):
* Source/WebKit/Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<WebCore::FragmentedSharedBuffer>::encode):
* Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h:
* Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp:
(WebKit::IPCTestingAPI::encodeTypedArray):
* Source/WebKit/webpushd/WebPushDaemon.h:
* Source/WebKit/webpushd/WebPushDaemon.mm:
* Source/WebKitLegacy/mac/History/BinaryPropertyList.cpp:
(add):
* Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Tests/IPC/ArgumentCoderTests.cpp:
(TestWebKitAPI::TYPED_TEST_P):
* Tools/TestWebKitAPI/Tests/WTF/Span.cpp: Removed.

Canonical link: https://commits.webkit.org/264168@main

14c1bea

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🧪 api-mac	✅ 🛠 gtk
✅ 🧪 webkitpy	~~🧪 ios-wk2-wpt~~	✅ 🧪 mac-wk1	~~🧪 gtk-wk2~~
✅ 🛠 🧪 jsc	~~🧪 api-ios~~	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch		✅ 🛠 jsc-mips
✅ 🛠 🧪 unsafe-merge	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-05-16T16:08:46Z

EWS run on previous version of this PR (hash 0302675)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	❌ 🛠 wpe	❌ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	❌ 🧪 api-mac	❌ 🛠 gtk
✅ 🧪 webkitpy	❌ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	❌ 🧪 gtk-wk2
✅ 🛠 🧪 jsc	~~🧪 api-ios~~	✅ 🧪 mac-wk2	❌ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch		✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-05-16T20:58:29Z

EWS run on previous version of this PR (hash 62864ae)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	❌ 🛠 wpe	❌ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	❌ 🛠 gtk
✅ 🧪 webkitpy	⏳ 🧪 ios-wk2-wpt	~~🧪 mac-wk1~~	❌ 🧪 gtk-wk2
⏳ 🛠 🧪 jsc	⏳ 🧪 api-ios	~~🧪 mac-wk2~~	❌ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	⏳ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch		✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-05-16T21:32:54Z

EWS run on previous version of this PR (hash eabf4d7)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
✅ 🧪 webkitpy	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	❌ 🧪 gtk-wk2
✅ 🛠 🧪 jsc	~~🧪 api-ios~~	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch		✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-05-17T01:37:08Z

EWS run on previous version of this PR (hash 5407642)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	✅ 🛠 gtk
❌ 🧪 webkitpy	⏳ 🧪 ios-wk2-wpt	~~🧪 mac-wk1~~	~~🧪 gtk-wk2~~
⏳ 🛠 🧪 jsc	⏳ 🧪 api-ios	~~🧪 mac-wk2~~	~~🧪 api-gtk~~
✅ 🛠 🧪 jsc-arm64	~~🛠 tv~~	⏳ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-armv7
	~~🛠 tv-sim~~		✅ 🧪 jsc-armv7-tests
	~~🛠 watch~~		✅ 🛠 jsc-mips
	⏳ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-05-17T01:52:25Z

EWS run on previous version of this PR (hash 9324aee)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
✅ 🧪 webkitpy	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64	❌ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-armv7
	❌ 🛠 tv-sim		✅ 🧪 jsc-armv7-tests
	❌ 🛠 watch		✅ 🛠 jsc-mips
	❌ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-05-17T16:12:22Z

EWS run on current version of this PR (hash 14c1bea)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🧪 api-mac	✅ 🛠 gtk
✅ 🧪 webkitpy	~~🧪 ios-wk2-wpt~~	✅ 🧪 mac-wk1	~~🧪 gtk-wk2~~
✅ 🛠 🧪 jsc	~~🧪 api-ios~~	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch		✅ 🛠 jsc-mips
✅ 🛠 🧪 unsafe-merge	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

rniwa · 2023-05-17T19:18:26Z

Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm

@@ -925,6 +924,13 @@ - (void)cancel
 }
 #endif

+#if ENABLE(WEB_AUTHN)
+static std::span<const uint8_t> asUInt8Span(NSData* data)


Where is this used?

It's used twice below. It used to be in SpanCocoa.h but this was the only place it's used, so I moved I there.

https://bugs.webkit.org/show_bug.cgi?id=256843 Reviewed by Ryosuke Niwa. It has been replaced by <span> * Source/JavaScriptCore/jsc.cpp: (JSC_DEFINE_HOST_FUNCTION): * Source/WTF/wtf/ArgumentCoder.h: * Source/WTF/wtf/SHA1.h: (WTF::SHA1::addBytes): * Source/WTF/wtf/Span.h: (WTF::makeSpan): Deleted. (WTF::asBytes): Deleted. (WTF::asWritableBytes): Deleted. * Source/WTF/wtf/StackTrace.h: * Source/WTF/wtf/Vector.h: * Source/WTF/wtf/cf/SpanCF.h: * Source/WTF/wtf/cocoa/SpanCocoa.h: * Source/WTF/wtf/darwin/LibraryPathDiagnostics.mm: * Source/WTF/wtf/persistence/PersistentDecoder.h: * Source/WTF/wtf/persistence/PersistentEncoder.h: * Source/WTF/wtf/text/ASCIILiteral.h: * Source/WTF/wtf/text/Base64.cpp: (WTF::base64EncodeInternal): (WTF::base64Decode): * Source/WTF/wtf/text/Base64.h: (WTF::base64EncodeToVector): (WTF::base64EncodeToString): (WTF::base64EncodeToStringReturnNullIfOverflow): (WTF::base64Decode): (WTF::base64Encoded): (WTF::StringTypeAdapter<Base64Specification>::writeTo const): * Source/WTF/wtf/text/CString.h: * Source/WTF/wtf/text/StringBuilder.h: (WTF::StringBuilder::span const): * Source/WTF/wtf/text/StringImpl.h: (WTF::StringImpl::tryGetUTF8ForCharacters): * Source/WTF/wtf/text/StringSearch.h: (WTF::BoyerMooreHorspoolTable::BoyerMooreHorspoolTable): * Source/WTF/wtf/text/WTFString.h: (WTF::String::tryGetUTF8 const): * Source/WebCore/Modules/fetch/FetchResponse.h: * Source/WebCore/Modules/fetch/FormDataConsumer.h: * Source/WebCore/Modules/mediastream/RTCRtpTransformableFrame.h: * Source/WebCore/Modules/push-api/PushCrypto.h: * Source/WebCore/Modules/push-api/PushDatabase.cpp: (WebCore::uuidToSpan): * Source/WebCore/Modules/push-api/PushDatabase.h: * Source/WebCore/Modules/push-api/PushMessageCrypto.cpp: (WebCore::PushCrypto::decryptAES128GCMPayload): (WebCore::PushCrypto::decryptAESGCMPayload): * Source/WebCore/Modules/push-api/PushMessageCrypto.h: * Source/WebCore/Modules/streams/ReadableStreamSink.h: * Source/WebCore/Modules/webauthn/AuthenticatorResponseData.h: (WebCore::encodeArrayBuffer): * Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp: (WebCore::WebXROpaqueFramebuffer::startFrame): (WebCore::WebXROpaqueFramebuffer::endFrame): (WebCore::WebXROpaqueFramebuffer::setupFramebuffer): * Source/WebCore/bindings/js/BufferSource.h: * Source/WebCore/bindings/js/SerializedScriptValue.h: (WebCore::SerializedScriptValue::encode const): * Source/WebCore/contentextensions/CompiledContentExtension.h: * Source/WebCore/css/ComputedStyleExtractor.h: * Source/WebCore/dom/make_names.pl: (printTagNameCppFile): (printNodeNameCppFile): * Source/WebCore/fileapi/NetworkSendQueue.cpp: (WebCore::NetworkSendQueue::enqueue): (WebCore::NetworkSendQueue::processMessages): * Source/WebCore/fileapi/NetworkSendQueue.h: * Source/WebCore/html/CanvasNoiseInjection.cpp: (WebCore::CanvasNoiseInjection::postProcessPixelBufferResults const): * Source/WebCore/html/canvas/CanvasPath.cpp: (WebCore::CanvasPath::roundRect): * Source/WebCore/html/canvas/WebGL2RenderingContext.cpp: (WebCore::WebGL2RenderingContext::getBufferSubData): (WebCore::WebGL2RenderingContext::compressedTexImage2D): (WebCore::WebGL2RenderingContext::compressedTexImage3D): (WebCore::WebGL2RenderingContext::compressedTexSubImage2D): (WebCore::WebGL2RenderingContext::compressedTexSubImage3D): * Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp: (WebCore::WebGLRenderingContextBase::bufferData): (WebCore::WebGLRenderingContextBase::bufferSubData): (WebCore::WebGLRenderingContextBase::compressedTexImage2D): (WebCore::WebGLRenderingContextBase::compressedTexSubImage2D): (WebCore::WebGLRenderingContextBase::readPixels): (WebCore::WebGLRenderingContextBase::validateTexFuncData): * Source/WebCore/html/parser/HTMLDocumentParserFastPath.cpp: * Source/WebCore/html/shadow/TextControlInnerElements.cpp: (WebCore::TextControlInnerTextElement::updateInnerTextElementEditabilityImpl): * Source/WebCore/loader/icon/IconLoader.cpp: (WebCore::IconLoader::notifyFinished): * Source/WebCore/page/PageColorSampler.cpp: (WebCore::PageColorSampler::sampleTop): * Source/WebCore/platform/SharedBuffer.h: (WebCore::SharedBuffer::dataAsSpanForContiguousData const): * Source/WebCore/platform/VideoDecoder.h: * Source/WebCore/platform/VideoEncoder.h: * Source/WebCore/platform/cocoa/SharedVideoFrameInfo.h: * Source/WebCore/platform/graphics/ByteArrayPixelBuffer.h: (WebCore::ByteArrayPixelBuffer::encode const): * Source/WebCore/platform/graphics/GraphicsContextGL.h: * Source/WebCore/platform/network/ResourceResponseBase.h: * Source/WebCore/platform/sql/SQLiteStatement.cpp: (WebCore::SQLiteStatement::bindBlob): * Source/WebCore/platform/sql/SQLiteStatement.h: * Source/WebCore/workers/service/background-fetch/BackgroundFetchEngine.h: * Source/WebCore/workers/service/background-fetch/BackgroundFetchRecordLoader.h: * Source/WebCore/workers/service/server/SWRegistrationDatabase.cpp: (WebCore::SWRegistrationDatabase::updateRegistrations): * Source/WebCore/xml/XMLErrors.cpp: (WebCore::createXHTMLParserErrorHeader): (WebCore::XMLErrors::insertErrorMessageBlock): * Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp: (WebKit::RemoteGraphicsContextGL::readnPixels2): * Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGLFunctionsGenerated.h: (uniform1fv): (uniform1iv): (uniform2fv): (uniform2iv): (uniform3fv): (uniform3iv): (uniform4fv): (uniform4iv): (uniformMatrix2fv): (uniformMatrix3fv): (uniformMatrix4fv): (bufferData1): (bufferSubData): (texImage2D0): (texSubImage2D0): (compressedTexImage2D0): (compressedTexSubImage2D0): (invalidateFramebuffer): (invalidateSubFramebuffer): (texImage3D0): (texSubImage3D0): (compressedTexImage3D0): (compressedTexSubImage3D0): (uniform1uiv): (uniform2uiv): (uniform3uiv): (uniform4uiv): (uniformMatrix2x3fv): (uniformMatrix3x2fv): (uniformMatrix2x4fv): (uniformMatrix4x2fv): (uniformMatrix3x4fv): (uniformMatrix4x3fv): (drawBuffers): (clearBufferiv): (clearBufferuiv): (clearBufferfv): (drawBuffersEXT): * Source/WebKit/NetworkProcess/NetworkLoad.cpp: (WebKit::NetworkLoad::notifyDidReceiveResponse): * Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp: (WebKit::CacheStorage::Engine::writeSizeFile): * Source/WebKit/NetworkProcess/cache/NetworkCacheData.h: * Source/WebKit/NetworkProcess/storage/CacheStorageDiskStore.cpp: (WebKit::readRecordInfoFromFileData): (WebKit::CacheStorageDiskStore::readRecordFromFileData): (WebKit::CacheStorageDiskStore::writeRecords): * Source/WebKit/NetworkProcess/storage/CacheStorageManager.cpp: (WebKit::writeCachesList): (WebKit::writeSizeFile): * Source/WebKit/Platform/IPC/ArgumentCoders.cpp: (IPC::ArgumentCoder<String>::encode): * Source/WebKit/Platform/IPC/ArgumentCoders.h: (IPC::ArgumentCoder<SHA1::Digest>::encode): * Source/WebKit/Platform/IPC/ArrayReference.h: * Source/WebKit/Platform/IPC/DataReference.h: * Source/WebKit/Platform/IPC/Encoder.h: (IPC::Encoder::encodeObject): * Source/WebKit/Platform/IPC/StreamConnectionBuffer.h: * Source/WebKit/Platform/IPC/StreamConnectionEncoder.h: * Source/WebKit/Shared/Cocoa/SandboxExtensionCocoa.mm: (WebKit::SandboxExtension::createHandlesForMachLookup): * Source/WebKit/Shared/WebCoreArgumentCoders.cpp: (IPC::ArgumentCoder<WebCore::FragmentedSharedBuffer>::encode): * Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h: * Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp: (WebKit::IPCTestingAPI::encodeTypedArray): * Source/WebKit/webpushd/WebPushDaemon.h: * Source/WebKit/webpushd/WebPushDaemon.mm: * Source/WebKitLegacy/mac/History/BinaryPropertyList.cpp: (add): * Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * Tools/TestWebKitAPI/Tests/IPC/ArgumentCoderTests.cpp: (TestWebKitAPI::TYPED_TEST_P): * Tools/TestWebKitAPI/Tests/WTF/Span.cpp: Removed. Canonical link: https://commits.webkit.org/264168@main

webkit-commit-queue · 2023-05-17T19:55:26Z

Committed 264168@main (9d25322): https://commits.webkit.org/264168@main

Reviewed commits have been landed. Closing PR #13923 and removing active labels.

achristensen07 requested review from cdumez, b-weinstein, xeenon, rniwa, a team and JonWBedard as code owners May 16, 2023 16:05

achristensen07 self-assigned this May 16, 2023

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 16, 2023

achristensen07 force-pushed the eng/Prepare-to-remove-Span-h branch from 0302675 to 62864ae Compare May 16, 2023 20:55

achristensen07 force-pushed the eng/Prepare-to-remove-Span-h branch from 62864ae to eabf4d7 Compare May 16, 2023 21:29

achristensen07 requested review from a team and philn as code owners May 16, 2023 21:29

achristensen07 force-pushed the eng/Prepare-to-remove-Span-h branch from eabf4d7 to 5407642 Compare May 17, 2023 01:36

achristensen07 removed the merging-blocked Applied to prevent a change from being merged label May 17, 2023

achristensen07 force-pushed the eng/Prepare-to-remove-Span-h branch from 5407642 to 9324aee Compare May 17, 2023 01:50

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 17, 2023

achristensen07 force-pushed the eng/Prepare-to-remove-Span-h branch from 9324aee to 14c1bea Compare May 17, 2023 16:09

achristensen07 removed the merging-blocked Applied to prevent a change from being merged label May 17, 2023

rniwa reviewed May 17, 2023

View reviewed changes

rniwa approved these changes May 17, 2023

View reviewed changes

achristensen07 added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 17, 2023

webkit-commit-queue force-pushed the eng/Prepare-to-remove-Span-h branch from 14c1bea to 9d25322 Compare May 17, 2023 19:55

webkit-commit-queue merged commit 9d25322 into WebKit:main May 17, 2023

webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 17, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prepare to remove Span.h #13923

Prepare to remove Span.h #13923

achristensen07 commented May 16, 2023 •

edited by webkit-early-warning-system

webkit-early-warning-system commented May 16, 2023 •

edited

webkit-early-warning-system commented May 16, 2023 •

edited

webkit-early-warning-system commented May 16, 2023 •

edited

webkit-early-warning-system commented May 17, 2023 •

edited

webkit-early-warning-system commented May 17, 2023 •

edited

webkit-early-warning-system commented May 17, 2023 •

edited

rniwa May 17, 2023

achristensen07 May 17, 2023

webkit-commit-queue commented May 17, 2023

Prepare to remove Span.h #13923

Prepare to remove Span.h #13923

Conversation

achristensen07 commented May 16, 2023 • edited by webkit-early-warning-system

9d25322

webkit-early-warning-system commented May 16, 2023 • edited

webkit-early-warning-system commented May 16, 2023 • edited

webkit-early-warning-system commented May 16, 2023 • edited

webkit-early-warning-system commented May 17, 2023 • edited

webkit-early-warning-system commented May 17, 2023 • edited

webkit-early-warning-system commented May 17, 2023 • edited

rniwa May 17, 2023

Choose a reason for hiding this comment

achristensen07 May 17, 2023

Choose a reason for hiding this comment

webkit-commit-queue commented May 17, 2023

achristensen07 commented May 16, 2023 •

edited by webkit-early-warning-system

`9d25322`

webkit-early-warning-system commented May 16, 2023 •

edited

webkit-early-warning-system commented May 16, 2023 •

edited

webkit-early-warning-system commented May 16, 2023 •

edited

webkit-early-warning-system commented May 17, 2023 •

edited

webkit-early-warning-system commented May 17, 2023 •

edited

webkit-early-warning-system commented May 17, 2023 •

edited