New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[import-w3c-tests] Make --clean-dest-dir work with partial imports #13929
[import-w3c-tests] Make --clean-dest-dir work with partial imports #13929
Conversation
EWS run on previous version of this PR (hash e2a657e) |
@youennf you'd asked for a unit-test for an earlier version of this in https://bugs.webkit.org/show_bug.cgi?id=235038; this finally does that, and fixes several bugs in the existing code now there's test coverage |
e2a657e
to
dd3da92
Compare
EWS run on current version of this PR (hash dd3da92) |
https://bugs.webkit.org/show_bug.cgi?id=256751 Reviewed by Jonathan Bedard. We need to do this slightly more lazily, and not just blanket clean the entire destination directory. Fix updating resource-files.json to write the file even if we aren't importing new support files, as might be true of a partial import. And finally fix removing items from tests-options.json to match against the correct path, and avoid mutating the object we're iterating over (which raises an RuntimeError). * Tools/Scripts/webkitpy/w3c/test_importer.py: (TestImporter.__init__): (TestImporter.do_import): (TestImporter.import_tests): (TestImporter.remove_slow_from_w3c_tests_options): * Tools/Scripts/webkitpy/w3c/test_importer_unittest.py: Canonical link: https://commits.webkit.org/264384@main
dd3da92
to
3482356
Compare
Committed 264384@main (3482356): https://commits.webkit.org/264384@main Reviewed commits have been landed. Closing PR #13929 and removing active labels. |
3482356
dd3da92