[WebGPU] Add typedef for performWithMediaPlayerOnMainThread #13943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on previous version of this PR (hash 8c1bcfc) |
mwyrzykowski
changed the title
webkit-ews-buildbot
added
the
merging-blocked
litherum
reviewed
May 16, 2023
| @@ -63,10 +63,12 @@ class ObjectHeap; | |||
| struct RequestAdapterOptions; | |||
| } | |||
|
|
|||
| typedef Function<void(WebCore::MediaPlayerIdentifier, Function<void(WebCore::MediaPlayer&)>&&)> PerformWithMediaPlayerOnMainThread; | |||
There was a problem hiding this comment.
I think we generally prefer using PerformWithMediaPlayerOnMainThread = Function<void(WebCore::MediaPlayerIdentifier, Function<void(WebCore::MediaPlayer&)>&&)> rather than typedef
Also, can we break this into two lines?
using MediaPlayerAccessor = Function<void(WebCore::MediaPlayer&)>;
using PerformWithMediaPlayerOnMainThread = Function<void(WebCore::MediaPlayerIdentifier, MediaPlayerAccessor&&)>;
litherum
approved these changes
May 16, 2023
mwyrzykowski
removed
the
merging-blocked
mwyrzykowski
force-pushed
the
eng/WebGPU-Add-typedef-for-performWithMediaPlayerOnMainThread
branch
from
8c1bcfc
to
09519cd
Compare
|
EWS run on current version of this PR (hash 09519cd)
|
https://bugs.webkit.org/show_bug.cgi?id=256866 <radar://109429790> Reviewed by Myles C. Maxfield. Make this easier to read with a typedef. * Source/WebKit/GPUProcess/graphics/WebGPU/RemoteAdapter.cpp: (WebKit::RemoteAdapter::RemoteAdapter): * Source/WebKit/GPUProcess/graphics/WebGPU/RemoteAdapter.h: * Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.cpp: (WebKit::RemoteDevice::RemoteDevice): * Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.h: * Source/WebKit/GPUProcess/graphics/WebGPU/RemoteGPU.cpp: (WebKit::RemoteGPU::RemoteGPU): * Source/WebKit/GPUProcess/graphics/WebGPU/RemoteGPU.h: Canonical link: https://commits.webkit.org/264131@main
webkit-commit-queue
force-pushed
the
eng/WebGPU-Add-typedef-for-performWithMediaPlayerOnMainThread
branch
from
09519cd
to
b2fbc85
Compare
|
Committed 264131@main (b2fbc85): https://commits.webkit.org/264131@main Reviewed commits have been landed. Closing PR #13943 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b2fbc85
09519cd
🧪 wpe-wk2🧪 ios-wk2-wpt🧪 gtk-wk2🧪 api-ios🧪 mac-AS-debug-wk2