Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REGRESSION (2023-05-13): [ macOS ] TestWebKitAPI.WKAttachmentTests.MovePastedImageByDragging is a consistent failure #13948

Merged
merged 1 commit into from
May 17, 2023
Merged

REGRESSION (2023-05-13): [ macOS ] TestWebKitAPI.WKAttachmentTests.MovePastedImageByDragging is a consistent failure #13948

merged 1 commit into from
May 17, 2023

Conversation

whsieh
Copy link
Member

@whsieh whsieh commented May 17, 2023 •
edited by webkit-early-warning-system

255d31d

REGRESSION (2023-05-13): [ macOS ] TestWebKitAPI.WKAttachmentTests.MovePastedImageByDragging is a consistent failure
https://bugs.webkit.org/show_bug.cgi?id=256864
rdar://109428176

Reviewed by Aditya Keerthi.

Fix a race condition in `WKAttachmentTests.MovePastedImageByDragging`, by ensuring that the pasted
image finishes loading (and rendering) before attempting to initiate a drag over the image element.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:

Canonical link: https://commits.webkit.org/264137@main

686facd

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
  🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
  🧪 api-ios   🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@whsieh whsieh self-assigned this May 17, 2023
@whsieh whsieh added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label May 17, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 686facd)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
  🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
  🧪 api-ios   🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@whsieh
Copy link
Member Author

whsieh commented May 17, 2023

Thanks for the review!

@whsieh whsieh added the merge-queue Applied to send a pull request to merge-queue label May 17, 2023
@webkit-ews-buildbot webkit-ews-buildbot added merging-blocked Applied to prevent a change from being merged and removed merge-queue Applied to send a pull request to merge-queue labels May 17, 2023
@whsieh whsieh added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels May 17, 2023
@whsieh
REGRESSION (2023-05-13): [ macOS ] TestWebKitAPI.WKAttachmentTests.Mo…
255d31d 
…vePastedImageByDragging is a consistent failure

https://bugs.webkit.org/show_bug.cgi?id=256864
rdar://109428176

Reviewed by Aditya Keerthi.

Fix a race condition in `WKAttachmentTests.MovePastedImageByDragging`, by ensuring that the pasted
image finishes loading (and rendering) before attempting to initiate a drag over the image element.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:

Canonical link: https://commits.webkit.org/264137@main
@webkit-commit-queue
Copy link
Collaborator

Committed 264137@main (255d31d): https://commits.webkit.org/264137@main

Reviewed commits have been landed. Closing PR #13948 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 255d31d into WebKit:main May 17, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label May 17, 2023
@whsieh whsieh deleted the eng/256864 branch May 21, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pxlcoder pxlcoder pxlcoder approved these changes

@hortont424 hortont424 Awaiting requested review from hortont424

@megangardner megangardner Awaiting requested review from megangardner

Assignees

@whsieh whsieh

Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Milestone
No milestone
5 participants
@whsieh @webkit-early-warning-system @webkit-commit-queue @pxlcoder @webkit-ews-buildbot