Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GTK][WPE] Fix broken test expectations #13950

Conversation

csaavedra
Copy link
Member

@csaavedra csaavedra commented May 17, 2023

c32aedc

[GTK][WPE] Fix broken test expectations
https://bugs.webkit.org/show_bug.cgi?id=256881

Unreviewed gardening.

263587@main updated GTK and WPE expectations but did a poor job
on actually not breaking them. Fix them.

* LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:

Canonical link: https://commits.webkit.org/264139@main

346e221

Misc iOS, tvOS & watchOS macOS Linux Windows
❌ πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe   πŸ›  wincairo
  πŸ›  ios-sim βœ… πŸ›  mac-AS-debug   πŸ§ͺ wpe-wk2
  πŸ§ͺ webkitperl   πŸ§ͺ ios-wk2   πŸ§ͺ api-mac βœ… πŸ›  gtk
  πŸ§ͺ ios-wk2-wpt   πŸ§ͺ mac-wk1   πŸ§ͺ gtk-wk2
  πŸ§ͺ api-ios   πŸ§ͺ mac-wk2   πŸ§ͺ api-gtk
  πŸ›  tv   πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  tv-sim
βœ… πŸ›  watch
βœ… πŸ›  πŸ§ͺ unsafe-merge βœ… πŸ›  watch-sim

@csaavedra csaavedra self-assigned this May 17, 2023
@csaavedra csaavedra added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing labels May 17, 2023
@csaavedra csaavedra force-pushed the eng/GTKWPE-Fix-broken-test-expectations branch from eb56c4d to 346e221 Compare May 17, 2023 08:45
@csaavedra csaavedra added the WebKitGTK Bugs related to the Gtk API layer. label May 17, 2023
@csaavedra csaavedra added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 17, 2023
https://bugs.webkit.org/show_bug.cgi?id=256881

Unreviewed gardening.

263587@main updated GTK and WPE expectations but did a poor job
on actually not breaking them. Fix them.

* LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:

Canonical link: https://commits.webkit.org/264139@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/GTKWPE-Fix-broken-test-expectations branch from 346e221 to c32aedc Compare May 17, 2023 08:50
@webkit-commit-queue
Copy link
Collaborator

Committed 264139@main (c32aedc): https://commits.webkit.org/264139@main

Reviewed commits have been landed. Closing PR #13950 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit c32aedc into WebKit:main May 17, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 17, 2023
@csaavedra csaavedra deleted the eng/GTKWPE-Fix-broken-test-expectations branch December 12, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebKitGTK Bugs related to the Gtk API layer.
Projects
None yet
3 participants