ASSERTION FAILED: !m_shouldFilterICECandidates || sdp.contains(".local"_s) || sdp.contains(" srflx "_s) in walmart.com #13952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on current version of this PR (hash a659d7b)
|
webkit-ews-buildbot
added
the
merging-blocked
youennf
removed
the
merging-blocked
eric-carlson
approved these changes
May 17, 2023
…l"_s) || sdp.contains(" srflx "_s) in walmart.com
https://bugs.webkit.org/show_bug.cgi?id=256854
rdar://109417446
Reviewed by Eric Carlson.
Updated the debug assert to account for relay candidates which can always be exposed.
* Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp:
(WebCore::PeerConnectionBackend::newICECandidate):
Canonical link: https://commits.webkit.org/264155@main
webkit-commit-queue
force-pushed
the
eng/ASSERTION-FAILED-m_shouldFilterICECandidates--sdp-contains-local_s--sdp-contains-srflx-_s-in-walmart-com
branch
from
a659d7b
to
d19ee7d
Compare
|
Committed 264155@main (d19ee7d): https://commits.webkit.org/264155@main Reviewed commits have been landed. Closing PR #13952 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
d19ee7d
ASSERTION FAILED: !m_shouldFilterICECandidates || sdp.contains(".local"_s) || sdp.contains(" srflx "_s) in walmart.com https://bugs.webkit.org/show_bug.cgi?id=256854 rdar://109417446 Reviewed by Eric Carlson. Updated the debug assert to account for relay candidates which can always be exposed. * Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp: (WebCore::PeerConnectionBackend::newICECandidate): Canonical link: https://commits.webkit.org/264155@maina659d7b