Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gardening]: REGRESSION (r293829): [ iOS ] TestWebKitAPI.GPUProcess.WebProcessTerminationAfterTooManyGPUProcessCrashes is a flaky crash #1396

Conversation

karlrackler
Copy link
Contributor

@karlrackler karlrackler commented Jun 8, 2022

0ec524a

[Gardening]: REGRESSION (r293829): [ iOS ] TestWebKitAPI.GPUProcess.WebProcessTerminationAfterTooManyGPUProcessCrashes is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=240692
<rdar://93611089 >

Unreviewed test gardening.
I disabled API test while the issue is being investigated.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm:
(TEST):

Canonical link: https://commits.webkit.org/251410@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@295404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@karlrackler karlrackler self-assigned this Jun 8, 2022
@karlrackler karlrackler added New Bugs Unclassified bugs are placed in this component until the correct component can be determined. WebKit Nightly Build merge-queue Applied to send a pull request to merge-queue labels Jun 8, 2022
@webkit-early-warning-system webkit-early-warning-system added merging-blocked Applied to prevent a change from being merged and removed merge-queue Applied to send a pull request to merge-queue labels Jun 8, 2022
@karlrackler karlrackler removed merging-blocked Applied to prevent a change from being merged New Bugs Unclassified bugs are placed in this component until the correct component can be determined. WebKit Nightly Build labels Jun 8, 2022
@karlrackler karlrackler force-pushed the eng/REGRESSION-r293829--iOS--TestWebKitAPI-GPUProcess-WebProcessTerminationAfterTooManyGPUProcessCrashes-is-a-flaky-crash branch from 1187ad4 to ad0a7e8 Compare June 8, 2022 23:38
@karlrackler karlrackler added New Bugs Unclassified bugs are placed in this component until the correct component can be determined. WebKit Nightly Build merge-queue Applied to send a pull request to merge-queue labels Jun 8, 2022
JonWBedard and others added 4 commits June 8, 2022 23:50
Unreviewed package management.

* Tools/Scripts/libraries/webkitcorepy/setup.py: Bump version.
* Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py: Ditto.

Canonical link: https://commits.webkit.org/251407@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@295401 268f45cc-cd09-0410-ab3c-d52691b4dbfc
…geData

https://bugs.webkit.org/show_bug.cgi?id=241429

Reviewed by Simon Fraser.

It looks the move construct is different on Windows when we pass an xvalue
(such as WTFMove(pixelBuffer)) to a function which takes an lvalue
(such as Ref<JSC::Uint8ClampedArray> data(Ref<ByteArrayPixelBuffer>)). Or it
might be a compiler bug.

So revert the change which converted ByteArrayPixelBuffer::takeData() to
ByteArrayPixelBuffer::data() since it is not related to the fix of bug 240810.

* Source/WebCore/html/ImageData.cpp:
(WebCore::ImageData::create):
* Source/WebCore/platform/graphics/ByteArrayPixelBuffer.cpp:
(WebCore::ByteArrayPixelBuffer::data): Deleted.
* Source/WebCore/platform/graphics/ByteArrayPixelBuffer.h:
(WebCore::ByteArrayPixelBuffer::takeData):

Canonical link: https://commits.webkit.org/251408@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@295402 268f45cc-cd09-0410-ab3c-d52691b4dbfc
…the-audio-api /the-mediaelementaudiosourc enode-interface/mediaElemen tAudioSourceToScriptProcess orTest.html is a flaky text failure

https://bugs.webkit.org/show_bug.cgi?id=221819

Unreviewed test gardening.

* LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/mediaElementAudioSourceToScriptProcessorTest-expected.txt: Removed.

Canonical link: https://commits.webkit.org/251409@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@295403 268f45cc-cd09-0410-ab3c-d52691b4dbfc
…ebProcessTerminationAfterTooManyGPUProcessCrashes is a flaky crash

https://bugs.webkit.org/show_bug.cgi?id=240692
<rdar://93611089>

Unreviewed test gardening.
I disabled API test while the issue is being investigated.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm:
(TEST):

Canonical link: https://commits.webkit.org/251410@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@295404 268f45cc-cd09-0410-ab3c-d52691b4dbfc
@webkit-early-warning-system webkit-early-warning-system merged commit 0ec524a into WebKit:main Jun 9, 2022
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/REGRESSION-r293829--iOS--TestWebKitAPI-GPUProcess-WebProcessTerminationAfterTooManyGPUProcessCrashes-is-a-flaky-crash branch from ad0a7e8 to 0ec524a Compare June 9, 2022 00:37
@webkit-early-warning-system
Copy link
Collaborator

Test gardening commit r295404 (251410@main): https://commits.webkit.org/251410@main

Reviewed commits have been landed. Closing PR #1396 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system removed the merge-queue Applied to send a pull request to merge-queue label Jun 9, 2022
@karlrackler karlrackler deleted the eng/REGRESSION-r293829--iOS--TestWebKitAPI-GPUProcess-WebProcessTerminationAfterTooManyGPUProcessCrashes-is-a-flaky-crash branch June 14, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Bugs Unclassified bugs are placed in this component until the correct component can be determined.
Projects
None yet
5 participants