Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete sandbox rule #13975

Merged
merged 1 commit into from
May 18, 2023
Merged

Remove obsolete sandbox rule #13975

merged 1 commit into from
May 18, 2023

Conversation

pvollan
Copy link
Contributor

@pvollan pvollan commented May 17, 2023 •
edited by webkit-early-warning-system

dd54359

Remove obsolete sandbox rule
https://bugs.webkit.org/show_bug.cgi?id=256909
rdar://109469528

Reviewed by Brent Fulgham.

Remove sandbox rule in WebContent process sandbox on macOS which is obsolete after enabling GPU process on macOS.

* Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:

Canonical link: https://commits.webkit.org/264211@main

51cdf6f

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@pvollan pvollan self-assigned this May 17, 2023
@pvollan pvollan added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label May 17, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 51cdf6f)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

brentfulgham
brentfulgham approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@brentfulgham brentfulgham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pvollan
Copy link
Contributor Author

pvollan commented May 17, 2023

LGTM

Thanks for reviewing!

@pvollan pvollan added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 18, 2023
@pvollan
Remove obsolete sandbox rule
dd54359 
https://bugs.webkit.org/show_bug.cgi?id=256909
rdar://109469528

Reviewed by Brent Fulgham.

Remove sandbox rule in WebContent process sandbox on macOS which is obsolete after enabling GPU process on macOS.

* Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:

Canonical link: https://commits.webkit.org/264211@main
@webkit-commit-queue
Copy link
Collaborator

Committed 264211@main (dd54359): https://commits.webkit.org/264211@main

Reviewed commits have been landed. Closing PR #13975 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit dd54359 into WebKit:main May 18, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentfulgham brentfulgham brentfulgham approved these changes

@geoffreygaren geoffreygaren Awaiting requested review from geoffreygaren

@gavin-apple gavin-apple Awaiting requested review from gavin-apple

Assignees

@pvollan pvollan

Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
Milestone
No milestone
4 participants
@pvollan @webkit-early-warning-system @webkit-commit-queue @brentfulgham