Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLib] Re-enable bwrap sandbox in containers when supported #13985

Merged

Conversation

TingPing
Copy link
Contributor

@TingPing TingPing commented May 17, 2023

@TingPing TingPing requested a review from a team as a code owner May 17, 2023 20:57
@TingPing TingPing self-assigned this May 17, 2023
@TingPing TingPing added the WebKitGTK Bugs related to the Gtk API layer. label May 17, 2023
@TingPing TingPing force-pushed the pgriffis/bwrap-in-containers branch from 44c2f68 to 9b96eaa Compare May 17, 2023 21:02
Source/WTF/wtf/glib/Sandbox.cpp Outdated Show resolved Hide resolved
Source/WTF/wtf/glib/Sandbox.cpp Outdated Show resolved Hide resolved
@TingPing TingPing force-pushed the pgriffis/bwrap-in-containers branch from 9b96eaa to 5dea383 Compare May 17, 2023 22:03
@TingPing TingPing added the merge-queue Applied to send a pull request to merge-queue label May 18, 2023
https://bugs.webkit.org/show_bug.cgi?id=256917

Reviewed by Michael Catanzaro.

This detects if bwrap actually works inside of a container instead
of always disabling it.

* Source/WTF/wtf/glib/Sandbox.cpp:
(WTF::isInsideUnsupportedContainer):
(WTF::isInsideContainer): Deleted.
* Source/WTF/wtf/glib/Sandbox.h:
* Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:
(WebKit::ProcessLauncher::launchProcess):

Canonical link: https://commits.webkit.org/264196@main
@webkit-commit-queue
Copy link
Collaborator

Committed 264196@main (4c39f38): https://commits.webkit.org/264196@main

Reviewed commits have been landed. Closing PR #13985 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 4c39f38 into WebKit:main May 18, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebKitGTK Bugs related to the Gtk API layer.
Projects
None yet
4 participants