New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GLib] Re-enable bwrap sandbox in containers when supported #13985
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
TingPing:pgriffis/bwrap-in-containers
May 18, 2023
Merged
[GLib] Re-enable bwrap sandbox in containers when supported #13985
webkit-commit-queue
merged 1 commit into
WebKit:main
from
TingPing:pgriffis/bwrap-in-containers
May 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EWS run on previous version of this PR (hash 44c2f68) |
TingPing
force-pushed
the
pgriffis/bwrap-in-containers
branch
from
May 17, 2023 21:02
44c2f68
to
9b96eaa
Compare
EWS run on previous version of this PR (hash 9b96eaa) |
mcatanzaro
approved these changes
May 17, 2023
TingPing
force-pushed
the
pgriffis/bwrap-in-containers
branch
from
May 17, 2023 22:03
9b96eaa
to
5dea383
Compare
EWS run on current version of this PR (hash 5dea383) |
https://bugs.webkit.org/show_bug.cgi?id=256917 Reviewed by Michael Catanzaro. This detects if bwrap actually works inside of a container instead of always disabling it. * Source/WTF/wtf/glib/Sandbox.cpp: (WTF::isInsideUnsupportedContainer): (WTF::isInsideContainer): Deleted. * Source/WTF/wtf/glib/Sandbox.h: * Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp: (WebKit::ProcessLauncher::launchProcess): Canonical link: https://commits.webkit.org/264196@main
webkit-commit-queue
force-pushed
the
pgriffis/bwrap-in-containers
branch
from
May 18, 2023 10:36
5dea383
to
4c39f38
Compare
Committed 264196@main (4c39f38): https://commits.webkit.org/264196@main Reviewed commits have been landed. Closing PR #13985 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Applied to send a pull request to merge-queue
label
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4c39f38
5dea383
π§ͺ api-ios