[iOS] Adjust the bindings-exposed screen size in headless browser mode #13998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whsieh
added
the
Platform
|
EWS run on current version of this PR (hash c958a4c)
|
whsieh
requested review from
hortont424,
pxlcoder,
alanbaradlay,
rr-codes and
megangardner
alanbaradlay
approved these changes
May 18, 2023
rr-codes
reviewed
May 18, 2023
| return m_viewportConfiguration.minimumLayoutSize(); | ||
|
|
||
| static constexpr std::array fixedSizes { | ||
| FloatSize { 320, 568 }, |
There was a problem hiding this comment.
Where did these values come from?
There was a problem hiding this comment.
These values represent device metrics from several iPhone models. While somewhat arbitrary, I did make sure to pick the most prevalent width values, by number of models with that width.
|
Thanks for the review! |
https://bugs.webkit.org/show_bug.cgi?id=256939 Reviewed by Alan Baradlay. Add different, platform-specific strategies when returning an appropriate screen size for bindings in headless browsing. See below for more details. Changes covered by a new API test (and adjustments to some existing tests). * Source/WebCore/page/ChromeClient.h: (WebCore::ChromeClient::screenSizeForHeadlessMode const): Add a chrome client hook to return a screen size specifically for "headless mode", given the requesting frame and the actual screen size. * Source/WebCore/page/LocalFrame.cpp: (WebCore::LocalFrame::screenSize const): * Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::screenSizeForHeadlessMode const): Add some plumbing out to `WebPage`. * Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h: * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::screenSizeForHeadlessMode const): Move the logic currently in `LocalFrame::screenSize` over to this method; additionally, instead of trying to counterscale the innerWidth/innerHeight, simply return the unobscured content rect; this does not change with `pageScaleFactor` on macOS, eliminating the need for counterscaling. * Source/WebKit/WebProcess/WebPage/WebPage.h: * Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::screenSizeForHeadlessMode const): Implement an iOS-specific strategy for `screenSizeForHeadlessMode`, returning one of three canned values on iPhone (based on the current user idiom), and falling back to the initial containing block (ignoring the current scale factor, by using `ViewportConfiguration::minimumLayoutSize()`) on iPad. Canonical link: https://commits.webkit.org/264200@main
webkit-commit-queue
force-pushed
the
eng/256939
branch
from
c958a4c
to
e82dfc6
Compare
|
Committed 264200@main (e82dfc6): https://commits.webkit.org/264200@main Reviewed commits have been landed. Closing PR #13998 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e82dfc6
c958a4c