Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return vertical writing mode aware intrinsic information for SVG #14014

Conversation

Ahmad-S792
Copy link
Contributor

@Ahmad-S792 Ahmad-S792 commented May 18, 2023

Return vertical writing mode aware intrinsic information for SVG
https://bugs.webkit.org/show_bug.cgi?id=248769
rdar://problem/103262534

Reviewed by NOBODY (OOPS!).

This patch is to align Webkit with Gecko / Firefox and Blink / Chromium.

Merge (only passing test) - https://chromium.googlesource.com/chromium/blink/+/60af46f13e39be1daacbcdab27c4e7212ae27886

This patch is to make computeIntrinsicRatioInformation function aware of
writing mode by taking the logical values returned into consideration.

This is limited to Legacy SVG and not for LBSE.

* Source/WebCore/rendering/svg/LegacyRenderSVGRoot.cpp:
(LegacyRenderSVGRoot::computeIntrinsicRatioInformation): Add logic to consider "HorizontalWritingMode"
* LayoutTests/svg/in-html/sizing/svg-inline-vertical.html: Add Test Case
* LayoutTests/svg/in-html/sizing/svg-inline-vertical-expected.txt: Add Test Case Expectation

7b21301

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ›  gtk
βœ… πŸ§ͺ ios-wk2-wpt πŸ’₯ πŸ§ͺ mac-wk1 βœ… πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios πŸ’₯ πŸ§ͺ mac-wk2 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv πŸ’₯ πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  tv-sim βœ… πŸ§ͺ mac-wk2-stress
βœ… πŸ›  watch
βœ… πŸ›  watch-sim

@Ahmad-S792 Ahmad-S792 added the SVG For bugs in the SVG implementation. label May 18, 2023
@Ahmad-S792 Ahmad-S792 self-assigned this May 18, 2023
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 18, 2023
@Ahmad-S792 Ahmad-S792 force-pushed the fix248769-partial-fix-but-one-more-test-case branch from 06e5972 to f496479 Compare May 18, 2023 15:11
@Ahmad-S792 Ahmad-S792 removed the merging-blocked Applied to prevent a change from being merged label May 18, 2023
https://bugs.webkit.org/show_bug.cgi?id=248769
rdar://problem/103262534

Reviewed by NOBODY (OOPS!).

This patch is to align Webkit with Gecko / Firefox and Blink / Chromium.

Merge (only passing test) - https://chromium.googlesource.com/chromium/blink/+/60af46f13e39be1daacbcdab27c4e7212ae27886

This patch is to make computeIntrinsicRatioInformation function aware of
writing mode by taking the logical values returned into consideration.

This is limited to Legacy SVG and not for LBSE.

* Source/WebCore/rendering/svg/LegacyRenderSVGRoot.cpp:
(LegacyRenderSVGRoot::computeIntrinsicRatioInformation): Add logic to consider "HorizontalWritingMode"
* LayoutTests/svg/in-html/sizing/svg-inline-vertical.html: Add Test Case
* LayoutTests/svg/in-html/sizing/svg-inline-vertical-expected.txt: Add Test Case Expectation
@Ahmad-S792 Ahmad-S792 force-pushed the fix248769-partial-fix-but-one-more-test-case branch from f496479 to 7b21301 Compare May 18, 2023 15:35
@Ahmad-S792 Ahmad-S792 requested review from smfr and shallawa May 18, 2023 15:38
@Ahmad-S792 Ahmad-S792 marked this pull request as ready for review May 18, 2023 15:38
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 18, 2023
@Ahmad-S792 Ahmad-S792 removed the merging-blocked Applied to prevent a change from being merged label May 18, 2023
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 18, 2023
@Ahmad-S792
Copy link
Contributor Author

Failing test does not even have single svg code in it and EWS is showing that the test didn't had any 'image' (green rect) in Expected but now in Actual, it is showing 'green rect', which is in actual correct result. I am ignoring the failing test (ch-unit-002.html).

@Ahmad-S792 Ahmad-S792 removed the merging-blocked Applied to prevent a change from being merged label May 19, 2023
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 19, 2023
@Ahmad-S792 Ahmad-S792 closed this Jul 23, 2023
@Ahmad-S792 Ahmad-S792 deleted the fix248769-partial-fix-but-one-more-test-case branch August 29, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merging-blocked Applied to prevent a change from being merged SVG For bugs in the SVG implementation.
Projects
None yet
3 participants