New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return vertical writing mode aware intrinsic information for SVG #14014
Return vertical writing mode aware intrinsic information for SVG #14014
Conversation
EWS run on previous version of this PR (hash 06e5972) |
06e5972
to
f496479
Compare
EWS run on previous version of this PR (hash f496479) |
https://bugs.webkit.org/show_bug.cgi?id=248769 rdar://problem/103262534 Reviewed by NOBODY (OOPS!). This patch is to align Webkit with Gecko / Firefox and Blink / Chromium. Merge (only passing test) - https://chromium.googlesource.com/chromium/blink/+/60af46f13e39be1daacbcdab27c4e7212ae27886 This patch is to make computeIntrinsicRatioInformation function aware of writing mode by taking the logical values returned into consideration. This is limited to Legacy SVG and not for LBSE. * Source/WebCore/rendering/svg/LegacyRenderSVGRoot.cpp: (LegacyRenderSVGRoot::computeIntrinsicRatioInformation): Add logic to consider "HorizontalWritingMode" * LayoutTests/svg/in-html/sizing/svg-inline-vertical.html: Add Test Case * LayoutTests/svg/in-html/sizing/svg-inline-vertical-expected.txt: Add Test Case Expectation
f496479
to
7b21301
Compare
EWS run on current version of this PR (hash 7b21301) |
Failing test does not even have single |
7b21301