Make sure we don't leak API::Navigation objects #14023

cdumez · 2023-05-18T17:36:26Z

`9ae6f74`

Make sure we don't leak API::Navigation objects
https://bugs.webkit.org/show_bug.cgi?id=256900
rdar://109430054

Reviewed by Ben Nham.

The lifetime of the API::Navigation objects in the UIProcess is tied to the one
of the WebDocumentLoaders in the WebProcess. The API::Navigation object get
stored on the WebNavigationState::m_navigations HashMap upon creation, keeping
them alive. When the WebDocumentLoader gets detached from its frame, we send a
`DidDestroyNavigation()` IPC to the UIProcess so that we remove the
corresponding navigation from WebNavigationState::m_navigations and stop
extending the API::Navigation lifetime.

The reason the lifetime of navigations is tied to WebDocumentLoaders is that
the original API::Navigation object is reused for some follow-up navigations,
such as same-document navigations.

Since we've added support for process-swapping, this has become leak-prone.
The reason is that a WebPageProxy (and thus a WebNavigationState) is no longer
tied to a single WebProcess. Also, A navigation may start in process A and
then finish in process B.

To avoid leaking, I am adding a ProcessIdentifier data member to API navigation
which is kept up-to-date so that we know which WebProcess currently owns this
object. When a process gets disassociated with a page, we also clear all the
page's navigations that are owned by this process.

* Source/WebKit/UIProcess/API/APINavigation.cpp:
(API::Navigation::Navigation):
* Source/WebKit/UIProcess/API/APINavigation.h:
(API::Navigation::create):
(API::Navigation::processID const):
(API::Navigation::setProcessID):
* Source/WebKit/UIProcess/ProvisionalPageProxy.cpp:
(WebKit::ProvisionalPageProxy::ProvisionalPageProxy):
(WebKit::ProvisionalPageProxy::didDestroyNavigation):
(WebKit::ProvisionalPageProxy::didReceiveMessage):
* Source/WebKit/UIProcess/ProvisionalPageProxy.h:
* Source/WebKit/UIProcess/SuspendedPageProxy.cpp:
(WebKit::messageNamesToIgnoreWhileSuspended):
(WebKit::SuspendedPageProxy::SuspendedPageProxy):
(WebKit::SuspendedPageProxy::~SuspendedPageProxy):
(WebKit::SuspendedPageProxy::didDestroyNavigation):
(WebKit::SuspendedPageProxy::didReceiveMessage):
* Source/WebKit/UIProcess/SuspendedPageProxy.h:
* Source/WebKit/UIProcess/WebNavigationState.cpp:
(WebKit::WebNavigationState::createLoadRequestNavigation):
(WebKit::WebNavigationState::createBackForwardNavigation):
(WebKit::WebNavigationState::createReloadNavigation):
(WebKit::WebNavigationState::createLoadDataNavigation):
(WebKit::WebNavigationState::createSimulatedLoadWithDataNavigation):
(WebKit::WebNavigationState::didDestroyNavigation):
(WebKit::WebNavigationState::clearNavigationsFromProcess):
* Source/WebKit/UIProcess/WebNavigationState.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::launchProcessForReload):
(WebKit::WebPageProxy::loadRequest):
(WebKit::WebPageProxy::loadFile):
(WebKit::WebPageProxy::loadData):
(WebKit::WebPageProxy::loadSimulatedRequest):
(WebKit::WebPageProxy::reload):
(WebKit::WebPageProxy::goToBackForwardItem):
(WebKit::WebPageProxy::continueNavigationInNewProcess):
(WebKit::WebPageProxy::didDestroyNavigation):
(WebKit::WebPageProxy::didDestroyNavigationShared):
(WebKit::WebPageProxy::didSameDocumentNavigationForFrameViaJSHistoryAPI):
(WebKit::WebPageProxy::processIsNoLongerAssociatedWithPage):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::setIsInProcessCache):
(WebKit::WebProcessProxy::removeProvisionalPageProxy):
(WebKit::WebProcessProxy::removeWebPage):
(WebKit::WebProcessProxy::canTerminateAuxiliaryProcess):
(WebKit::WebProcessProxy::addSuspendedPageProxy):
(WebKit::WebProcessProxy::removeSuspendedPageProxy):
(WebKit::WebProcessProxy::reportProcessDisassociatedWithPageIfNecessary):
(WebKit::WebProcessProxy::isAssociatedWithPage const):
(WebKit::WebProcessProxy::incrementSuspendedPageCount): Deleted.
(WebKit::WebProcessProxy::decrementSuspendedPageCount): Deleted.
* Source/WebKit/UIProcess/WebProcessProxy.h:
(WebKit::WebProcessProxy::suspendedPageCount const):
* Source/WebKit/WebProcess/WebPage/WebDocumentLoader.cpp:
(WebKit::WebDocumentLoader::WebDocumentLoader):
(WebKit::WebDocumentLoader::~WebDocumentLoader):
* Source/WebKit/WebProcess/WebPage/WebDocumentLoader.h:

Canonical link: https://commits.webkit.org/264449@main

440e7cf

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
✅ 🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-05-18T17:36:38Z

EWS run on previous version of this PR (hash a6af749)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🧪 api-mac	✅ 🛠 gtk
	~~🧪 ios-wk2-wpt~~		⏳ 🧪 gtk-wk2
	~~🧪 api-ios~~	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-05-18T18:34:52Z

EWS run on previous version of this PR (hash 83fb25f)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	✅ 🛠 gtk
	⏳ 🧪 ios-wk2-wpt		⏳ 🧪 gtk-wk2
	⏳ 🧪 api-ios	~~🧪 mac-wk2~~	✅ 🧪 api-gtk
	✅ 🛠 tv	⏳ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-05-18T19:25:53Z

EWS run on previous version of this PR (hash 267f9e8)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt		✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-05-19T02:18:06Z

EWS run on previous version of this PR (hash e3b2632)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch		✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

achristensen07

Needs a test. An autoreleasepool and a weak objc pointer should be able to show the change.

Source/WebKit/UIProcess/WebNavigationState.cpp

cdumez · 2023-05-19T15:59:49Z

Source/WebKit/UIProcess/WebPageProxy.cpp


-    // On process-swap, the previous process tries to destroy the navigation but the provisional process is actually taking over the navigation.
-    if (m_provisionalPage && m_provisionalPage->navigationID() == navigationID)


See the previous hack we use to have here to ignore the DidDestroyNavigation IPC from the old process when we swap.

bnham

Seems reasonable to me, approved pending the test case being written.

webkit-early-warning-system · 2023-05-19T19:14:41Z

EWS run on previous version of this PR (hash b950e09)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	~~🛠 ios~~	⏳ 🛠 mac	~~🛠 wpe~~	⏳ 🛠 wincairo
⏳ 🧪 bindings	⏳ 🛠 ios-sim	⏳ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
⏳ 🧪 webkitperl	⏳ 🧪 ios-wk2	⏳ 🧪 api-mac	~~🛠 gtk~~
⏳ 🧪 webkitpy	⏳ 🧪 ios-wk2-wpt	⏳ 🧪 mac-wk1	~~🧪 gtk-wk2~~
⏳ 🛠 🧪 jsc	⏳ 🧪 api-ios	⏳ 🧪 mac-wk2	~~🧪 api-gtk~~
⏳ 🛠 🧪 jsc-arm64	⏳ 🛠 tv	⏳ 🧪 mac-AS-debug-wk2	⏳ 🛠 jsc-armv7
	⏳ 🛠 tv-sim	⏳ 🧪 mac-wk2-stress	⏳ 🧪 jsc-armv7-tests
	⏳ 🛠 watch		⏳ 🛠 jsc-mips
	⏳ 🛠 watch-sim		⏳ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-05-19T19:20:14Z

EWS run on previous version of this PR (hash b638c48)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	❌ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	❌ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-05-22T17:10:39Z

EWS run on previous version of this PR (hash e438fc7)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	❌ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	~~🧪 api-ios~~	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

cdumez · 2023-05-22T23:47:12Z

The API tests passes locally but fails on EWS, I am not sure why. This is my second version of the API test and it still fails :/
At this point, I may need to introduce an SPI that exposes the number of Navigation objects in the WebNavigationState HashMap instead of relying on the WKNavigation object getting destroyed.

webkit-early-warning-system · 2023-05-23T02:30:02Z

EWS run on previous version of this PR (hash f82e6d2)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	~~🧪 api-mac~~	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	~~🧪 api-ios~~	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

cdumez · 2023-05-23T19:43:07Z

I think I finally found why the API test is failing on EWS. I'll get it fixed shortly.

webkit-early-warning-system · 2023-05-23T20:38:57Z

EWS run on current version of this PR (hash 440e7cf)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
✅ 🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

https://bugs.webkit.org/show_bug.cgi?id=256900 rdar://109430054 Reviewed by Ben Nham. The lifetime of the API::Navigation objects in the UIProcess is tied to the one of the WebDocumentLoaders in the WebProcess. The API::Navigation object get stored on the WebNavigationState::m_navigations HashMap upon creation, keeping them alive. When the WebDocumentLoader gets detached from its frame, we send a `DidDestroyNavigation()` IPC to the UIProcess so that we remove the corresponding navigation from WebNavigationState::m_navigations and stop extending the API::Navigation lifetime. The reason the lifetime of navigations is tied to WebDocumentLoaders is that the original API::Navigation object is reused for some follow-up navigations, such as same-document navigations. Since we've added support for process-swapping, this has become leak-prone. The reason is that a WebPageProxy (and thus a WebNavigationState) is no longer tied to a single WebProcess. Also, A navigation may start in process A and then finish in process B. To avoid leaking, I am adding a ProcessIdentifier data member to API navigation which is kept up-to-date so that we know which WebProcess currently owns this object. When a process gets disassociated with a page, we also clear all the page's navigations that are owned by this process. * Source/WebKit/UIProcess/API/APINavigation.cpp: (API::Navigation::Navigation): * Source/WebKit/UIProcess/API/APINavigation.h: (API::Navigation::create): (API::Navigation::processID const): (API::Navigation::setProcessID): * Source/WebKit/UIProcess/ProvisionalPageProxy.cpp: (WebKit::ProvisionalPageProxy::ProvisionalPageProxy): (WebKit::ProvisionalPageProxy::didDestroyNavigation): (WebKit::ProvisionalPageProxy::didReceiveMessage): * Source/WebKit/UIProcess/ProvisionalPageProxy.h: * Source/WebKit/UIProcess/SuspendedPageProxy.cpp: (WebKit::messageNamesToIgnoreWhileSuspended): (WebKit::SuspendedPageProxy::SuspendedPageProxy): (WebKit::SuspendedPageProxy::~SuspendedPageProxy): (WebKit::SuspendedPageProxy::didDestroyNavigation): (WebKit::SuspendedPageProxy::didReceiveMessage): * Source/WebKit/UIProcess/SuspendedPageProxy.h: * Source/WebKit/UIProcess/WebNavigationState.cpp: (WebKit::WebNavigationState::createLoadRequestNavigation): (WebKit::WebNavigationState::createBackForwardNavigation): (WebKit::WebNavigationState::createReloadNavigation): (WebKit::WebNavigationState::createLoadDataNavigation): (WebKit::WebNavigationState::createSimulatedLoadWithDataNavigation): (WebKit::WebNavigationState::didDestroyNavigation): (WebKit::WebNavigationState::clearNavigationsFromProcess): * Source/WebKit/UIProcess/WebNavigationState.h: * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::launchProcessForReload): (WebKit::WebPageProxy::loadRequest): (WebKit::WebPageProxy::loadFile): (WebKit::WebPageProxy::loadData): (WebKit::WebPageProxy::loadSimulatedRequest): (WebKit::WebPageProxy::reload): (WebKit::WebPageProxy::goToBackForwardItem): (WebKit::WebPageProxy::continueNavigationInNewProcess): (WebKit::WebPageProxy::didDestroyNavigation): (WebKit::WebPageProxy::didDestroyNavigationShared): (WebKit::WebPageProxy::didSameDocumentNavigationForFrameViaJSHistoryAPI): (WebKit::WebPageProxy::processIsNoLongerAssociatedWithPage): (WebKit::WebPageProxy::decidePolicyForNavigationAction): * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::setIsInProcessCache): (WebKit::WebProcessProxy::removeProvisionalPageProxy): (WebKit::WebProcessProxy::removeWebPage): (WebKit::WebProcessProxy::canTerminateAuxiliaryProcess): (WebKit::WebProcessProxy::addSuspendedPageProxy): (WebKit::WebProcessProxy::removeSuspendedPageProxy): (WebKit::WebProcessProxy::reportProcessDisassociatedWithPageIfNecessary): (WebKit::WebProcessProxy::isAssociatedWithPage const): (WebKit::WebProcessProxy::incrementSuspendedPageCount): Deleted. (WebKit::WebProcessProxy::decrementSuspendedPageCount): Deleted. * Source/WebKit/UIProcess/WebProcessProxy.h: (WebKit::WebProcessProxy::suspendedPageCount const): * Source/WebKit/WebProcess/WebPage/WebDocumentLoader.cpp: (WebKit::WebDocumentLoader::WebDocumentLoader): (WebKit::WebDocumentLoader::~WebDocumentLoader): * Source/WebKit/WebProcess/WebPage/WebDocumentLoader.h: Canonical link: https://commits.webkit.org/264449@main

webkit-commit-queue · 2023-05-24T02:17:48Z

Committed 264449@main (9ae6f74): https://commits.webkit.org/264449@main

Reviewed commits have been landed. Closing PR #14023 and removing active labels.

cdumez self-assigned this May 18, 2023

cdumez added the WebKit2 Bugs relating to the WebKit2 API layer label May 18, 2023

cdumez force-pushed the 256900_API_Navigation_leak branch from a6af749 to 83fb25f Compare May 18, 2023 18:34

cdumez force-pushed the 256900_API_Navigation_leak branch from 83fb25f to 267f9e8 Compare May 18, 2023 19:25

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 19, 2023

cdumez removed the merging-blocked Applied to prevent a change from being merged label May 19, 2023

cdumez force-pushed the 256900_API_Navigation_leak branch from 267f9e8 to e3b2632 Compare May 19, 2023 02:17

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 19, 2023

cdumez removed the merging-blocked Applied to prevent a change from being merged label May 19, 2023

cdumez requested a review from achristensen07 May 19, 2023 14:31

cdumez marked this pull request as ready for review May 19, 2023 14:31

cdumez requested a review from bnham May 19, 2023 14:31

cdumez mentioned this pull request May 19, 2023

Removing Navigation objects from WebNavigationState when the navigation completes #13964

Closed

achristensen07 reviewed May 19, 2023

View reviewed changes

Source/WebKit/UIProcess/WebNavigationState.cpp Show resolved Hide resolved

cdumez commented May 19, 2023

View reviewed changes

bnham approved these changes May 19, 2023

View reviewed changes

cdumez force-pushed the 256900_API_Navigation_leak branch from e3b2632 to b950e09 Compare May 19, 2023 19:14

cdumez force-pushed the 256900_API_Navigation_leak branch from b950e09 to b638c48 Compare May 19, 2023 19:15

cdumez force-pushed the 256900_API_Navigation_leak branch from b638c48 to e438fc7 Compare May 22, 2023 17:09

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 22, 2023

cdumez removed the merging-blocked Applied to prevent a change from being merged label May 23, 2023

cdumez force-pushed the 256900_API_Navigation_leak branch from e438fc7 to f82e6d2 Compare May 23, 2023 02:27

cdumez force-pushed the 256900_API_Navigation_leak branch from f82e6d2 to 440e7cf Compare May 23, 2023 20:18

cdumez added the merge-queue Applied to send a pull request to merge-queue label May 24, 2023

webkit-commit-queue force-pushed the 256900_API_Navigation_leak branch from 440e7cf to 9ae6f74 Compare May 24, 2023 02:17

webkit-commit-queue merged commit 9ae6f74 into WebKit:main May 24, 2023

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label May 24, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make sure we don't leak API::Navigation objects #14023

Make sure we don't leak API::Navigation objects #14023

cdumez commented May 18, 2023 •

edited by webkit-early-warning-system

webkit-early-warning-system commented May 18, 2023 •

edited

webkit-early-warning-system commented May 18, 2023 •

edited

webkit-early-warning-system commented May 18, 2023 •

edited

webkit-early-warning-system commented May 19, 2023 •

edited

achristensen07 left a comment

cdumez May 19, 2023

bnham left a comment

webkit-early-warning-system commented May 19, 2023 •

edited

webkit-early-warning-system commented May 19, 2023 •

edited

webkit-early-warning-system commented May 22, 2023 •

edited

cdumez commented May 22, 2023

webkit-early-warning-system commented May 23, 2023 •

edited

cdumez commented May 23, 2023

webkit-early-warning-system commented May 23, 2023 •

edited

webkit-commit-queue commented May 24, 2023


		// On process-swap, the previous process tries to destroy the navigation but the provisional process is actually taking over the navigation.
		if (m_provisionalPage && m_provisionalPage->navigationID() == navigationID)

Make sure we don't leak API::Navigation objects #14023

Make sure we don't leak API::Navigation objects #14023

Conversation

cdumez commented May 18, 2023 • edited by webkit-early-warning-system

9ae6f74

webkit-early-warning-system commented May 18, 2023 • edited

webkit-early-warning-system commented May 18, 2023 • edited

webkit-early-warning-system commented May 18, 2023 • edited

webkit-early-warning-system commented May 19, 2023 • edited

achristensen07 left a comment

Choose a reason for hiding this comment

cdumez May 19, 2023

Choose a reason for hiding this comment

bnham left a comment

Choose a reason for hiding this comment

webkit-early-warning-system commented May 19, 2023 • edited

webkit-early-warning-system commented May 19, 2023 • edited

webkit-early-warning-system commented May 22, 2023 • edited

cdumez commented May 22, 2023

webkit-early-warning-system commented May 23, 2023 • edited

cdumez commented May 23, 2023

webkit-early-warning-system commented May 23, 2023 • edited

webkit-commit-queue commented May 24, 2023

cdumez commented May 18, 2023 •

edited by webkit-early-warning-system

`9ae6f74`

webkit-early-warning-system commented May 18, 2023 •

edited

webkit-early-warning-system commented May 18, 2023 •

edited

webkit-early-warning-system commented May 18, 2023 •

edited

webkit-early-warning-system commented May 19, 2023 •

edited

webkit-early-warning-system commented May 19, 2023 •

edited

webkit-early-warning-system commented May 19, 2023 •

edited

webkit-early-warning-system commented May 22, 2023 •

edited

webkit-early-warning-system commented May 23, 2023 •

edited

webkit-early-warning-system commented May 23, 2023 •

edited