Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Quirk shouldDisableLazyImageLoading for Ikea.com #14058

Merged
merged 1 commit into from
May 19, 2023

Conversation

karlcow
Copy link
Member

@karlcow karlcow commented May 19, 2023

8113b3e

Remove Quirk shouldDisableLazyImageLoading for Ikea.com
https://bugs.webkit.org/show_bug.cgi?id=257007
rdar://109547199

Reviewed by Chris Dumez.

Removes the lazy images loading necessary for Ikea. The Ikea Web
team has fixed their code and the images are now loading into
Safari without issues. This also re-enable the normal preference
setting for disabling/enabling Lazy Image loading.

* Source/WebCore/dom/Document.cpp:
(WebCore::Document::lazyImageLoadingEnabled const): Deleted.
* Source/WebCore/dom/Document.h:
* Source/WebCore/html/HTMLImageElement.idl:
* Source/WebCore/html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):
* Source/WebCore/loader/ImageLoader.cpp:
(WebCore::ImageLoader::updateFromElement):
* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::shouldDisableLazyImageLoadingQuirk const): Deleted.
* Source/WebCore/page/Quirks.h:

Canonical link: https://commits.webkit.org/264260@main

4e2f952

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ›  gtk
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1 βœ… πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  tv-sim
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch
βœ… πŸ›  watch-sim

@karlcow karlcow requested review from cdumez and rniwa as code owners May 19, 2023 04:01
@karlcow karlcow self-assigned this May 19, 2023
@karlcow karlcow added the WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). label May 19, 2023
@stwrt
Copy link
Member

stwrt commented May 19, 2023

Just tested the site out and it works without the quirk.

@stwrt
Copy link
Member

stwrt commented May 19, 2023

IKEA upgraded their Gatsby version to 5.7.0.

Copy link
Member

@stwrt stwrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Need someone else to approve.

@stwrt stwrt requested a review from brentfulgham May 19, 2023 15:03
Copy link
Contributor

@cdumez cdumez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cdumez cdumez added the merge-queue Applied to send a pull request to merge-queue label May 19, 2023
https://bugs.webkit.org/show_bug.cgi?id=257007
rdar://109547199

Reviewed by Chris Dumez.

Removes the lazy images loading necessary for Ikea. The Ikea Web
team has fixed their code and the images are now loading into
Safari without issues. This also re-enable the normal preference
setting for disabling/enabling Lazy Image loading.

* Source/WebCore/dom/Document.cpp:
(WebCore::Document::lazyImageLoadingEnabled const): Deleted.
* Source/WebCore/dom/Document.h:
* Source/WebCore/html/HTMLImageElement.idl:
* Source/WebCore/html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):
* Source/WebCore/loader/ImageLoader.cpp:
(WebCore::ImageLoader::updateFromElement):
* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::shouldDisableLazyImageLoadingQuirk const): Deleted.
* Source/WebCore/page/Quirks.h:

Canonical link: https://commits.webkit.org/264260@main
@webkit-commit-queue
Copy link
Collaborator

Committed 264260@main (8113b3e): https://commits.webkit.org/264260@main

Reviewed commits have been landed. Closing PR #14058 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 8113b3e into WebKit:main May 19, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).
Projects
None yet
5 participants