-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Quirk shouldDisableLazyImageLoading for Ikea.com #14058
Conversation
EWS run on current version of this PR (hash 4e2f952) |
Just tested the site out and it works without the quirk. |
IKEA upgraded their Gatsby version to 5.7.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. Need someone else to approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
https://bugs.webkit.org/show_bug.cgi?id=257007 rdar://109547199 Reviewed by Chris Dumez. Removes the lazy images loading necessary for Ikea. The Ikea Web team has fixed their code and the images are now loading into Safari without issues. This also re-enable the normal preference setting for disabling/enabling Lazy Image loading. * Source/WebCore/dom/Document.cpp: (WebCore::Document::lazyImageLoadingEnabled const): Deleted. * Source/WebCore/dom/Document.h: * Source/WebCore/html/HTMLImageElement.idl: * Source/WebCore/html/parser/HTMLPreloadScanner.cpp: (WebCore::TokenPreloadScanner::StartTagScanner::processAttribute): * Source/WebCore/loader/ImageLoader.cpp: (WebCore::ImageLoader::updateFromElement): * Source/WebCore/page/Quirks.cpp: (WebCore::Quirks::shouldDisableLazyImageLoadingQuirk const): Deleted. * Source/WebCore/page/Quirks.h: Canonical link: https://commits.webkit.org/264260@main
4e2f952
to
8113b3e
Compare
Committed 264260@main (8113b3e): https://commits.webkit.org/264260@main Reviewed commits have been landed. Closing PR #14058 and removing active labels. |
8113b3e
4e2f952