Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MiniBrowser] Sync user agents with Web Inspector #14072

Merged
merged 1 commit into from May 19, 2023

Conversation

aprotyas
Copy link
Member

@aprotyas aprotyas commented May 19, 2023

f9d239b

[MiniBrowser] Sync user agents with Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=257012
rdar://109555783

Reviewed by Aditya Keerthi.

The current set of user agent strings in MiniBrowser is quite outdated,
which can make testing on (some) websites inconvenient.

In this patch, we sync the user agent strings in MiniBrowser with those
in Web Inspector, where Safari 16.4 (and contemporary major browser
vendors) user agents were recently upstreamed in Web Inspector (263319@main).

* Tools/MiniBrowser/mac/SettingsController.m:
(+[SettingsController userAgentData]):

Canonical link: https://commits.webkit.org/264269@main

27cdf18

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ›  gtk
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1 ❌ πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  tv-sim
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch
βœ… πŸ›  watch-sim

@aprotyas aprotyas self-assigned this May 19, 2023
@aprotyas aprotyas added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label May 19, 2023
@Ahmad-S792
Copy link
Contributor

@aprotyas - I hope this fix annoying codepen captcha issue on MiniBrowser. Thanks for looking into it.

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 19, 2023
@aprotyas aprotyas marked this pull request as ready for review May 19, 2023 18:16
@aprotyas aprotyas requested a review from JonWBedard as a code owner May 19, 2023 18:16
@pxlcoder pxlcoder added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels May 19, 2023
https://bugs.webkit.org/show_bug.cgi?id=257012
rdar://109555783

Reviewed by Aditya Keerthi.

The current set of user agent strings in MiniBrowser is quite outdated,
which can make testing on (some) websites inconvenient.

In this patch, we sync the user agent strings in MiniBrowser with those
in Web Inspector, where Safari 16.4 (and contemporary major browser
vendors) user agents were recently upstreamed in Web Inspector (263319@main).

* Tools/MiniBrowser/mac/SettingsController.m:
(+[SettingsController userAgentData]):

Canonical link: https://commits.webkit.org/264269@main
@webkit-commit-queue
Copy link
Collaborator

Committed 264269@main (f9d239b): https://commits.webkit.org/264269@main

Reviewed commits have been landed. Closing PR #14072 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit f9d239b into WebKit:main May 19, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label May 19, 2023
@aprotyas aprotyas deleted the eng/257012 branch May 19, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
6 participants