[WebGPU] Incorrect default value for GPUPrimitiveState.topology #14074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on previous version of this PR (hash 9cc9e0e)
|
webkit-ews-buildbot
added
the
merging-blocked
litherum
approved these changes
May 19, 2023
tadeuzagallo
added
merge-queue
tadeuzagallo
force-pushed
the
eng/WebGPU-Incorrect-default-value-for-GPUPrimitiveState-topology
branch
from
9cc9e0e
to
0695377
Compare
|
EWS run on current version of this PR (hash 0695377)
|
tadeuzagallo
added
merge-queue
webkit-commit-queue
force-pushed
the
eng/WebGPU-Incorrect-default-value-for-GPUPrimitiveState-topology
branch
from
0695377
to
e51cf6c
Compare
https://bugs.webkit.org/show_bug.cgi?id=257024 rdar://109564272 Reviewed by Myles C. Maxfield. Although the IDL has the correct default value, while converting between PAL::WebGPU::RenderPipelineDescriptor and WGPURenderPipelineDescriptor, we set the topology to `point-list` when not explicitly specified. * Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUDeviceImpl.cpp: (PAL::WebGPU::convertToBacking): Canonical link: https://commits.webkit.org/264318@main
webkit-commit-queue
force-pushed
the
eng/WebGPU-Incorrect-default-value-for-GPUPrimitiveState-topology
branch
from
e51cf6c
to
3aa8c01
Compare
|
Committed 264318@main (3aa8c01): https://commits.webkit.org/264318@main Reviewed commits have been landed. Closing PR #14074 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3aa8c01
0695377
🧪 gtk-wk2🧪 api-ios🧪 mac-AS-debug-wk2