Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WGSL] Add support for private global variables #14080

Conversation

tadeuzagallo
Copy link
Member

@tadeuzagallo tadeuzagallo commented May 19, 2023

acbaa4f

[WGSL] Add support for private global variables
https://bugs.webkit.org/show_bug.cgi?id=257034
rdar://109565923

Reviewed by Myles C. Maxfield.

Previously we only support global resources, this is the first iteration for
supporting global variables in the `private` address space.

* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
(WGSL::RewriteGlobalVariables::visitEntryPoint):
(WGSL::RewriteGlobalVariables::determineUsedGlobals):
(WGSL::RewriteGlobalVariables::insertStructs):
(WGSL::RewriteGlobalVariables::insertParameters):
(WGSL::RewriteGlobalVariables::insertLocalDefinitions):

Canonical link: https://commits.webkit.org/264315@main

d036b4d

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ›  gtk
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  tv-sim
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch
βœ… πŸ›  watch-sim

@tadeuzagallo tadeuzagallo self-assigned this May 19, 2023
@tadeuzagallo tadeuzagallo added the WebGPU For bugs in WebGPU label May 19, 2023
@tadeuzagallo tadeuzagallo added the merge-queue Applied to send a pull request to merge-queue label May 22, 2023
https://bugs.webkit.org/show_bug.cgi?id=257034
rdar://109565923

Reviewed by Myles C. Maxfield.

Previously we only support global resources, this is the first iteration for
supporting global variables in the `private` address space.

* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
(WGSL::RewriteGlobalVariables::visitEntryPoint):
(WGSL::RewriteGlobalVariables::determineUsedGlobals):
(WGSL::RewriteGlobalVariables::insertStructs):
(WGSL::RewriteGlobalVariables::insertParameters):
(WGSL::RewriteGlobalVariables::insertLocalDefinitions):

Canonical link: https://commits.webkit.org/264315@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WGSL-Add-support-for-private-global-variables branch from d036b4d to acbaa4f Compare May 22, 2023 07:16
@webkit-commit-queue
Copy link
Collaborator

Committed 264315@main (acbaa4f): https://commits.webkit.org/264315@main

Reviewed commits have been landed. Closing PR #14080 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit acbaa4f into WebKit:main May 22, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebGPU For bugs in WebGPU
Projects
None yet
4 participants