[SVG] animateMotion accumulate doesn't work properly with rotate: auto / auto-reverse #14149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on previous version of this PR (hash 91ad570)
|
webkit-ews-buildbot
added
the
merging-blocked
Ahmad-S792
force-pushed
the
fix256928-svg-animation-case
branch
from
91ad570
to
3d35f27
Compare
Ahmad-S792
removed
the
merging-blocked
Ahmad-S792
force-pushed
the
fix256928-svg-animation-case
branch
from
3d35f27
to
b784c86
Compare
|
EWS run on previous version of this PR (hash b784c86)
|
|
EWS run on previous version of this PR (hash 3d35f27)
|
webkit-ews-buildbot
added
the
merging-blocked
Ahmad-S792
added
request-merge-queue
smfr
approved these changes
May 26, 2023
Ahmad-S792
force-pushed
the
fix256928-svg-animation-case
branch
from
b784c86
to
9460ac3
Compare
Ahmad-S792
added
unsafe-merge-queue
|
EWS run on current version of this PR (hash 9460ac3)
|
…o / auto-reverse https://bugs.webkit.org/show_bug.cgi?id=256928 rdar://problem/109489241 Reviewed by Simon Fraser. This patch aligns WebKit behavior with Gecko / Firefox and Blink / Chromium. Merge: https://src.chromium.org/viewvc/blink?view=revision&revision=154375 We need not accumulate the angle for animation as we have a method to get normal angle at a given length on the path. So, only position needs to be accumulated. Also made some changes to simplify the logic for accumulation. * Source/WebCore/svg/SVGAnimateMotionElement.cpp: (SVGAnimateMotionElement::buildTransformForProgress): Remove 'angle' accumulation from here (SVGAnimateMotionElement::calculateAnimatedValue): Move here * LayoutTests/svg/animations/animateMotion-accumulate-1a.svg: Add Test Case * LayoutTests/svg/animations/animateMotion-accumulate-1a-expected.svg: Add Test Case Expectation * LayoutTests/svg/animations/animateMotion-accumulate-1b.svg: Add Test Case * LayoutTests/svg/animations/animateMotion-accumulate-1b-expected.svg: Add Test Case Expectation * LayoutTests/svg/animations/animateMotion-accumulate-1c.svg: Add Test Case * LayoutTests/svg/animations/animateMotion-accumulate-1c-expected.svg: Add Test Case Expectation * LayoutTests/svg/animations/animateMotion-accumulate-2a.svg: Add Test Case * LayoutTests/svg/animations/animateMotion-accumulate-2a-expected.svg: Add Test Case Expectation * LayoutTests/svg/animations/animateMotion-accumulate-2b.svg: Add Test Case * LayoutTests/svg/animations/animateMotion-accumulate-2b-expected.svg: Add Test Case Expectation All tests have slight pixel tolerances to accommodate for platform differences. Canonical link: https://commits.webkit.org/264595@main
webkit-commit-queue
changed the title
webkit-commit-queue
force-pushed
the
fix256928-svg-animation-case
branch
from
9460ac3
to
b3b7524
Compare
|
Committed 264595@main (b3b7524): https://commits.webkit.org/264595@main Reviewed commits have been landed. Closing PR #14149 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b3b7524
9460ac3
🛠 wpe🛠 wincairo🧪 wpe-wk2🧪 ios-wk2🧪 api-mac🛠 gtk🧪 ios-wk2-wpt🧪 mac-wk1🧪 gtk-wk2🧪 api-ios🧪 mac-wk2🧪 api-gtk🧪 mac-AS-debug-wk2🛠 tv-sim🛠 watch🛠 watch-sim