-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull out LazyLineBreakIterator's prior context handling into a separate class #14169
Pull out LazyLineBreakIterator's prior context handling into a separate class #14169
Conversation
EWS run on previous version of this PR (hash dc0e4a2) |
dc0e4a2
to
a533a27
Compare
a533a27
to
58638dc
Compare
EWS run on previous version of this PR (hash 58638dc)
|
This comment was marked as outdated.
This comment was marked as outdated.
58638dc
to
cca0ce9
Compare
EWS run on current version of this PR (hash cca0ce9)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me
β¦te class https://bugs.webkit.org/show_bug.cgi?id=257115 rdar://109646131 Reviewed by Yusuke Suzuki. LazyLineBreakIterator is really a factory, which holds the necessary parameters to create line break iterators. But, it also has a bunch of handling for a "prior context" which is conceptually a prefix to the string being broken. This patch isn't strictly necessary, but I thought it would be a bit more elegant to have a class separation between the two pieces of LazyLineBreakIterator. * Source/WTF/wtf/text/TextBreakIterator.h: (WTF::LazyLineBreakIterator::PriorContext::PriorContext): (WTF::LazyLineBreakIterator::PriorContext::lastCharacter const): (WTF::LazyLineBreakIterator::PriorContext::secondToLastCharacter const): (WTF::LazyLineBreakIterator::PriorContext::set): (WTF::LazyLineBreakIterator::PriorContext::update): (WTF::LazyLineBreakIterator::PriorContext::reset): (WTF::LazyLineBreakIterator::PriorContext::length const): (WTF::LazyLineBreakIterator::PriorContext::characters const): (WTF::LazyLineBreakIterator::LazyLineBreakIterator): (WTF::LazyLineBreakIterator::get): (WTF::LazyLineBreakIterator::resetStringAndReleaseIterator): (WTF::LazyLineBreakIterator::priorContext const): (WTF::LazyLineBreakIterator::priorContext): (WTF::TextBreakIteratorCache::TextBreakIteratorCache): Deleted. (WTF::LazyLineBreakIterator::lastCharacter const): Deleted. (WTF::LazyLineBreakIterator::secondToLastCharacter const): Deleted. (WTF::LazyLineBreakIterator::setPriorContext): Deleted. (WTF::LazyLineBreakIterator::updatePriorContext): Deleted. (WTF::LazyLineBreakIterator::resetPriorContext): Deleted. (WTF::LazyLineBreakIterator::priorContextLength const): Deleted. * Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp: (WebCore::Layout::endsWithSoftWrapOpportunity): * Source/WebCore/rendering/BreakLines.h: (WebCore::nextBreakablePosition): * Source/WebCore/rendering/LegacyLineLayout.cpp: (WebCore::LegacyLineLayout::layoutRunsAndFloatsInRange): * Source/WebCore/rendering/RenderRubyBase.cpp: (WebCore::RenderRubyBase::cachePriorCharactersIfNeeded): * Source/WebCore/rendering/RenderRubyRun.cpp: (WebCore::RenderRubyRun::updatePriorContextFromCachedBreakIterator const): * Source/WebCore/rendering/RenderRubyText.cpp: (WebCore::RenderRubyText::canBreakBefore const): * Source/WebCore/rendering/line/BreakingContext.h: (WebCore::BreakingContext::handleOutOfFlowPositioned): (WebCore::BreakingContext::handleFloat): (WebCore::BreakingContext::handleReplaced): (WebCore::BreakingContext::handleText): Canonical link: https://commits.webkit.org/264444@main
cca0ce9
to
b5583c5
Compare
Committed 264444@main (b5583c5): https://commits.webkit.org/264444@main Reviewed commits have been landed. Closing PR #14169 and removing active labels. |
b5583c5
cca0ce9
π§ͺ ios-wk2π§ͺ ios-wk2-wptπ§ͺ api-ios