[WebXR] Refactor WebXROpaqueFramebuffer::setupFramebuffer #14172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on previous version of this PR (hash f12f4ac)
|
webkit-ews-buildbot
added
the
merging-blocked
grorg
reviewed
May 22, 2023
| // Cap the maximum multisample count at 4. Any more than this is likely overkill and will impact performance. | ||
| return std::min(4, maxSampleCount); | ||
| }; | ||
| int sampleCount = (isAntialias) ? maxSamples(gl) : 0; |
There was a problem hiding this comment.
We can probably assign sampleCount to directly calling the lambda immediately. We only use sampleCount if we're antialiased.
grorg
reviewed
May 22, 2023
| } | ||
| return gl.checkFramebufferStatus(GL::FRAMEBUFFER) == GL::FRAMEBUFFER_COMPLETE; | ||
| auto colorBuffer = allocateColorStorage(gl, sampleCount, m_width, m_height); | ||
| bindColor(gl, colorBuffer); |
There was a problem hiding this comment.
Maybe this should be bindColorBuffer
grorg
reviewed
May 22, 2023
| PlatformGLObject depthBuffer = 0; | ||
| PlatformGLObject stencilBuffer = 0; | ||
|
|
||
| // FIXME: Does this need to be optional? |
There was a problem hiding this comment.
I think there are some non-Apple implementations that don't support the packed format.
There was a problem hiding this comment.
This code was moved and pre-existed. I've added a // FIXME: that we should do something depending upon context or remove the code.
grorg
approved these changes
May 22, 2023
djg
changed the title
djg
force-pushed
the
webxr/refactor-setup-framebuffer
branch
from
f12f4ac
to
ff55789
Compare
|
EWS run on current version of this PR (hash ff55789) |
|
EWS run on previous version of this PR (hash ff55789)
|
webkit-ews-buildbot
added
the
merging-blocked
djg
changed the title
djg
force-pushed
the
webxr/refactor-setup-framebuffer
branch
from
ff55789
to
3d87b20
Compare
|
EWS run on current version of this PR (hash 3d87b20)
|
djg
added
merge-queue
https://bugs.webkit.org/show_bug.cgi?id=257117 rdar://problem/109647523 Reviewed by Dean Jackson. Reduce the complicated nesting of if/else statement by extracting common parts into helper functions. No features changed. * LayoutTests/platform/wpe/imported/w3c/web-platform-tests/webxr/xrWebGLLayer_framebuffer_draw.https-expected.txt: * LayoutTests/platform/wpe/imported/w3c/web-platform-tests/webxr/xrWebGLLayer_opaque_framebuffer.https-expected.txt: * Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp: (WebCore::WebXROpaqueFramebuffer::setupFramebuffer): (WebCore::WebXROpaqueFramebuffer::allocateRenderbufferStorage): (WebCore::WebXROpaqueFramebuffer::allocateColorStorage): (WebCore::WebXROpaqueFramebuffer::allocateDepthStencilStorage): (WebCore::WebXROpaqueFramebuffer::bindColor): (WebCore::WebXROpaqueFramebuffer::bindDepthStencil): * Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.h: * Source/WebCore/platform/graphics/GraphicsContextGL.h: Canonical link: https://commits.webkit.org/264466@main
webkit-commit-queue
force-pushed
the
webxr/refactor-setup-framebuffer
branch
from
3d87b20
to
12c38ed
Compare
|
Committed 264466@main (12c38ed): https://commits.webkit.org/264466@main Reviewed commits have been landed. Closing PR #14172 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
12c38ed
3d87b20
🧪 style🛠 ios🛠 mac🧪 bindings🛠 ios-sim🛠 mac-AS-debug🧪 webkitperl🧪 ios-wk2🧪 api-mac🛠 gtk🧪 ios-wk2-wpt🧪 mac-wk1🧪 gtk-wk2🧪 api-ios🧪 mac-wk2🧪 api-gtk🛠 tv🧪 mac-AS-debug-wk2🛠 tv-sim🧪 mac-wk2-stress🛠 watch-sim