Move Page::renderingUpdateCompleted call to outside loop in Page::finalizeRenderingUpdate #14183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achristensen07
added
the
WebKit Process Model
|
EWS run on current version of this PR (hash 69d66f3)
|
hortont424
approved these changes
May 22, 2023
achristensen07
added
the
unsafe-merge-queue
webkit-commit-queue
force-pushed
the
eng/Move-PagerenderingUpdateCompleted-call-to-outside-loop-in-PagefinalizeRenderingUpdate
branch
from
69d66f3
to
5d3c118
Compare
…alizeRenderingUpdate https://bugs.webkit.org/show_bug.cgi?id=257127 rdar://109664043 Reviewed by Tim Horton. This does not change behavior with site isolation off because a page will only ever have one root frame, which is always the main frame. A root frame is a local frame that does not have a local parent, which means its layer is a root drawing layer in this process that will be composited in the UI process. This change is needed as a step towards drawing multiple iframes in the same process, in which case a Page would have multiple root frames. It only needs to call renderingUpdateCompleted once and if it doesn't then assertions and crashes happen. This change is also needed to fix some crashes from WebKit#14025 but this change is completely unrelated so I'm doing it in a separate PR. * Source/WebCore/page/Page.cpp: (WebCore::Page::finalizeRenderingUpdate): (WebCore::Page::finalizeRenderingUpdateForRootFrame): Canonical link: https://commits.webkit.org/264330@main
webkit-commit-queue
force-pushed
the
eng/Move-PagerenderingUpdateCompleted-call-to-outside-loop-in-PagefinalizeRenderingUpdate
branch
from
5d3c118
to
8730f01
Compare
|
Committed 264330@main (8730f01): https://commits.webkit.org/264330@main Reviewed commits have been landed. Closing PR #14183 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
8730f01
69d66f3
🛠 wincairo🧪 wpe-wk2🧪 ios-wk2🧪 api-mac🧪 mac-wk1🧪 gtk-wk2🧪 api-ios🧪 mac-wk2🧪 mac-AS-debug-wk2