Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Xcode] Use workspace builds by default in build-webkit #1421

Commits on Jun 9, 2022

  1. [Xcode] Use workspace builds by default in build-webkit

    https://bugs.webkit.org/show_bug.cgi?id=241298
    
    Reviewed by NOBODY (OOPS!).
    
    Switch the default value of the --use-workspace flag, and add a warning
    message indicating that non-workspace Xcode builds are deprecated.
    
    Add product dependencies and disable SDK metadata parsing in tools
    projects, to prevent watchOS/tvOS workspace builds from thinking we are
    linking against system WebKit.
    
    Add an aggregate "MiniBrowser (Mac-only)" target, which MiniBrowser.app
    iff the workspace is building for a Mac destination.
    
    * Source/ThirdParty/libwebrtc/Configurations/DebugRelease.xcconfig: Fix
      an sdk xcconfig setting.
    * Tools/DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig:
      Set DISABLE_SDK_METADATA_PARSING.
    * Tools/DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig: Set
      DISABLE_SDK_METADATA_PARSING.
    * Tools/MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Add product
      dependency on WebKit, and create aggregate target mentioned above.
    * Tools/MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
      Add WebKit product dependency.
    * Tools/Scripts/build-webkit: Switch --use-workspace default.
    * Tools/TestWebKitAPI/Configurations/InjectedBundle.xcconfig: Set
      DISABLE_SDK_METADATA_PARSING.
    * Tools/TestWebKitAPI/Configurations/TestWTFLibrary.xcconfig: Set
      DISABLE_SDK_METADATA_PARSING.
    * Tools/TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Set
      DISABLE_SDK_METADATA_PARSING.
    * Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
      WebKit product dependency.
    * Tools/WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Add
      DISABLE_SDK_METADATA_PARSING.
    * Tools/WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Add
      DISABLE_SDK_METADATA_PARSING.
    * WebKit.xcworkspace/xcshareddata/xcschemes/All Modules.xcscheme:
      Replace MiniBrowser.app with aggregate target.
    * WebKit.xcworkspace/xcshareddata/xcschemes/All Tools.xcscheme: Replace
      MiniBrowser.app with aggregate target.
    emw-apple committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    0955e3c View commit details
    Browse the repository at this point in the history