Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IDL generation after 264293@main when MODERN_MEDIA_CONTROLS is off #14220

Conversation

@donny-dont donny-dont added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 23, 2023
https://bugs.webkit.org/show_bug.cgi?id=257168

Reviewed by Don Olmstead.

Guard `SourceType` with a `MODERN_MEDIA_CONTROLS` conditional.

* Source/WebCore/Modules/mediacontrols/MediaControlsHost.idl:

Canonical link: https://commits.webkit.org/264387@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Fix-IDL-generation-after-264293main-when-MODERN_MEDIA_CONTROLS-is-off branch from ebb89d5 to e660f99 Compare May 23, 2023 00:33
@webkit-commit-queue webkit-commit-queue merged commit e660f99 into WebKit:main May 23, 2023
@webkit-commit-queue
Copy link
Collaborator

Committed 264387@main (e660f99): https://commits.webkit.org/264387@main

Reviewed commits have been landed. Closing PR #14220 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants