Don't fire a mousemove event when a modifier key is pressed #14221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aprotyas
added
the
UI Events
aprotyas
requested review from
hortont424,
whsieh,
pxlcoder,
rr-codes and
megangardner
|
EWS run on previous version of this PR (hash 4db3c8f)
|
Bugzilla link should come before radar. |
Fixed! 73bdded |
whsieh
reviewed
May 23, 2023
|
EWS run on previous version of this PR (hash 73bdded)
|
|
EWS run on previous version of this PR (hash b760787)
|
|
EWS run on previous version of this PR (hash ef38976) |
hortont424
reviewed
May 23, 2023
whsieh
approved these changes
May 23, 2023
LayoutTests/fast/events/no-mousemove-on-modifier-key-press.html
Outdated
Show resolved
Hide resolved
LayoutTests/fast/events/no-mousemove-on-modifier-key-press.html
Outdated
Show resolved
Hide resolved
|
EWS run on previous version of this PR (hash c880255) |
webkit-ews-buildbot
added
the
merging-blocked
aprotyas
removed
the
merging-blocked
|
EWS run on current version of this PR (hash 1fd5225) |
https://bugs.webkit.org/show_bug.cgi?id=16271 rdar://81287778 Reviewed by Wenson Hsieh. Previously, we dispatched mousemove events whenever a modifier key was pressed. This was used to call the UIClient delegate callback mouseDidMoveOverElement, which downstream clients could use to modify various behaviors based on whether or not modifier keys were pressed. Unfortunately, the act of dispatching a mousemove event meant that pressing modifier keys could cause unexpected mouse behavior. One notable example is Slack. When using Slack through Minibrowser, it is possible to experience spontaneous mouse selection when a cursor was originally placed behind a completion list, since our hover state gets constantly re-evaluated. In this patch, we introduce a mechanism to avoid the need to fire a mousemove event when modifier keys are pressed. This is achieved by adding a new message from the UI process to the web process where we request that a given mouse event's hit test be performed. With the hit test result and user data associated with said mouse event, we can simply call into the UIClient delegate callback mouseDidMoveOverElement, avoiding the regular mouse event dispatch dance altogether. * LayoutTests/fast/events/no-mousemove-on-modifier-key-press-expected.txt: Added. * LayoutTests/fast/events/no-mousemove-on-modifier-key-press.html: Added. Layout test that verifies pressing the modifier keys does not fire a MouseMove event. * Source/WebCore/page/Chrome.h: Export (and make public) Chrome::getToolTip to access from the web process. * Source/WebCore/page/EventHandler.cpp: (WebCore::EventHandler::getHitTypeForMouseMoveEvent): (WebCore::EventHandler::getHitTestResultForMouseEvent): (WebCore::EventHandler::handleMouseMoveEvent): Introduce two functions getHitTypeForMouseMoveEvent and getHitTestResultForMouseEvent. The latter strips out some common code from handleMouseMoveEvent so that it can be called independently to identify a hitType, whereas the former is a handy way to produce a hitTestResult without bringing the MouseEventWithHitTestResults type into web process land. * Source/WebCore/page/EventHandler.h: * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::dispatchMouseDidMoveOverElementAsynchronously): Introduce a method that communicates the need for user data and a hit test on a mouse event without actually dispatching said mouse event to the web process. Once we round trip from the web process, it feeds the returned data to the client delegate callback mouseDidMoveOverElement. * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/UIProcess/mac/WebViewImpl.h: * Source/WebKit/UIProcess/mac/WebViewImpl.mm: (WebKit::WebViewImpl::viewDidMoveToWindow): (WebKit::WebViewImpl::fireMouseDidMoveOverElement): (WebKit::WebViewImpl::postFakeMouseMovedEventForFlagsChangedEvent): Deleted. Rename postFakeMouseMovedEventForFlagsChangedEvent to fireMouseDidMoveOverElement to better represent our signaling intent. fireMouseDidMoveOverElement then communicates with the web page to receive user data and hit test results before passing that over to the client delegate callback. * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::performHitTestAndGetUserData): * Source/WebKit/WebProcess/WebPage/WebPage.h: * Source/WebKit/WebProcess/WebPage/WebPage.messages.in: Introduce a new message that receives a mouse event from the UI process and calls into the page's event handler and chrome clients to perform a hit test on the received mouse event. This allows us to circumvent the usual dance with a dispatched mouse event while returning the user data and hit test result associated with a mouse event. Canonical link: https://commits.webkit.org/264455@main
webkit-commit-queue
force-pushed
the
eng/16271
branch
from
1fd5225
to
f84b233
Compare
|
Committed 264455@main (f84b233): https://commits.webkit.org/264455@main Reviewed commits have been landed. Closing PR #14221 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
f84b233
1fd5225
🧪 gtk-wk2🧪 api-ios