Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor some enums in TypingCommand to enum classes #14254

Merged
merged 1 commit into from May 25, 2023

Conversation

jesxilin
Copy link
Contributor

@jesxilin jesxilin commented May 23, 2023

00fd254

Refactor some enums in TypingCommand to enum classes
https://bugs.webkit.org/show_bug.cgi?id=256936
rdar://109488827

Reviewed by Wenson Hsieh.

Refactor enums ETypingCommand, TextCompositionType and Option in TypingCommand to be enum classes.
Changed instances of TypingCommand::Option options to OptionSet.

* Source/WebCore/editing/Editor.cpp:
(WebCore::Editor::deleteWithDirection):
(WebCore::Editor::insertTextWithoutSendingTextEvent):
(WebCore::Editor::insertLineBreak):
(WebCore::Editor::insertParagraphSeparator):
(WebCore::Editor::setComposition):
* Source/WebCore/editing/EditorCommand.cpp:
(WebCore::executeDelete):
(WebCore::executeInsertLineBreak):
(WebCore::executeInsertParagraph):
(WebCore::executeInsertText):
* Source/WebCore/editing/TypingCommand.cpp:
(WebCore::editActionForTypingCommand):
(WebCore::TypingCommand::TypingCommand):
(WebCore::TypingCommand::deleteSelection):
(WebCore::TypingCommand::deleteKeyPressed):
(WebCore::TypingCommand::forwardDeleteKeyPressed):
(WebCore::TypingCommand::insertText):
(WebCore::TypingCommand::insertLineBreak):
(WebCore::TypingCommand::insertParagraphSeparatorInQuotedContent):
(WebCore::TypingCommand::insertParagraphSeparator):
(WebCore::TypingCommand::doApply):
(WebCore::TypingCommand::markMisspellingsAfterTyping):
(WebCore::TypingCommand::insertTextRunWithoutNewlines):
(WebCore::TypingCommand::updatePreservesTypingStyle):
* Source/WebCore/editing/TypingCommand.h:
* Source/WebCore/page/ContextMenuController.cpp:
(WebCore::insertUnicodeCharacter):

Canonical link: https://commits.webkit.org/264493@main

24ffa82

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ›  gtk
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1 βœ… πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  tv-sim
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch
βœ… πŸ›  watch-sim

@jesxilin jesxilin requested review from a team, cdumez and rniwa as code owners May 23, 2023 18:17
@jesxilin jesxilin changed the title Refactor some enums in Refactor some enums in TypingCommand to enum classes May 23, 2023
Source/WebCore/editing/TypingCommand.h Outdated Show resolved Hide resolved
Source/WebCore/editing/TypingCommand.h Outdated Show resolved Hide resolved
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 23, 2023
Source/WebCore/editing/Editor.cpp Outdated Show resolved Hide resolved
@rr-codes rr-codes removed the merging-blocked Applied to prevent a change from being merged label May 25, 2023
@rr-codes rr-codes added the merge-queue Applied to send a pull request to merge-queue label May 25, 2023
https://bugs.webkit.org/show_bug.cgi?id=256936
rdar://109488827

Reviewed by Wenson Hsieh.

Refactor enums ETypingCommand, TextCompositionType and Option in TypingCommand to be enum classes.
Changed instances of TypingCommand::Option options to OptionSet.

* Source/WebCore/editing/Editor.cpp:
(WebCore::Editor::deleteWithDirection):
(WebCore::Editor::insertTextWithoutSendingTextEvent):
(WebCore::Editor::insertLineBreak):
(WebCore::Editor::insertParagraphSeparator):
(WebCore::Editor::setComposition):
* Source/WebCore/editing/EditorCommand.cpp:
(WebCore::executeDelete):
(WebCore::executeInsertLineBreak):
(WebCore::executeInsertParagraph):
(WebCore::executeInsertText):
* Source/WebCore/editing/TypingCommand.cpp:
(WebCore::editActionForTypingCommand):
(WebCore::TypingCommand::TypingCommand):
(WebCore::TypingCommand::deleteSelection):
(WebCore::TypingCommand::deleteKeyPressed):
(WebCore::TypingCommand::forwardDeleteKeyPressed):
(WebCore::TypingCommand::insertText):
(WebCore::TypingCommand::insertLineBreak):
(WebCore::TypingCommand::insertParagraphSeparatorInQuotedContent):
(WebCore::TypingCommand::insertParagraphSeparator):
(WebCore::TypingCommand::doApply):
(WebCore::TypingCommand::markMisspellingsAfterTyping):
(WebCore::TypingCommand::insertTextRunWithoutNewlines):
(WebCore::TypingCommand::updatePreservesTypingStyle):
* Source/WebCore/editing/TypingCommand.h:
* Source/WebCore/page/ContextMenuController.cpp:
(WebCore::insertUnicodeCharacter):

Canonical link: https://commits.webkit.org/264493@main
@webkit-commit-queue
Copy link
Collaborator

Committed 264493@main (00fd254): https://commits.webkit.org/264493@main

Reviewed commits have been landed. Closing PR #14254 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 00fd254 into WebKit:main May 25, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants