New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor some enums in TypingCommand to enum classes #14254
Conversation
EWS run on previous version of this PR (hash 7fc5ea3) |
EWS run on previous version of this PR (hash 16c0f2c) |
EWS run on previous version of this PR (hash e05debd) |
EWS run on previous version of this PR (hash 96635f0) |
EWS run on current version of this PR (hash 24ffa82) |
https://bugs.webkit.org/show_bug.cgi?id=256936 rdar://109488827 Reviewed by Wenson Hsieh. Refactor enums ETypingCommand, TextCompositionType and Option in TypingCommand to be enum classes. Changed instances of TypingCommand::Option options to OptionSet. * Source/WebCore/editing/Editor.cpp: (WebCore::Editor::deleteWithDirection): (WebCore::Editor::insertTextWithoutSendingTextEvent): (WebCore::Editor::insertLineBreak): (WebCore::Editor::insertParagraphSeparator): (WebCore::Editor::setComposition): * Source/WebCore/editing/EditorCommand.cpp: (WebCore::executeDelete): (WebCore::executeInsertLineBreak): (WebCore::executeInsertParagraph): (WebCore::executeInsertText): * Source/WebCore/editing/TypingCommand.cpp: (WebCore::editActionForTypingCommand): (WebCore::TypingCommand::TypingCommand): (WebCore::TypingCommand::deleteSelection): (WebCore::TypingCommand::deleteKeyPressed): (WebCore::TypingCommand::forwardDeleteKeyPressed): (WebCore::TypingCommand::insertText): (WebCore::TypingCommand::insertLineBreak): (WebCore::TypingCommand::insertParagraphSeparatorInQuotedContent): (WebCore::TypingCommand::insertParagraphSeparator): (WebCore::TypingCommand::doApply): (WebCore::TypingCommand::markMisspellingsAfterTyping): (WebCore::TypingCommand::insertTextRunWithoutNewlines): (WebCore::TypingCommand::updatePreservesTypingStyle): * Source/WebCore/editing/TypingCommand.h: * Source/WebCore/page/ContextMenuController.cpp: (WebCore::insertUnicodeCharacter): Canonical link: https://commits.webkit.org/264493@main
24ffa82
to
00fd254
Compare
Committed 264493@main (00fd254): https://commits.webkit.org/264493@main Reviewed commits have been landed. Closing PR #14254 and removing active labels. |
00fd254
24ffa82