[TextureMapper] Missing implementation of backingStoreMemoryEstimate #14286

pgorszkowski-igalia · 2023-05-24T09:21:54Z

`3ed63da`

[TextureMapper] Missing implementation of backingStoreMemoryEstimate
https://bugs.webkit.org/show_bug.cgi?id=254910

Reviewed by Miguel Gomez.

The backingStores used by the CoordinatedGraphicsLayers are created during a layerFlush,
and they are freed in the next compositor cycle, after their content is uploaded into
a texture. Due to this, the life span of the Nicosia::Buffers is very short. As the
ResourceUsageThread samples the used memory every 500ms, it would be quite common that
the memory usage reported by the timeline would be zero. In order to avoid this,
the maximum memory usage is stored until the ResourceUsageThread is able to read it.
Thanks to this, the timeline is able to show the peak in the memory usage that reflects
the reality. It's not perfect though, as the peak will be shown in the timeline some ms
after it really happened, but it's the best approach we can do.

* Source/WebCore/page/linux/ResourceUsageThreadLinux.cpp:
(WebCore::ResourceUsageThread::platformSaveStateBeforeStarting):
(WebCore::ResourceUsageThread::platformCollectMemoryData):
* Source/WebCore/platform/graphics/nicosia/NicosiaBuffer.cpp:
(Nicosia::Buffer::resetMemoryUsage):
(Nicosia::Buffer::getMemoryUsage):
(Nicosia::Buffer::Buffer):
(Nicosia::Buffer::~Buffer):
* Source/WebCore/platform/graphics/nicosia/NicosiaBuffer.h:
* Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::backingStoreMemoryEstimate const):
* Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:

Canonical link: https://commits.webkit.org/266424@main

674c035

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	❌ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
✅ 🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-05-24T09:24:56Z

EWS run on previous version of this PR (hash e8cf0b9)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

magomez · 2023-06-08T11:02:22Z

Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp

+        return 0;
+
+    return *estimatedBackingStoreMemory;
+}


You could just return estimatedBackingStoreMemory.value_or(0) to avoid checking whether there value is defined

@pgorszkowski-igalia @magomez : is it normal to return 0 here for CoordinatedGraphicsLayer::backingStoreMemoryEstimate()?

It seems that intermediate steps of the PR returned estimatedBackingStoreMemory.
cc @hwti

magomez · 2023-06-08T11:03:54Z

Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h

@@ -253,6 +255,8 @@ class WEBCORE_EXPORT CoordinatedGraphicsLayer : public GraphicsLayer {

    RefPtr<AnimatedBackingStoreHost> m_animatedBackingStoreHost;
    RefPtr<CoordinatedGraphicsLayer> m_backdropLayer;
+
+    std::optional<double> estimatedBackingStoreMemory;


I'm not sure why you use an optional here. A double initialized to 0 should be enough, as 0 is what you're returning when the optional is not initialized. I mean, you can use the optional, but it's an overkill in this case.

You are right, I will use just double for that.

magomez · 2023-06-08T11:05:19Z

Source/WebCore/rendering/RenderLayerCompositor.cpp

+#if ENABLE(RESOURCE_USAGE)
+        // We save the total memory size of layers to show in the memory timeline of Inspector.
+        WebCore::ResourceUsageThread::setTotalLayerBackingStoreBytes(m_obligatoryBackingStoreBytes + m_secondaryBackingStoreBytes);
+#endif


The problem with this is that it's only executed if LOG is enabled, which is odd. So in order to get a valid value we need to enable both LOG and RESOURCE_USAGE. We should be able to get this value without having to enable LOG.

The problem is that m_obligatoryBackingStoreBytes and m_secondaryBackingStoreBytes are set and calculated also only in case when LOG(Compositing) is enabled.
RESOURCE_USAGE I will remove, it is not needed here.

webkit-early-warning-system · 2023-06-14T07:23:35Z

EWS run on previous version of this PR (hash 00345a6)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-06-23T10:11:18Z

EWS run on previous version of this PR (hash d30d6f5)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-07-21T10:14:44Z

EWS run on previous version of this PR (hash 6f51038)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	✅ 🛠 gtk
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	~~🧪 gtk-wk2~~
	~~🧪 api-ios~~	~~🧪 mac-wk2~~	~~🧪 api-gtk~~
	✅ 🛠 tv	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-07-21T10:35:39Z

EWS run on previous version of this PR (hash 25dad28)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-07-25T10:17:03Z

EWS run on previous version of this PR (hash 31f3708)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	~~🛠 wincairo~~
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	~~🛠 gtk~~
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	~~🧪 gtk-wk2~~
	~~🧪 api-ios~~	~~🧪 mac-wk2~~	~~🧪 api-gtk~~
	✅ 🛠 tv	⏳ 🧪 mac-AS-debug-wk2
	⏳ 🛠 tv-sim
	✅ 🛠 watch
	⏳ 🛠 watch-sim

webkit-early-warning-system · 2023-07-25T10:20:19Z

EWS run on previous version of this PR (hash 0d0c1f5)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

dcrousso · 2023-07-25T16:29:23Z

Source/WebInspectorUI/UserInterface/Models/MemoryTimelineRecord.js

+        // Memory usage of "Layers" can be "0"
+        memoryCategories.push({type: WI.MemoryCategory.Type.Layers, size: layersSize});


what is the motivation/goal of this change?

also, i think this means that every WI.MemoryTimelineRecord will now have a WI.MemoryCategory.Type.Layers since layersSize defaults to 0 at the top, which is probably not what we want. IMO if a WI.MemoryTimelineRecord has a WI.MemoryCategory.Type.Layers with a size of 0 then we probably dont want/need to show it since there's nothing to show as it is 0 after all (i.e. having an empty graph is arguably worse than not having a graph as it could draw attention where none is deserved)

Actually it is possible that in some cases the memory usage could be 0 but not for all time. And not having graph because memory usage is 0 at the beginning is not ideal solution. Probably there should be something else which will indicate that the graph should not be shown because there will be always 0 value. Maybe some additional field in MemoryCategoryInfo to indicate is it valid or not for specific category? WDYT?
Another solution could be removing categories for which there is no data.

im pretty sure that's how it works today. it should only show the graph(s) if there's something to show

there's no way for us to know if something in that category will happen in the future. we certainly could do a better job of differentiating "there was no work in this category" and "the work in this category was not substantial enough to actually be above 0", but IMO that's something unrelated to this PR so i'd kindly ask that you undo your changes here and open a new bug/PR where we can directly discuss/address that

Sure, I will undo it and create a separate bug report about that. I completely agree with you that this is not related to this PR, but this change will depend on the one about described issue.

https://bugs.webkit.org/show_bug.cgi?id=259553

webkit-early-warning-system · 2023-07-27T04:52:13Z

EWS run on previous version of this PR (hash bf52b73)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

magomez

Please, fix the commit message to explain why this is implemented that way it is, because it's not straightforward to get what's been done here and why.

magomez · 2023-07-27T05:10:13Z

Source/WebCore/page/linux/ResourceUsageThreadLinux.cpp

@@ -105,6 +105,9 @@ void ResourceUsageThread::platformSaveStateBeforeStarting()
            m_samplingProfilerThreadID = thread->id();
    }
 #endif
+    // Reset max of reported memory usage of layers.
+    Locker locker { m_layersMemoryUsageLock };
+    m_maxLayersMemoryUsage = 0;


this should probably be reset to m_currentLayersMemoryUsage and not 0.

magomez · 2023-07-27T05:10:25Z

Source/WebCore/page/linux/ResourceUsageThreadLinux.cpp

+        Locker locker { m_layersMemoryUsageLock };
+        data.categories[MemoryCategory::Layers].dirtySize = m_maxLayersMemoryUsage;
+        // Reset the max reported of memory usage to gather new max in next 500ms.
+        m_maxLayersMemoryUsage = 0;


this should probably be reset to m_currentLayersMemoryUsage and not 0 as well.

webkit-early-warning-system · 2023-07-27T10:54:56Z

EWS run on previous version of this PR (hash 6ccb09d)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-07-28T08:06:12Z

EWS run on previous version of this PR (hash 25d28d1)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-07-31T09:39:22Z

EWS run on previous version of this PR (hash 3701c91)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	✅ 🛠 gtk
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	~~🧪 gtk-wk2~~
	~~🧪 api-ios~~	~~🧪 mac-wk2~~	✅ 🧪 api-gtk
	✅ 🛠 tv	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-07-31T09:55:34Z

EWS run on previous version of this PR (hash 48f6bce)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	✅ 🛠 gtk
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	~~🧪 gtk-wk2~~
	~~🧪 api-ios~~	~~🧪 mac-wk2~~	~~🧪 api-gtk~~
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-07-31T10:30:07Z

EWS run on previous version of this PR (hash a81615a)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	~~🧪 gtk-wk2~~
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-07-31T11:46:01Z

EWS run on current version of this PR (hash 674c035)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	❌ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
✅ 🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

https://bugs.webkit.org/show_bug.cgi?id=254910 Reviewed by Miguel Gomez. The backingStores used by the CoordinatedGraphicsLayers are created during a layerFlush, and they are freed in the next compositor cycle, after their content is uploaded into a texture. Due to this, the life span of the Nicosia::Buffers is very short. As the ResourceUsageThread samples the used memory every 500ms, it would be quite common that the memory usage reported by the timeline would be zero. In order to avoid this, the maximum memory usage is stored until the ResourceUsageThread is able to read it. Thanks to this, the timeline is able to show the peak in the memory usage that reflects the reality. It's not perfect though, as the peak will be shown in the timeline some ms after it really happened, but it's the best approach we can do. * Source/WebCore/page/linux/ResourceUsageThreadLinux.cpp: (WebCore::ResourceUsageThread::platformSaveStateBeforeStarting): (WebCore::ResourceUsageThread::platformCollectMemoryData): * Source/WebCore/platform/graphics/nicosia/NicosiaBuffer.cpp: (Nicosia::Buffer::resetMemoryUsage): (Nicosia::Buffer::getMemoryUsage): (Nicosia::Buffer::Buffer): (Nicosia::Buffer::~Buffer): * Source/WebCore/platform/graphics/nicosia/NicosiaBuffer.h: * Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp: (WebCore::CoordinatedGraphicsLayer::backingStoreMemoryEstimate const): * Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h: Canonical link: https://commits.webkit.org/266424@main

webkit-commit-queue · 2023-07-31T13:42:21Z

Committed 266424@main (3ed63da): https://commits.webkit.org/266424@main

Reviewed commits have been landed. Closing PR #14286 and removing active labels.

pgorszkowski-igalia requested review from a team, magomez, zdobersek and cdumez as code owners May 24, 2023 09:21

pgorszkowski-igalia self-assigned this May 24, 2023

pgorszkowski-igalia added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label May 24, 2023

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 24, 2023

pgorszkowski-igalia requested a review from carlosgcampos May 26, 2023 09:46

magomez requested changes Jun 8, 2023

View reviewed changes

pgorszkowski-igalia force-pushed the eng/TextureMapper-Missing-implementation-of--backingStoreMemoryEstimate branch from e8cf0b9 to 00345a6 Compare June 14, 2023 07:23

pgorszkowski-igalia force-pushed the eng/TextureMapper-Missing-implementation-of--backingStoreMemoryEstimate branch from 00345a6 to d30d6f5 Compare June 23, 2023 10:11

pgorszkowski-igalia force-pushed the eng/TextureMapper-Missing-implementation-of--backingStoreMemoryEstimate branch from d30d6f5 to 6f51038 Compare July 21, 2023 10:14

pgorszkowski-igalia force-pushed the eng/TextureMapper-Missing-implementation-of--backingStoreMemoryEstimate branch from 6f51038 to 25dad28 Compare July 21, 2023 10:35

pgorszkowski-igalia force-pushed the eng/TextureMapper-Missing-implementation-of--backingStoreMemoryEstimate branch from 25dad28 to 31f3708 Compare July 25, 2023 10:16

pgorszkowski-igalia requested review from dcrousso and patrickangle as code owners July 25, 2023 10:16

pgorszkowski-igalia force-pushed the eng/TextureMapper-Missing-implementation-of--backingStoreMemoryEstimate branch from 31f3708 to 0d0c1f5 Compare July 25, 2023 10:20

dcrousso reviewed Jul 25, 2023

View reviewed changes

pgorszkowski-igalia force-pushed the eng/TextureMapper-Missing-implementation-of--backingStoreMemoryEstimate branch from 0d0c1f5 to bf52b73 Compare July 27, 2023 04:52

magomez requested changes Jul 27, 2023

View reviewed changes

pgorszkowski-igalia force-pushed the eng/TextureMapper-Missing-implementation-of--backingStoreMemoryEstimate branch from bf52b73 to 6ccb09d Compare July 27, 2023 10:54

pgorszkowski-igalia force-pushed the eng/TextureMapper-Missing-implementation-of--backingStoreMemoryEstimate branch from 6ccb09d to 25d28d1 Compare July 28, 2023 08:06

pgorszkowski-igalia requested review from dcrousso and magomez July 28, 2023 11:38

pgorszkowski-igalia force-pushed the eng/TextureMapper-Missing-implementation-of--backingStoreMemoryEstimate branch from 25d28d1 to 3701c91 Compare July 31, 2023 09:39

pgorszkowski-igalia force-pushed the eng/TextureMapper-Missing-implementation-of--backingStoreMemoryEstimate branch from 3701c91 to 48f6bce Compare July 31, 2023 09:55

pgorszkowski-igalia force-pushed the eng/TextureMapper-Missing-implementation-of--backingStoreMemoryEstimate branch from 48f6bce to a81615a Compare July 31, 2023 10:29

pgorszkowski-igalia force-pushed the eng/TextureMapper-Missing-implementation-of--backingStoreMemoryEstimate branch 2 times, most recently from 46cd6c0 to 674c035 Compare July 31, 2023 11:45

magomez approved these changes Jul 31, 2023

View reviewed changes

magomez added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Jul 31, 2023

webkit-commit-queue force-pushed the eng/TextureMapper-Missing-implementation-of--backingStoreMemoryEstimate branch from 674c035 to 3ed63da Compare July 31, 2023 13:42

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jul 31, 2023

webkit-commit-queue merged commit 3ed63da into WebKit:main Jul 31, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TextureMapper] Missing implementation of backingStoreMemoryEstimate #14286

[TextureMapper] Missing implementation of backingStoreMemoryEstimate #14286

pgorszkowski-igalia commented May 24, 2023 •

edited by webkit-early-warning-system

webkit-early-warning-system commented May 24, 2023 •

edited

magomez Jun 8, 2023

blino Feb 8, 2024

magomez Jun 8, 2023

pgorszkowski-igalia Jun 13, 2023

magomez Jun 8, 2023

pgorszkowski-igalia Jun 13, 2023

webkit-early-warning-system commented Jun 14, 2023 •

edited

webkit-early-warning-system commented Jun 23, 2023 •

edited

webkit-early-warning-system commented Jul 21, 2023 •

edited

webkit-early-warning-system commented Jul 21, 2023 •

edited

webkit-early-warning-system commented Jul 25, 2023 •

edited

webkit-early-warning-system commented Jul 25, 2023 •

edited

dcrousso Jul 25, 2023

pgorszkowski-igalia Jul 26, 2023

dcrousso Jul 26, 2023

pgorszkowski-igalia Jul 26, 2023

pgorszkowski-igalia Jul 27, 2023

webkit-early-warning-system commented Jul 27, 2023 •

edited

magomez left a comment

magomez Jul 27, 2023

magomez Jul 27, 2023

webkit-early-warning-system commented Jul 27, 2023 •

edited

webkit-early-warning-system commented Jul 28, 2023 •

edited

webkit-early-warning-system commented Jul 31, 2023 •

edited

webkit-early-warning-system commented Jul 31, 2023 •

edited

webkit-early-warning-system commented Jul 31, 2023 •

edited

webkit-early-warning-system commented Jul 31, 2023 •

edited

webkit-commit-queue commented Jul 31, 2023

		// Memory usage of "Layers" can be "0"
		memoryCategories.push({type: WI.MemoryCategory.Type.Layers, size: layersSize});

[TextureMapper] Missing implementation of backingStoreMemoryEstimate #14286

[TextureMapper] Missing implementation of backingStoreMemoryEstimate #14286

Conversation

pgorszkowski-igalia commented May 24, 2023 • edited by webkit-early-warning-system

webkit-early-warning-system commented May 24, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

webkit-early-warning-system commented Jun 14, 2023 • edited

webkit-early-warning-system commented Jun 23, 2023 • edited

webkit-early-warning-system commented Jul 21, 2023 • edited

webkit-early-warning-system commented Jul 21, 2023 • edited

webkit-early-warning-system commented Jul 25, 2023 • edited

webkit-early-warning-system commented Jul 25, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

webkit-early-warning-system commented Jul 27, 2023 • edited

magomez left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

webkit-early-warning-system commented Jul 27, 2023 • edited

webkit-early-warning-system commented Jul 28, 2023 • edited

webkit-early-warning-system commented Jul 31, 2023 • edited

webkit-early-warning-system commented Jul 31, 2023 • edited

webkit-early-warning-system commented Jul 31, 2023 • edited

webkit-early-warning-system commented Jul 31, 2023 • edited

webkit-commit-queue commented Jul 31, 2023

pgorszkowski-igalia commented May 24, 2023 •

edited by webkit-early-warning-system

webkit-early-warning-system commented May 24, 2023 •

edited

webkit-early-warning-system commented Jun 14, 2023 •

edited

webkit-early-warning-system commented Jun 23, 2023 •

edited

webkit-early-warning-system commented Jul 21, 2023 •

edited

webkit-early-warning-system commented Jul 21, 2023 •

edited

webkit-early-warning-system commented Jul 25, 2023 •

edited

webkit-early-warning-system commented Jul 25, 2023 •

edited

webkit-early-warning-system commented Jul 27, 2023 •

edited

webkit-early-warning-system commented Jul 27, 2023 •

edited

webkit-early-warning-system commented Jul 28, 2023 •

edited

webkit-early-warning-system commented Jul 31, 2023 •

edited

webkit-early-warning-system commented Jul 31, 2023 •

edited

webkit-early-warning-system commented Jul 31, 2023 •

edited

webkit-early-warning-system commented Jul 31, 2023 •

edited