Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebGPU] UVRemap matrix is flipped for texture_external #14306

Merged
merged 1 commit into from May 25, 2023
Merged

[WebGPU] UVRemap matrix is flipped for texture_external #14306

merged 1 commit into from May 25, 2023

Conversation

mwyrzykowski
Copy link
Contributor

@mwyrzykowski mwyrzykowski commented May 24, 2023 •
edited by webkit-early-warning-system

58126ba

[WebGPU] UVRemap matrix is flipped for texture_external
https://bugs.webkit.org/show_bug.cgi?id=257280
<radar://109794799>

Reviewed by Tadeu Zagallo.

I flipped 0 and 1 when solving for Ay and By in the linear equation.

* Source/WebGPU/WebGPU/BindGroup.mm:
(WebGPU::Device::createExternalTextureFromPixelBuffer const):

Canonical link: https://commits.webkit.org/264526@main

d76e9a6

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ❌ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@mwyrzykowski mwyrzykowski self-assigned this May 24, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash d76e9a6)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ❌ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@mwyrzykowski mwyrzykowski changed the title ??? [WebGPU] UVRemap matrix is flipped for texture_external May 24, 2023
@mwyrzykowski mwyrzykowski added the WebGPU For bugs in WebGPU label May 24, 2023
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 25, 2023
@mwyrzykowski mwyrzykowski removed the merging-blocked Applied to prevent a change from being merged label May 25, 2023
@mwyrzykowski mwyrzykowski added the merge-queue Applied to send a pull request to merge-queue label May 25, 2023
@mwyrzykowski
[WebGPU] UVRemap matrix is flipped for texture_external
58126ba 
https://bugs.webkit.org/show_bug.cgi?id=257280
<radar://109794799>

Reviewed by Tadeu Zagallo.

I flipped 0 and 1 when solving for Ay and By in the linear equation.

* Source/WebGPU/WebGPU/BindGroup.mm:
(WebGPU::Device::createExternalTextureFromPixelBuffer const):

Canonical link: https://commits.webkit.org/264526@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WebGPU-UVRemap-matrix-is-flipped-for-texture_external branch from d76e9a6 to 58126ba Compare May 25, 2023 17:33
@webkit-commit-queue
Copy link
Collaborator

Committed 264526@main (58126ba): https://commits.webkit.org/264526@main

Reviewed commits have been landed. Closing PR #14306 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 58126ba into WebKit:main May 25, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadeuzagallo tadeuzagallo tadeuzagallo approved these changes

@litherum litherum Awaiting requested review from litherum

@djg djg Awaiting requested review from djg

Assignees

@mwyrzykowski mwyrzykowski

Labels
WebGPU For bugs in WebGPU
Projects
None yet
Milestone
No milestone
5 participants
@mwyrzykowski @webkit-early-warning-system @webkit-commit-queue @tadeuzagallo @webkit-ews-buildbot