Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serialize NSMutableString as NSString when encoding DDActionContext and RVItem #14307

Merged
merged 1 commit into from
May 24, 2023
Merged

Serialize NSMutableString as NSString when encoding DDActionContext and RVItem #14307

merged 1 commit into from
May 24, 2023

Conversation

achristensen07
Copy link
Contributor

@achristensen07 achristensen07 commented May 24, 2023 •
edited by webkit-early-warning-system

52eeb76

Serialize NSMutableString as NSString when encoding DDActionContext and RVItem
https://bugs.webkit.org/show_bug.cgi?id=257281
rdar://109792470

Reviewed by Tim Horton.

It can cause issues when deserializing NSStrings.
We already do this for DDScannerResult and it is needed for all three.

* Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm:
(IPC::encodeSecureCodingInternal):

Canonical link: https://commits.webkit.org/264486@main

fbcde4b

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🛠 ios-sim   🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
  🧪 ios-wk2-wpt   🧪 gtk-wk2
  🧪 api-ios   🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2
  🛠 tv-sim
  🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@achristensen07 achristensen07 self-assigned this May 24, 2023
@achristensen07 achristensen07 added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label May 24, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash fbcde4b)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🛠 ios-sim   🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
  🧪 ios-wk2-wpt   🧪 gtk-wk2
  🧪 api-ios   🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2
  🛠 tv-sim
  🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@achristensen07 achristensen07 added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 24, 2023
@achristensen07
Serialize NSMutableString as NSString when encoding DDActionContext a…
52eeb76 
…nd RVItem

https://bugs.webkit.org/show_bug.cgi?id=257281
rdar://109792470

Reviewed by Tim Horton.

It can cause issues when deserializing NSStrings.
We already do this for DDScannerResult and it is needed for all three.

* Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm:
(IPC::encodeSecureCodingInternal):

Canonical link: https://commits.webkit.org/264486@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Serialize-NSMutableString-as-NSString-when-encoding-DDActionContext-and-RVItem branch from fbcde4b to 52eeb76 Compare May 24, 2023 21:44
@webkit-commit-queue
Copy link
Collaborator

Committed 264486@main (52eeb76): https://commits.webkit.org/264486@main

Reviewed commits have been landed. Closing PR #14307 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 52eeb76 into WebKit:main May 24, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hortont424 hortont424 hortont424 approved these changes

Assignees

@achristensen07 achristensen07

Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
Milestone
No milestone
4 participants
@achristensen07 @webkit-early-warning-system @webkit-commit-queue @hortont424