Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REGRESSION(262981@main): [iOS] WebKit never activates its AVAudioSession #14332

Conversation

jernoble
Copy link
Contributor

@jernoble jernoble commented May 25, 2023

5f43fea

REGRESSION(262981@main): [iOS] WebKit never activates its AVAudioSession
https://bugs.webkit.org/show_bug.cgi?id=257309
rdar://109817291

Reviewed by Eric Carlson and Youenn Fablet.

In 262981@main, the contents of AudioSessionIOS::tryToSetActiveInternal() were moved into
a new common base class of AudioSessionIOS and AudioSessionMac: AudioSessionCocoa.

However, that patch neglected to make AudioSessionCocoa a base class of AudioSessionIOS.
This had the effect of removing audio session activation entirely from the iOS port of
WebKit.

* Source/WebCore/platform/audio/ios/AudioSessionIOS.h:

Canonical link: https://commits.webkit.org/264599@main

83952f1

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ›  gtk
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1 βœ… πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  tv-sim
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch
βœ… πŸ›  watch-sim

@jernoble jernoble self-assigned this May 25, 2023
@jernoble jernoble added the Media Bugs related to the HTML 5 Media elements. label May 25, 2023
@webkit-early-warning-system
Copy link
Collaborator

Starting EWS tests for 83952f1. Live statuses available at the PR page, #14332

@eric-carlson eric-carlson added merge-queue Applied to send a pull request to merge-queue and removed merge-queue Applied to send a pull request to merge-queue labels May 25, 2023
@jernoble jernoble added the merge-queue Applied to send a pull request to merge-queue label May 26, 2023
https://bugs.webkit.org/show_bug.cgi?id=257309
rdar://109817291

Reviewed by Eric Carlson and Youenn Fablet.

In 262981@main, the contents of AudioSessionIOS::tryToSetActiveInternal() were moved into
a new common base class of AudioSessionIOS and AudioSessionMac: AudioSessionCocoa.

However, that patch neglected to make AudioSessionCocoa a base class of AudioSessionIOS.
This had the effect of removing audio session activation entirely from the iOS port of
WebKit.

* Source/WebCore/platform/audio/ios/AudioSessionIOS.h:

Canonical link: https://commits.webkit.org/264599@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/REGRESSION262981main-iOS-WebKit-never-activates-its-AVAudioSession branch from 83952f1 to 5f43fea Compare May 26, 2023 19:21
@webkit-commit-queue
Copy link
Collaborator

Committed 264599@main (5f43fea): https://commits.webkit.org/264599@main

Reviewed commits have been landed. Closing PR #14332 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 5f43fea into WebKit:main May 26, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label May 26, 2023
@jernoble jernoble deleted the eng/REGRESSION262981main-iOS-WebKit-never-activates-its-AVAudioSession branch October 26, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Media Bugs related to the HTML 5 Media elements.
Projects
None yet
5 participants