Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WGSL] Add support for increment and decrement statements #14339

Merged
merged 1 commit into from
May 26, 2023
Merged

[WGSL] Add support for increment and decrement statements #14339

merged 1 commit into from
May 26, 2023

Conversation

tadeuzagallo
Copy link
Member

@tadeuzagallo tadeuzagallo commented May 25, 2023 •
edited by webkit-early-warning-system

dd11610

[WGSL] Add support for increment and decrement statements
https://bugs.webkit.org/show_bug.cgi?id=257315
rdar://109823828

Reviewed by Mike Wyrzykowski.

Add support for `x++` and `x--` statements

* Source/WebGPU/WGSL/AST/ASTDecrementIncrementStatement.cpp: Copied from Source/WebGPU/WGSL/AST/ASTDecrementIncrementStatement.h.
(WGSL::AST::printInternal):
* Source/WebGPU/WGSL/AST/ASTDecrementIncrementStatement.h:
* Source/WebGPU/WGSL/AST/ASTStringDumper.cpp:
(WGSL::AST::StringDumper::visit):
* Source/WebGPU/WGSL/AST/ASTStringDumper.h:
* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::FunctionDefinitionWriter::visit):
* Source/WebGPU/WGSL/Parser.cpp:
(WGSL::Parser<Lexer>::parseStatement):
* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::visit):
* Source/WebGPU/WGSL/tests/invalid/references.wgsl:
* Source/WebGPU/WGSL/tests/valid/references.wgsl:
* Source/WebGPU/WebGPU.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/264575@main

f8edc9b

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt   🧪 gtk-wk2
  🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@tadeuzagallo tadeuzagallo self-assigned this May 25, 2023
@tadeuzagallo tadeuzagallo added the WebGPU For bugs in WebGPU label May 25, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 5e50fc5)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@tadeuzagallo tadeuzagallo changed the title [WGSL] [WGSL] Add support for increment and decrement statements May 25, 2023
mwyrzykowski
mwyrzykowski approved these changes May 26, 2023
View reviewed changes
Copy link
Contributor

@mwyrzykowski mwyrzykowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval for the top commit, my assumption is the others will merge prior to this one

@tadeuzagallo tadeuzagallo force-pushed the eng/WGSL-Add-support-for-increment-and-decrement-statements branch from 5e50fc5 to f8edc9b Compare May 26, 2023 09:06
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash f8edc9b)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt   🧪 gtk-wk2
  🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@tadeuzagallo tadeuzagallo added the merge-queue Applied to send a pull request to merge-queue label May 26, 2023
@tadeuzagallo
[WGSL] Add support for increment and decrement statements
dd11610 
https://bugs.webkit.org/show_bug.cgi?id=257315
rdar://109823828

Reviewed by Mike Wyrzykowski.

Add support for `x++` and `x--` statements

* Source/WebGPU/WGSL/AST/ASTDecrementIncrementStatement.cpp: Copied from Source/WebGPU/WGSL/AST/ASTDecrementIncrementStatement.h.
(WGSL::AST::printInternal):
* Source/WebGPU/WGSL/AST/ASTDecrementIncrementStatement.h:
* Source/WebGPU/WGSL/AST/ASTStringDumper.cpp:
(WGSL::AST::StringDumper::visit):
* Source/WebGPU/WGSL/AST/ASTStringDumper.h:
* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::FunctionDefinitionWriter::visit):
* Source/WebGPU/WGSL/Parser.cpp:
(WGSL::Parser<Lexer>::parseStatement):
* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::visit):
* Source/WebGPU/WGSL/tests/invalid/references.wgsl:
* Source/WebGPU/WGSL/tests/valid/references.wgsl:
* Source/WebGPU/WebGPU.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/264575@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WGSL-Add-support-for-increment-and-decrement-statements branch from f8edc9b to dd11610 Compare May 26, 2023 10:09
@webkit-commit-queue
Copy link
Collaborator

Committed 264575@main (dd11610): https://commits.webkit.org/264575@main

Reviewed commits have been landed. Closing PR #14339 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit dd11610 into WebKit:main May 26, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwyrzykowski mwyrzykowski mwyrzykowski approved these changes

@litherum litherum Awaiting requested review from litherum

@djg djg Awaiting requested review from djg djg is a code owner

Assignees

@tadeuzagallo tadeuzagallo

Labels
WebGPU For bugs in WebGPU
Projects
None yet
Milestone
No milestone
4 participants
@tadeuzagallo @webkit-early-warning-system @webkit-commit-queue @mwyrzykowski